From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0362745B04; Thu, 10 Oct 2024 16:14:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CCC540677; Thu, 10 Oct 2024 16:14:36 +0200 (CEST) Received: from egress-ip11a.ess.de.barracuda.com (egress-ip11a.ess.de.barracuda.com [18.184.203.234]) by mails.dpdk.org (Postfix) with ESMTP id CD7E54026B for ; Thu, 10 Oct 2024 16:14:30 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by mx-outbound11-198.eu-central-1a.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 10 Oct 2024 14:14:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TxKpgnfyv5ZjZwZWbP4Q60jQzO3h476XzlYBVKpWuyiFI3k1wdTNoZpPJkxC+DhkBmprnV4MTRMLvSYj7blX/3+R85hcABw+K6cNBGHRYNgHzvoZAE60+5S+/yc4tDipZHMQl252Y5pUcbv7fjQhLiQJaamTsPqvf1x8UymFvOLyQymf+HUqUT67IJqkq9k8XyFdhgAnlvmbzo3Jkg89L1G7SRdfQaG1BQLwCgKBh/YJ1M3IEDYhBedVD07LDjDQqnZgXNbBNSx2LTPJmuLfgmRGWyhg+MaQRplSHYS1e64ba8XeWiYJNIFBP68oExRVuD8eN9yGGjNgNRpxjeGl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCP8cSNkABk20YAdxFV/vjKLwMJ8dAG//nDFj5K1Rlk=; b=A3f5yxhOZXx8PAvFNGI2FJ6P+JLl640hAWQYkmaAGxdXVuBeLY3d3/+fmls0Ife0m6KFVg/zDh/cul3gNXionGw9mzTGjJtr/mEuoQSy3ASM7KV56NAYHywL+ujoku4jB0kjniDMwYm2njP9EwpGiUjOA2d9X+SPOE7O4DawWqyKq1kDO5dFO5HYDTFnddU9CZYgobBAnftsQG2FyhZyIP4Dp5weu9qLuvNaEcvGUgtY4N1Nk0RIo5wH5mrOekgB60y4Pgq6tm8jB4FyLFCSV7JS4RZKdSs8ILxaATIfMoQdTyxBN9pvCd3vrPE/ubx+TZpkscP/vNSOG+6PQNyEbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CCP8cSNkABk20YAdxFV/vjKLwMJ8dAG//nDFj5K1Rlk=; b=mgPcUlwylVdRbIarL0dXTWtrBb+puB8fDNXGz39WXxxYfSnhB5/LJWvbLn4cA+WbJeN5JGv4sX8Wmy78xFzItInQjQzhLonQ1lLqGYRA1cxLiEUAQcuAfAHSYVm48sOZ/aBJIBOHMDdQTJkuoZYUD9GaowVKILJl0RYZRZObBLA= Received: from DU2PR04CA0065.eurprd04.prod.outlook.com (2603:10a6:10:232::10) by AM9P190MB1073.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:260::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Thu, 10 Oct 2024 14:14:26 +0000 Received: from DU6PEPF0000B61B.eurprd02.prod.outlook.com (2603:10a6:10:232:cafe::44) by DU2PR04CA0065.outlook.office365.com (2603:10a6:10:232::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.17 via Frontend Transport; Thu, 10 Oct 2024 14:14:26 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by DU6PEPF0000B61B.mail.protection.outlook.com (10.167.8.132) with Microsoft SMTP Server id 15.20.8048.13 via Frontend Transport; Thu, 10 Oct 2024 14:14:25 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, Oleksandr Kolomeiets Subject: [PATCH v3 04/50] net/ntnic: remove extra calling of the API for release port Date: Thu, 10 Oct 2024 16:13:19 +0200 Message-ID: <20241010141416.4063591-5-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20241010141416.4063591-1-sil-plv@napatech.com> References: <20241006203728.330792-2-sil-plv@napatech.com> <20241010141416.4063591-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF0000B61B:EE_|AM9P190MB1073:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 16ff50fa-dde0-4a50-3cff-08dce935d902 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?b52Wx314cDO4wQFbn8R7ZJ3ZBVRv5ebm3pp3f38f4T6SeyYGVSWJ4NOPYYzN?= =?us-ascii?Q?S4uCrW96w0PhLLxVrmavojHPzoTnTcFgQGPA3x4I2eY48YZWxwk4F1SvcuQ3?= =?us-ascii?Q?jOmB6Ad0S3yR3cy2scwf2X55bdECuQ4EShbmCa/wv3IfUDIBb3BLgWlcoUaq?= =?us-ascii?Q?kVvL+cJuN3Et8G/7SLaaOkSskGGjNBibq90neY6fpa8tFnTTVIg88BwapRbN?= =?us-ascii?Q?IPnnG+8cRpb/8f9r9ILYDabtTsjoO6DXZC+bgRnqPPAEyavuPx6xG9LYovg8?= =?us-ascii?Q?C6o4MFi3kAhFCI7d1KQWf4jIr+vkCC9PnuxrHAHX9Hjr090RAYSJMoTxDyge?= =?us-ascii?Q?XOuIw1MxmkeR3f9GM7ltpUpwK2oDVpoXPvAIqYJUCJPlcWuFGZrtfy6BR587?= =?us-ascii?Q?4kmJkLpuheXMoLLC5u2zR8k4Zc7FsESXVlYMmf/ODZn/7nFrCaSmmONUmzQM?= =?us-ascii?Q?lRpJocMsNkEkE2XOZ8+EkCKvrKnbW52fqC7cb9GfIofbc1sGPszPW4lPe++d?= =?us-ascii?Q?kbNA0lQ0onmmXdNCq4B6m6an/ZEiAEqrGBI9bHxI07OR6IRdy/D3gWkIGRHd?= =?us-ascii?Q?DTdNk6Of1qV/ApjTCOIEStqdlwARN96Tm4ks/+xjO+h2/hZ5pL7IjZKpd1NQ?= =?us-ascii?Q?FI7IBadjFTrtKaI+an9dPG04WZcjvf1Dy8AFMd/LIjBInivpXL2zhNVwQtda?= =?us-ascii?Q?Nyw7wwI7FxTsPAypiOfj4HHKK5FxHiLTJz8AIr2B+vnb1wSUj+SAuHqrpzK7?= =?us-ascii?Q?YT//gcTQBRhAurjQakvy0wtRM0nIcuIse7lbpov5rd3AEub39ynQq8W8EivT?= =?us-ascii?Q?XjvGEr/Z7TRJwh99Ve/LKIszPHBMBhIE7TzL4XroxapNV2isrcMfuMktNpy2?= =?us-ascii?Q?VSqjc3fitrxZ/3ZFpTP36hqdxx21n1gZIZIhYPNn2usdyyB/hqaseHvSuXhU?= =?us-ascii?Q?pzwzaqIIR1OygjoM4qZtZEml5B45GOQN3VXgX3Q1XYx1ZWYb8O4wSoavjUzr?= =?us-ascii?Q?fay2YzT6Q0izduUaX6HtO8NPBGIZGXI00bsJ/Y3XR3KFD6RdioKKLnYCDbNl?= =?us-ascii?Q?/S3WMYM3ikTwBPfXdOkW3tvhuMst1CMdGAM+xg6uXdMwpznrloBoguMnu9nh?= =?us-ascii?Q?BieseLkkdFCsaJLZRNPt7hypDCc6qBus2WSci60PaTc1A7+30u8ciJcfh+sp?= =?us-ascii?Q?hsz3YUJTbr7SZtHzJub75xQn9eI2Ljw2ZljKTZdwQoMJWgAL9pCEoqNmrdDK?= =?us-ascii?Q?xlBvn77cVWwCKR5ABiFYycAqhciIIf+TSk0SEaB0ZXu4CGUG4diTeFJWqASq?= =?us-ascii?Q?YyRC6xFoC1WVNZhzg6eyCEm+Eu+XUmG0MQG/Yjv4ZrA4Ux1CqQLofhPrMp9K?= =?us-ascii?Q?aLT3q2s=3D?= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tnPffH+IJWaAKIvfL0mscT4U9az1pxnn6O2zuWyReykrWJ6iAh2E5emMrNMktkrP2EJIhOjhQPOjwBml/izvlxkpSAym+WiZZCNYF6HkQcWFsQHqFcyrjBwXv+niGqNaJoySxfIHnFG4pPSOy6IrtcbZO1yGpj2cdrsQL4vrgoguyCJ7TWLaOCfXXrjjLOytsi0UdPI7bsGde7/F9LTgso6qUlysyiPb2v/SOp2iaHjNX59BDC/HK4Rfvt/06MUoKipbTCn5DcYCO9MLs9G+Zwoqhr1UhTFBxiM8JiSulz8P0D9Vb8niR+BtdKFxj2tbOFIb9WcruysWOcQ/Z75w8PU34dCZpUFxBaddElLnU7K9rbxdJJuCSJIvdTJyVglWYok1JESyR47jXkUnkhhlPi+l2sRiIjkk7tjlJ+8Ru5tMdIe0NdA4XhGUtU7Srye95C18J6d+qKLwqPGl3htnqN/qvuiopJLo0O0aIdQ0olGWZBEvGPNbTe6xIhR1sRVSueAyo56c+B93P8xqIytPGD/BxBOVATWbLupTkWjuG8JK4Oeiyji3AdWhaYpFiDhwMnXy42XypeekypbDU3FrsAipTeHmJO0EHm0BJgrPnFojxhykDQJzootxFYdqJiLihj4MMMuI+AQzwCqz+5s3Z/bd1bR5m0cXh3X4w2FzAHE= X-OriginatorOrg: napatech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 14:14:25.9358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16ff50fa-dde0-4a50-3cff-08dce935d902 X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000B61B.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P190MB1073 X-BESS-ID: 1728569668-303014-12783-25597-2 X-BESS-VER: 2019.1_20241004.2057 X-BESS-Apparent-Source-IP: 104.47.18.111 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVoYmBoZAVgZQMMksySAtxdTEIs nQIiXZIDHR3NLY1CDNKDk51SDZwMhcqTYWAJG0Go5BAAAA X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.259630 [from cloudscan11-221.eu-central-1a.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-prone. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst | 1 + drivers/net/ntnic/ntnic_ethdev.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst index e85549c1e1..c808639ee9 100644 --- a/doc/guides/rel_notes/release_24_11.rst +++ b/doc/guides/rel_notes/release_24_11.rst @@ -102,6 +102,7 @@ New Features * Update supported version of the FPGA to 9563.55.49 * Fix Coverity issues + * Fix issues related to release 24.07 Removed Items ------------- diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c index f351469d0a..52ca8f2844 100644 --- a/drivers/net/ntnic/ntnic_ethdev.c +++ b/drivers/net/ntnic/ntnic_ethdev.c @@ -383,7 +383,6 @@ eth_dev_close(struct rte_eth_dev *eth_dev) internals->p_drv = NULL; - rte_eth_dev_release_port(eth_dev); if (p_drv) { /* decrease initialized ethernet devices */ p_drv->n_eth_dev_init_count--; -- 2.45.0