From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: [PATCH] devtools: exclude common EAL header from attribute check
Date: Thu, 10 Oct 2024 19:00:42 +0200 [thread overview]
Message-ID: <20241010170042.2719147-1-david.marchand@redhat.com> (raw)
With the addition of SKIP_FILES in
commit 7e421ae345f4 ("devtools: support skipping forbid rule check"),
it is possible to avoid false positive on adding
attribute wrapper in rte_common.h.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 0ab841bd5a..c23792025a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -89,6 +89,7 @@ check_forbidden_additions() { # <patch>
# refrain from using compiler attribute without defining a common macro
awk -v FOLDERS="lib drivers app examples" \
+ -v SKIP_FILES='lib/eal/include/rte_common.h' \
-v EXPRESSIONS="__attribute__" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Using compiler attribute directly' \
--
2.46.2
next reply other threads:[~2024-10-10 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 17:00 David Marchand [this message]
2024-10-10 17:40 ` Stephen Hemminger
2024-10-11 9:04 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010170042.2719147-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).