From: Dean Marx <dmarx@iol.unh.edu>
To: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com
Cc: dev@dpdk.org, Dean Marx <dmarx@iol.unh.edu>
Subject: [PATCH v2] dts: fix verify argument in set forward mode
Date: Thu, 10 Oct 2024 14:42:26 -0400 [thread overview]
Message-ID: <20241010184226.4088-1-dmarx@iol.unh.edu> (raw)
In-Reply-To: <20240812142355.12532-1-dmarx@iol.unh.edu>
Fix optional verify argument in set_forward_mode
method in testpmd shell class.
Bugzilla ID: 1410
Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params")
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
dts/framework/remote_session/testpmd_shell.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index dc1bef431d..c43b8b7520 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -1567,11 +1567,12 @@ def set_forward_mode(self, mode: SimpleForwardingModes, verify: bool = True):
fails to update.
"""
set_fwd_output = self.send_command(f"set fwd {mode.value}")
- if f"Set {mode.value} packet forwarding mode" not in set_fwd_output:
- self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}")
- raise InteractiveCommandExecutionError(
- f"Test pmd failed to set fwd mode to {mode.value}"
- )
+ if verify:
+ if f"Set {mode.value} packet forwarding mode" not in set_fwd_output:
+ self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}")
+ raise InteractiveCommandExecutionError(
+ f"Test pmd failed to set fwd mode to {mode.value}"
+ )
def stop_all_ports(self, verify: bool = True) -> None:
"""Stops all the ports.
--
2.44.0
next prev parent reply other threads:[~2024-10-10 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:23 [PATCH v1] dts: add verify argument to " Dean Marx
2024-08-12 15:29 ` Jeremy Spewock
2024-09-16 10:42 ` Juraj Linkeš
2024-10-10 18:42 ` Dean Marx [this message]
2024-10-10 18:43 ` [PATCH v2] dts: fix verify argument in " Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010184226.4088-1-dmarx@iol.unh.edu \
--to=dmarx@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).