From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9544745B09; Thu, 10 Oct 2024 20:42:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23673402BB; Thu, 10 Oct 2024 20:42:03 +0200 (CEST) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mails.dpdk.org (Postfix) with ESMTP id 635BF4025D for ; Thu, 10 Oct 2024 20:42:01 +0200 (CEST) Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7ac83a98e5eso109098085a.0 for ; Thu, 10 Oct 2024 11:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1728585721; x=1729190521; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nag/2Uctus9pznlARrMAjXrQZjoRCxgrw1tRVUwrlMs=; b=CBZMqV8L0NN0vaewBmUmgBBEcN+jV7y1Tx6mO+K6Se1SkqOk2/LOAW+rrLnoB45MEu 1QOmpJMG1Gwx5AsCr1eMpi7stRBYipFRkx4kH67EUYg31nbnIedrn2ohlqIRMeCPoG/u S+So39uWL9UGsCNgyoE8WdfaR0GtaEA3VCg6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728585721; x=1729190521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nag/2Uctus9pznlARrMAjXrQZjoRCxgrw1tRVUwrlMs=; b=igni+I++cxMZwJvmARUVAMBzwBjqQ4nmdy0TW5ygXmkyT4e9LY8I7+QqnXgqzhWw0e DuzQr9P6fiCzlzpy1jyduYxnEwwCdOWZLZMpnam+nHI6SjNjZxt8mRmqxvOhLe4JtvSG Uqt8HTrHQYu08lU0ucM5MDe5ZgWO5Ui2iBlMz72zKunusDprCaHeai4D/hpM6fgUK4a4 xa8NUT83+9340aoNFTvL9opn7hC8StmyhkjTvS6KKsgTwmPgvH47exjKvprKA7oCUh1Q Y/MgYxctaWX/C9cqLx48Z4iMTYbfBBzYzvQfDGpxnuXBcD8U/wnyeMle32LnzUtr/XuE C+4w== X-Gm-Message-State: AOJu0Yyp8EmoSWvYaqpK10zVxvIb+2nWMhcWKDyaXODOJLUYawnUVIaU WkgwyELAxHX85in6zEwWODmZp4n6MhJy5U+cJfUYxFzk0ovM7h92B5MYfnjgdm0= X-Google-Smtp-Source: AGHT+IFVqSICaqqZgFUcyjR8phPl2c2z7kc1Zj3qHyOVFJlLoI1fFnkfTRjUpt0lHsHcJ/pc0VdkSg== X-Received: by 2002:a05:620a:4727:b0:7ac:a93b:4d3a with SMTP id af79cd13be357-7b11a3c42a2mr14621485a.28.1728585720665; Thu, 10 Oct 2024 11:42:00 -0700 (PDT) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b114958a0fsm66763785a.75.2024.10.10.11.41.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 11:42:00 -0700 (PDT) From: Dean Marx To: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v2] dts: fix verify argument in set forward mode Date: Thu, 10 Oct 2024 14:42:26 -0400 Message-ID: <20241010184226.4088-1-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240812142355.12532-1-dmarx@iol.unh.edu> References: <20240812142355.12532-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix optional verify argument in set_forward_mode method in testpmd shell class. Bugzilla ID: 1410 Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index dc1bef431d..c43b8b7520 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -1567,11 +1567,12 @@ def set_forward_mode(self, mode: SimpleForwardingModes, verify: bool = True): fails to update. """ set_fwd_output = self.send_command(f"set fwd {mode.value}") - if f"Set {mode.value} packet forwarding mode" not in set_fwd_output: - self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}") - raise InteractiveCommandExecutionError( - f"Test pmd failed to set fwd mode to {mode.value}" - ) + if verify: + if f"Set {mode.value} packet forwarding mode" not in set_fwd_output: + self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}") + raise InteractiveCommandExecutionError( + f"Test pmd failed to set fwd mode to {mode.value}" + ) def stop_all_ports(self, verify: bool = True) -> None: """Stops all the ports. -- 2.44.0