From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FA1A45B0C; Fri, 11 Oct 2024 04:08:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F04F9402EE; Fri, 11 Oct 2024 04:08:55 +0200 (CEST) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 8E5F3402E1 for ; Fri, 11 Oct 2024 04:08:54 +0200 (CEST) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2e28b75dbd6so1243662a91.0 for ; Thu, 10 Oct 2024 19:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728612534; x=1729217334; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JU5zVP/5mDutLJD0mhSc5pY/HIqvFZ7MN0ZRB9AkXKw=; b=VjFaVh69mkM8KOa/BlnU8sQyy9IMwWth+jpjXYiHlfFqItn6yNGXqfambaYkahKoB8 Cm8KZhuUgtujo2+wjgYIXM2ZToWOjq4mQwwI78UFk+Df1lnNurymp76BXAxD7u1xj4fF awyTtXeUdA7OEi6sNA3Yq1w1BDwz8O7cwaLP+aRNDauQ1eo8dUJ0EUn+InLJjCAWGxJg hog/KngxnQZ1nCAIUY7YD8uvk9aGDW1SbaQKVRlnXpkJygDOfcFIcYy/Orh+NFyN1PcV RhI67vyzHQuRbXCrwEEqaqWo3Kco2HGp2OU6CHzk91edOodCYwMCuJkL+5VPVqAorW7D rVGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728612534; x=1729217334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JU5zVP/5mDutLJD0mhSc5pY/HIqvFZ7MN0ZRB9AkXKw=; b=Ntxd7o1g1UWL4pCdQDQiBowYKiutykDQW8U6+6a/lQaOMgsnkMWyWNgNsB8hnNqdzw fh6bNx1uGTuyzME96828kjU9D6m6kyCy1aqRzYm4tKwpNElhNcU/97h5iUd61Aye21qU 5sacmDzOPfarHe9FhJuUOdQ9O9ZFF+GFllIAMYvK3WDVKhjHs8tTdJ+TcJakF7bGcTbx NDtLIAK+w9ZmDH0sYWfD12b3JEj+8T9Rr/qKjkSdLloLE+aBJYOZqDaBtafZVifW1SXk wsNCVBn2AkIKH7F58A27LGCFarup4FaZuXGUaIdEpQUwzQMg3Dn4pkNcrYuQiG9nyXvv ZaJA== X-Forwarded-Encrypted: i=1; AJvYcCWSPaF/FG+pI7wMBoLZG7d5cWNB7Tt/LRx09g4XAR5j3SyimpQ4/In560IKU2+zY1jmr+I=@dpdk.org X-Gm-Message-State: AOJu0YxGu9Z0BBGFS4rdQTJWLSwe/YD9XLWMllfAKDtZCdulb9dYfYoc zm+i5bUUPcTqISeJ2gimboHjLXoY/loKoJNVtwWkMhLy2gEg90tCoxeO3TiwBfY= X-Google-Smtp-Source: AGHT+IEKyND6VZxgYHHx3eqjYgpcrOxRe02xrYIckVOR0LoDFMROZ9FM/qixmrPDL1Uzr8n49TyUcw== X-Received: by 2002:a17:90b:fd8:b0:2e2:af0b:8f2d with SMTP id 98e67ed59e1d1-2e2f0c5c2ddmr1554584a91.26.1728612533679; Thu, 10 Oct 2024 19:08:53 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2da6c5235sm1119073a91.0.2024.10.10.19.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 19:08:53 -0700 (PDT) Date: Thu, 10 Oct 2024 19:08:51 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , Subject: Re: [PATCH 1/7] app/test: introduce UT suite framework for kvargs Message-ID: <20241010190851.48011478@hermes.local> In-Reply-To: <20231103095325.47843-2-fengchengwen@huawei.com> References: <20231103095325.47843-1-fengchengwen@huawei.com> <20231103095325.47843-2-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 3 Nov 2023 09:53:19 +0000 Chengwen Feng wrote: > Introduce unit test suite framework for test_kvargs.c. > > Signed-off-by: Chengwen Feng > --- > app/test/test_kvargs.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c > index 7a60cac4c1..9aeb9aa0aa 100644 > --- a/app/test/test_kvargs.c > +++ b/app/test/test_kvargs.c > @@ -1,5 +1,6 @@ > /* SPDX-License-Identifier: BSD-3-Clause > * Copyright 2014 6WIND S.A. > + * Copyright(c) 2023 HiSilicon Limited > */ The test changes look good and it is always better to have more tests. IANAL but starting the precedent of allowing adding copyright whenever a file is touched just leads to lots of meaningless fluff.