DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dean Marx <dmarx@iol.unh.edu>
To: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com,
	yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
	paul.szczepanek@arm.com
Cc: dev@dpdk.org, Dean Marx <dmarx@iol.unh.edu>
Subject: [PATCH v7 1/2] dts: add multicast set function to shell
Date: Thu, 10 Oct 2024 16:21:03 -0400	[thread overview]
Message-ID: <20241010202104.15364-2-dmarx@iol.unh.edu> (raw)
In-Reply-To: <20241010202104.15364-1-dmarx@iol.unh.edu>

Add set multicast function for changing allmulticast mode
within testpmd shell.

Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
 dts/framework/remote_session/testpmd_shell.py | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index dc1bef431d..ab0ffa930d 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -1718,6 +1718,30 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats:
 
         return TestPmdPortStats.parse(output)
 
+    def set_multicast_all(self, on: bool, verify: bool = True):
+        """Turns multicast mode on/off for the specified port.
+
+        Args:
+            on: If :data:`True`, turns multicast mode on, otherwise turns off.
+            verify: If :data:`True` an additional command will be sent to verify
+            that multicast mode is properly set. Defaults to :data:`True`.
+
+        Raises:
+            InteractiveCommandExecutionError: If `verify` is :data:`True` and multicast
+                mode is not properly set.
+        """
+        multicast_cmd_output = self.send_command(f"set allmulti all {'on' if on else 'off'}")
+        if verify:
+            stats0 = self.show_port_info(port_id=0)
+            stats1 = self.show_port_info(port_id=1)
+            if on ^ (stats0.is_allmulticast_mode_enabled and stats1.is_allmulticast_mode_enabled):
+                self._logger.debug(
+                    f"Failed to set multicast mode on all ports.: \n{multicast_cmd_output}"
+                )
+                raise InteractiveCommandExecutionError(
+                    "Testpmd failed to set multicast mode on all ports."
+                )
+
     @requires_stopped_ports
     def set_port_mtu(self, port_id: int, mtu: int, verify: bool = True) -> None:
         """Change the MTU of a port using testpmd.
-- 
2.44.0


  reply	other threads:[~2024-10-10 20:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 19:19 [PATCH v2 0/4] dts: initial dynamic config suite Dean Marx
2024-07-08 19:19 ` [PATCH v2 1/4] dts: add multicast set function to shell Dean Marx
2024-07-10 16:44   ` Jeremy Spewock
2024-07-08 19:19 ` [PATCH v2 2/4] dts: add toggle option to send and capture Dean Marx
2024-07-08 19:19 ` [PATCH v2 3/4] dts: dynamic config conf schema Dean Marx
2024-07-08 19:19 ` [PATCH v2 4/4] dts: dynamic config test suite Dean Marx
2024-07-08 19:30 ` [PATCH v3 1/4] dts: add multicast set function to shell Dean Marx
2024-07-08 19:30   ` [PATCH v3 2/4] dts: add toggle option to send and capture Dean Marx
2024-07-10 16:13     ` Jeremy Spewock
2024-07-08 19:30   ` [PATCH v3 3/4] dts: dynamic config conf schema Dean Marx
2024-07-10 16:45     ` Jeremy Spewock
2024-07-08 19:30   ` [PATCH v3 4/4] dts: dynamic config test suite Dean Marx
2024-07-10 16:45     ` Jeremy Spewock
2024-07-15 16:00 ` [PATCH v4 1/3] dts: add multicast set function to shell Dean Marx
2024-07-15 16:00   ` [PATCH v4 2/3] dts: dynamic config conf schema Dean Marx
2024-07-15 20:22     ` Jeremy Spewock
2024-07-15 16:00   ` [PATCH v4 3/3] dts: dynamic config test suite Dean Marx
2024-07-15 20:22     ` Jeremy Spewock
2024-07-15 20:22   ` [PATCH v4 1/3] dts: add multicast set function to shell Jeremy Spewock
2024-07-24 19:21 ` [PATCH v5 0/3] dts: refactored dynamic config test suite Dean Marx
2024-07-24 19:21   ` [PATCH v5 1/3] dts: add multicast set function to shell Dean Marx
2024-08-07 15:50     ` Luca Vizzarro
2024-07-24 19:21   ` [PATCH v5 2/3] dts: dynamic config conf schema Dean Marx
2024-07-26 19:35     ` Jeremy Spewock
2024-08-07 15:56     ` Luca Vizzarro
2024-07-24 19:21   ` [PATCH v5 3/3] dts: dynamic config test suite Dean Marx
2024-07-26 19:35     ` Jeremy Spewock
2024-08-07 19:18   ` [PATCH v6 0/2] dts: refactored " Dean Marx
2024-08-07 19:18     ` [PATCH v6 1/2] dts: add multicast set function to shell Dean Marx
2024-08-07 19:18     ` [PATCH v6 2/2] dts: dynamic config test suite Dean Marx
2024-10-10 20:17     ` [PATCH v7 0/2] dts: port over dynamic config suite Dean Marx
2024-10-10 20:17       ` [PATCH v7 1/2] dts: add multicast set funciton to shell Dean Marx
2024-10-10 20:17       ` [PATCH v7 2/2] dts: port over dynamic config test suite Dean Marx
2024-10-10 20:21     ` [PATCH v7 0/2] dts: port over dynamic config suite Dean Marx
2024-10-10 20:21       ` Dean Marx [this message]
2024-10-10 20:21       ` [PATCH v7 2/2] dts: port over dynamic config test suite Dean Marx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241010202104.15364-2-dmarx@iol.unh.edu \
    --to=dmarx@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=luca.vizzarro@arm.com \
    --cc=npratte@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).