From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1546445B13; Fri, 11 Oct 2024 16:19:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C0FC402A1; Fri, 11 Oct 2024 16:19:08 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 0AA414028B for ; Fri, 11 Oct 2024 16:19:07 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-208cf673b8dso22261555ad.3 for ; Fri, 11 Oct 2024 07:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728656346; x=1729261146; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JyWR2FQG8MPrTqegHQ2Vn3JLz0DU+H7oVCu4m+hM3AQ=; b=XqwnEiTL7lKiOolfUyrvMNoWvxsQWCVZQQW5Log6dBHgVuKz/jW/HSrIbS2XtSBEGW f7JEFXAmz2M4NsKS7yt83hGNiHA89OLvEi6XCV96ipd0L7L12h+9q8voeDu2nek7WUXO obIY/n+rR7SZR0cVSPvetQuM3M2SKPq+c9fdQ6bMfxqOfTOlX+wtaY7tqrwf/exR3nxJ il1Li3nNjDyQqZE80uQ7Nb2O1KdV3gL8kTeNdfKugginpOiFqbFLngNHu30cXcv0N9fS oMixTbqT74AFHGkTCXcz2u2z3ElPAkgIrNbi9CnzUbjZYATR8JGY1kjCFy/oC9rNUWbW yndA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728656346; x=1729261146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JyWR2FQG8MPrTqegHQ2Vn3JLz0DU+H7oVCu4m+hM3AQ=; b=o/N78twNVLo9InL8+a+0jQV9D17fxbeK/5Mvv7t0BwjqgVK0dK9eZ9yFByaAuC3aGX VFusVvZxvb3r3i7VWldMz2MW1uVsSXLW6kpT//EkgxXVp73W2x1Mw5YLdQhdG4DZMeWV N3azV8rCRt24W0KHOjMJd02nftnhz7Nu3bmLhYEbYWPAXJkDVAcdTk+C16wrhRdjEAYS 5gx00pMidyudwSHsgOqjq4giWP7VLjkAFvjZji3OeyRUapfFjAOlUv57O8MS9BSyZ6Ti YDqTK/wAvoXIVBytshVm5+bUm8lZIDBxpTMfS+xu1BIg7DtyCOixNAw9wfRIDos7Qn5V N6Gw== X-Forwarded-Encrypted: i=1; AJvYcCXFDRX1bbTzrBcV/+jPVLGu2EK/7Mc3RCT4taybv5JwaHgS77s4zaHIs+1A9M5JkDWCECA=@dpdk.org X-Gm-Message-State: AOJu0YyHzTUR/2E7Ge3y/KllzKlBneG++4TZrIa3p7elNGDOdNHaqWRq OXemffvTJHCA6ZoYdN/clTUZALFdShvz4p88DYahl6lXoA2bGN3ouINOChRw5d4= X-Google-Smtp-Source: AGHT+IF9stiXF5kLAlWSXzJmodrrNRYAX5rHqV8Z9YPI8JwA/vOQTm8lvgIlFSzI+YKZvWM6kELl2A== X-Received: by 2002:a17:903:2d2:b0:20c:850f:d3d9 with SMTP id d9443c01a7336-20ca147231fmr39419895ad.24.1728656346053; Fri, 11 Oct 2024 07:19:06 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8bad991csm23790865ad.55.2024.10.11.07.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 07:19:05 -0700 (PDT) Date: Fri, 11 Oct 2024 07:19:04 -0700 From: Stephen Hemminger To: Konstantin Ananyev Cc: Tomasz Duszynski , Thomas Monjalon , "Ruifeng.Wang@arm.com" , "bruce.richardson@intel.com" , "david.marchand@redhat.com" , "dev@dpdk.org" , "jerinj@marvell.com" , "konstantin.v.ananyev@yandex.ru" , "mattias.ronnblom@ericsson.com" , "mb@smartsharesystems.com" , "roretzla@linux.microsoft.com" , "zhoumin@loongson.cn" Subject: Re: [PATCH v14 1/4] lib: add generic support for reading PMU events Message-ID: <20241011071904.6f8064c7@hermes.local> In-Reply-To: <660c6a2a24fd4cd785333881208fb659@huawei.com> References: <20241009112308.2973903-1-tduszynski@marvell.com> <20241011094944.3586051-1-tduszynski@marvell.com> <20241011094944.3586051-2-tduszynski@marvell.com> <660c6a2a24fd4cd785333881208fb659@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 11 Oct 2024 11:56:04 +0000 Konstantin Ananyev wrote: > > + * > > + * @return > > + * 0 in case of success, negative value otherwise. > > + */ > > +__rte_experimental > > +int > > +rte_pmu_init(void); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Finalize PMU library. This should be called after PMU counters are no longer being read. > > + */ > > +__rte_experimental > > +void > > +rte_pmu_fini(void); > > Hmm..., why _fini_() is allowed to be called directly while _init_() doesn't? Is this handled by destructor, called from rte_eal_cleanup() and/or testpmd?