From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8796C45B17;
Fri, 11 Oct 2024 21:02:43 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1C49A410D5;
Fri, 11 Oct 2024 21:02:43 +0200 (CEST)
Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com
[209.85.210.169])
by mails.dpdk.org (Postfix) with ESMTP id 0EE5540EDD
for <dev@dpdk.org>; Fri, 11 Oct 2024 21:02:41 +0200 (CEST)
Received: by mail-pf1-f169.google.com with SMTP id
d2e1a72fcca58-71e4244fdc6so608941b3a.0
for <dev@dpdk.org>; Fri, 11 Oct 2024 12:02:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728673361;
x=1729278161; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:from:to:cc:subject:date:message-id
:reply-to; bh=LpFB2HgL8xxoF8w+ydxYhhZH6jvTrw1G/4egBhuRTUk=;
b=JOriIMOE85EHO2g13Vnv4xPXnDuB8VRZw2A72HU/Ow6VXWjAFAo9keBpmUOgocgBA7
jW8+5i7+7p6UunbsoIDK0FdTdmMTDPuGuBk+sk0zuJ9N3nZwb/8jfZ9VgSUq6/kpPX8p
hEU0O+2RdHRuFzg4gf+TUl8eB2vkufWOKVQ6oT+KRucXEYUrs4WoTjXfvo8qkKdA4LSt
sukZQDXaT/cHcO2jucWJFW6DWgPlg86+k9XE/B76ljSQIjQqNzjSpgdlbHqd7/6r7NxC
ZdtyEoQQuHkwgQ8Fix/1rQIIN74cKgJrD9SxlHY9ngzEMhkm8nqREZCdb8kAiShJDa0/
/yFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1728673361; x=1729278161;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=LpFB2HgL8xxoF8w+ydxYhhZH6jvTrw1G/4egBhuRTUk=;
b=M1sghLAsEpjL78txDvpzBl3ITGGLYWPa7l3iVpmbSlALIBJOj3LeTjFitMfnZjCOD2
qQ2WA6+fwxhToWBHmn8JUcaFXCHNmPY1Vb2uURtWI/E+h4QTJ3+sgKnvKUbOCCmY6atq
p41p+S1GRNwzsWJ29xyZ5aFZhv1/bMmqARCeFSMt2hroN1pTu07DQipjrnUY0EXIrzQB
u0onVoHw8QJiIKJd10GXsRurBx5kOcWge9UPk6XqO/wRneSOA0xBBYypdxl59q7tQust
LKGLDhcFEXsKXii8S+Jwm9pEtfPMTmJCzmsNf2nM6VQKJz7MbWAGvNcz8KOw5OWw6GRy
WffQ==
X-Gm-Message-State: AOJu0YygaChUgJo4rjucAbB4HkTnD/VRL+NAyswv484Azhfa3mlE1kLF
DfnaPnF+vDW1wuFXMqy7z+mBIhmFuNRpCU64GB/lxEKgOIEc/JfXhLVnJVuU8Hxnb/baw/+c4sX
p
X-Google-Smtp-Source: AGHT+IFKo1Af2F6zBEEKT90HYbDlIWM94hHkJTx/1lMz7SlUbiPP2EJfZuH08BuhK2l9p3b1C36JrA==
X-Received: by 2002:a05:6a00:2e97:b0:71e:cc7:c507 with SMTP id
d2e1a72fcca58-71e4c1cf183mr908530b3a.23.1728673360862;
Fri, 11 Oct 2024 12:02:40 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-71e4a8dec16sm320819b3a.40.2024.10.11.12.02.40
for <dev@dpdk.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 11 Oct 2024 12:02:40 -0700 (PDT)
Date: Fri, 11 Oct 2024 12:02:15 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [PATCH 3/3] net/tap: increase the maximum allowable queues
Message-ID: <20241011120215.5a46269f@hermes.local>
In-Reply-To: <20241011173026.170884-4-stephen@networkplumber.org>
References: <20241011173026.170884-1-stephen@networkplumber.org>
<20241011173026.170884-4-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Fri, 11 Oct 2024 10:29:25 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The default of 16 is too low for larger systems, and the limit
> is set at compile time.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/tap/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
> index 5e5a3ad3c6..fa4e6cbec9 100644
> --- a/drivers/net/tap/meson.build
> +++ b/drivers/net/tap/meson.build
> @@ -14,7 +14,7 @@ sources = files(
>
> deps = ['bus_vdev', 'gso', 'hash']
>
> -max_queues = '-DTAP_MAX_QUEUES=16'
> +max_queues = '-DTAP_MAX_QUEUES=64'
> cflags += max_queues
>
> require_iova_in_mbuf = false
Why does this build fail on Loongix? It works on x86 and Arm.
Is it something about being merged to wrong main branch?
Loongnix-Server 8.3
Kernel: 4.19.190+
Compiler: gcc 8.3
Ninja build logs:
-------------------------------BEGIN LOGS----------------------------
FAILED: drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o
cc -Idrivers/libtmp_rte_net_tap.a.p -Idrivers -I../drivers -Idrivers/net/tap -I../drivers/net/tap -Idrivers/bus/vdev -I../drivers/bus/vdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/gso -I../lib/gso -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definit
ion -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DTAP_MAX_QUEUES=64 -DHAVE_TCA_FLOWER -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.tap -MD -MQ drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o -MF drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o.d -o drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o -c ../drivers/net/tap/rte_eth_tap.c
In file included from ../drivers/net/tap/rte_eth_tap.c:23:
./drivers/net/tap/rte_eth_tap.c:75:1: error: static assertion failed: "TAP max queues exceeds MP fd limit"
static_assert(RTE_PMD_TAP_MAX_QUEUES <= RTE_MP_MAX_FD_NUM, "TAP max queues exceeds MP fd limit");