DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 6/9] net/ice/base: optimize subtree searches
Date: Fri, 11 Oct 2024 17:44:56 +0100	[thread overview]
Message-ID: <20241011164459.1987538-7-bruce.richardson@intel.com> (raw)
In-Reply-To: <20241011164459.1987538-1-bruce.richardson@intel.com>

In a number of places throughout the driver code, we want to confirm
that a scheduler node is indeed a child of another node. Currently, this
is confirmed by searching down the tree from the base until the desired
node is hit, a search which may hit many irrelevant tree nodes when
recursing down wrong branches. By switching the direction of search, to
check upwards from the node to the parent, we can avoid any incorrect
paths, and so speed up processing.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/ice/base/ice_sched.c | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c
index 45934f9152..4c5c19daf3 100644
--- a/drivers/net/ice/base/ice_sched.c
+++ b/drivers/net/ice/base/ice_sched.c
@@ -1464,25 +1464,16 @@ void ice_sched_get_psm_clk_freq(struct ice_hw *hw)
  * subtree or not
  */
 bool
-ice_sched_find_node_in_subtree(struct ice_hw *hw, struct ice_sched_node *base,
+ice_sched_find_node_in_subtree(struct ice_hw __ALWAYS_UNUSED *hw,
+			       struct ice_sched_node *base,
 			       struct ice_sched_node *node)
 {
-	u8 i;
-
-	for (i = 0; i < base->num_children; i++) {
-		struct ice_sched_node *child = base->children[i];
-
-		if (node == child)
-			return true;
-
-		if (child->tx_sched_layer > node->tx_sched_layer)
-			return false;
-
-		/* this recursion is intentional, and wouldn't
-		 * go more than 8 calls
-		 */
-		if (ice_sched_find_node_in_subtree(hw, child, node))
+	if (base == node)
+		return true;
+	while (node->tx_sched_layer != 0 && node->parent != NULL) {
+		if (node->parent == base)
 			return true;
+		node = node->parent;
 	}
 	return false;
 }
-- 
2.43.0


  parent reply	other threads:[~2024-10-11 16:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 16:44 [PATCH 0/9] net/ice: base code update for RC2 Bruce Richardson
2024-10-11 16:44 ` [PATCH 1/9] net/ice/base: re-enable bypass mode for E822 Bruce Richardson
2024-10-11 16:44 ` [PATCH 2/9] net/ice/base: add bounds check Bruce Richardson
2024-10-11 16:44 ` [PATCH 3/9] net/ice/base: fix VLAN replay after reset Bruce Richardson
2024-10-11 16:44 ` [PATCH 4/9] net/ice/base: remove 255 limit on sched child nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 5/9] net/ice/base: set VSI index on newly created nodes Bruce Richardson
2024-10-11 16:44 ` Bruce Richardson [this message]
2024-10-11 16:44 ` [PATCH 7/9] net/ice/base: remove flag checks before topology upload Bruce Richardson
2024-10-11 16:44 ` [PATCH 8/9] net/ice/base: allow init without TC class sched nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 9/9] net/ice/base: read VSI layer info from VSI Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 00/10] net/ice: base code update for RC2 Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 01/10] net/ice/base: re-enable bypass mode for E822 Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 02/10] net/ice/base: add bounds check Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 03/10] net/ice/base: fix VLAN replay after reset Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 04/10] net/ice/base: remove 255 limit on sched child nodes Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 05/10] net/ice/base: set VSI index on newly created nodes Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 06/10] net/ice/base: optimize subtree searches Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 07/10] net/ice/base: remove flag checks before topology upload Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 08/10] net/ice/base: allow init without TC class sched nodes Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 09/10] net/ice/base: read VSI layer info from VSI Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 10/10] net/ice/base: update README Bruce Richardson
2024-10-14 17:27   ` [PATCH v2 00/10] net/ice: base code update for RC2 Medvedkin, Vladimir
2024-10-15 10:05     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011164459.1987538-7-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).