From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60F9245B14; Fri, 11 Oct 2024 18:45:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 851D9406BA; Fri, 11 Oct 2024 18:45:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 8BE4A402EA for ; Fri, 11 Oct 2024 18:45:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728665129; x=1760201129; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4e/5dBp6NK98d5BwhwH31Tl4zhrqp4JJtvfH9jaKhIU=; b=nIQi0m0CEVZeB2MC/GRS5AtPh+0ttUrYxaTXtQJw1D5CLikiSI9+QA5u xxXVooPPOXXZfOVhYfe9dnCgyXb4tDsyr7J2YKa6m7eT0950dru2UJh8I 0PVoRwSCrC1xLyDsUkY6yfrKNFBoG2jF9aJ9RDldNnz2+wE9ZIVYe/0H1 w38PrDvP2OFxVG1Pi1dpk/s9WTlnYO34BHJlEjz+kaA2FKncoStIqrfgn m0fok5XQfwD8ZrtSa2G6obN9m7zn4G2OlN7KC5QTIn98fPqraFkizH1hB ZYg6c7g3e5UJJmTRl0GzEDYGeOc9JFMDWkI32BkRM0KWVNe7iXOqceoNE w==; X-CSE-ConnectionGUID: DYg4FyXuS5iDzmsRiZqCiw== X-CSE-MsgGUID: JFm4+W2lR96O8H68Q+sxMQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="53477065" X-IronPort-AV: E=Sophos;i="6.11,196,1725346800"; d="scan'208";a="53477065" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 09:45:29 -0700 X-CSE-ConnectionGUID: fS8uHOs5Sm++dYC+D1WNaA== X-CSE-MsgGUID: JTQs1z8lT0GVRpyAKReL/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,196,1725346800"; d="scan'208";a="76609325" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.25]) by fmviesa007.fm.intel.com with ESMTP; 11 Oct 2024 09:45:29 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Subject: [PATCH 7/9] net/ice/base: remove flag checks before topology upload Date: Fri, 11 Oct 2024 17:44:57 +0100 Message-ID: <20241011164459.1987538-8-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241011164459.1987538-1-bruce.richardson@intel.com> References: <20241011164459.1987538-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org DPDK should support more than just 9-level or 5-level topologies, so remove the checks for those particular settings. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index 90aaa6b331..c17a58eab8 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -2384,38 +2384,6 @@ int ice_cfg_tx_topo(struct ice_hw *hw, u8 *buf, u32 len) return status; } - /* Is default topology already applied ? */ - if (!(flags & ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW) && - hw->num_tx_sched_layers == 9) { - ice_debug(hw, ICE_DBG_INIT, "Loaded default topology\n"); - /* Already default topology is loaded */ - return ICE_ERR_ALREADY_EXISTS; - } - - /* Is new topology already applied ? */ - if ((flags & ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW) && - hw->num_tx_sched_layers == 5) { - ice_debug(hw, ICE_DBG_INIT, "Loaded new topology\n"); - /* Already new topology is loaded */ - return ICE_ERR_ALREADY_EXISTS; - } - - /* Is set topology issued already ? */ - if (flags & ICE_AQC_TX_TOPO_FLAGS_ISSUED) { - ice_debug(hw, ICE_DBG_INIT, "Update tx topology was done by another PF\n"); - /* add a small delay before exiting */ - for (i = 0; i < 20; i++) - ice_msec_delay(100, true); - return ICE_ERR_ALREADY_EXISTS; - } - - /* Change the topology from new to default (5 to 9) */ - if (!(flags & ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW) && - hw->num_tx_sched_layers == 5) { - ice_debug(hw, ICE_DBG_INIT, "Change topology from 5 to 9 layers\n"); - goto update_topo; - } - pkg_hdr = (struct ice_pkg_hdr *)buf; state = ice_verify_pkg(pkg_hdr, len); if (state) { @@ -2462,7 +2430,6 @@ int ice_cfg_tx_topo(struct ice_hw *hw, u8 *buf, u32 len) /* Get the new topology buffer */ new_topo = ((u8 *)section) + offset; -update_topo: /* acquire global lock to make sure that set topology issued * by one PF */ -- 2.43.0