From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v2 01/10] net/nfp: use strlcpy for copying string
Date: Sat, 12 Oct 2024 10:40:58 +0800 [thread overview]
Message-ID: <20241012024107.3795935-2-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20241012024107.3795935-1-chaoyong.he@corigine.com>
Replace 'snprintf()' with 'strlcpy()' where applicable.
Using 'strlcpy()' is safe practice when copying strings, as it
will include a null terminator.
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
drivers/net/nfp/nfp_net_common.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 5db7d50618..d1558b905c 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -576,7 +576,7 @@ nfp_flower_pf_repr_init(struct rte_eth_dev *eth_dev,
repr->repr_type = init_repr_data->repr_type;
repr->app_fw_flower = init_repr_data->app_fw_flower;
- snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
+ strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
eth_dev->dev_ops = &nfp_flower_pf_repr_dev_ops;
eth_dev->rx_pkt_burst = nfp_net_recv_pkts;
@@ -652,7 +652,7 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev,
repr->repr_type = init_repr_data->repr_type;
repr->app_fw_flower = init_repr_data->app_fw_flower;
- snprintf(repr->name, sizeof(repr->name), "%s", init_repr_data->name);
+ strlcpy(repr->name, init_repr_data->name, sizeof(repr->name));
eth_dev->dev_ops = &nfp_flower_repr_dev_ops;
eth_dev->rx_pkt_burst = nfp_flower_repr_rx_burst;
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 4a2c536704..c9a95ed632 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -2306,7 +2306,7 @@ nfp_net_get_mip_name(struct nfp_net_hw_priv *hw_priv,
if (mip == NULL)
return;
- snprintf(mip_name, FW_VER_LEN, "%s", nfp_mip_name(mip));
+ strlcpy(mip_name, nfp_mip_name(mip), FW_VER_LEN);
nfp_mip_close(mip);
}
@@ -2317,13 +2317,13 @@ nfp_net_get_app_name(struct nfp_net_hw_priv *hw_priv,
{
switch (hw_priv->pf_dev->app_fw_id) {
case NFP_APP_FW_CORE_NIC:
- snprintf(app_name, FW_VER_LEN, "%s", "nic");
+ strlcpy(app_name, "nic", FW_VER_LEN);
break;
case NFP_APP_FW_FLOWER_NIC:
- snprintf(app_name, FW_VER_LEN, "%s", "flower");
+ strlcpy(app_name, "flower", FW_VER_LEN);
break;
default:
- snprintf(app_name, FW_VER_LEN, "%s", "unknown");
+ strlcpy(app_name, "unknown", FW_VER_LEN);
break;
}
}
--
2.39.1
next prev parent reply other threads:[~2024-10-12 2:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:17 [PATCH 00/10] modify some logic of NFP PMD Chaoyong He
2024-10-10 9:17 ` [PATCH 01/10] net/nfp: use strlcpy for copying string Chaoyong He
2024-10-10 15:08 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 02/10] net/nfp: fix malloc name problem in secondary process Chaoyong He
2024-10-10 15:07 ` Stephen Hemminger
2024-10-11 2:31 ` Chaoyong He
2024-10-10 9:17 ` [PATCH 03/10] net/nfp: simplify some function parameters Chaoyong He
2024-10-10 15:08 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 04/10] net/nfp: improve the logic readability Chaoyong He
2024-10-10 15:10 ` Stephen Hemminger
2024-10-11 2:36 ` Chaoyong He
2024-10-10 9:17 ` [PATCH 05/10] net/nfp: fix problem caused by configure function Chaoyong He
2024-10-10 15:13 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 06/10] net/nfp: add check logic for port up/down function Chaoyong He
2024-10-10 15:14 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 07/10] net/nfp: fix problem caused by commit end function Chaoyong He
2024-10-10 15:15 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 08/10] net/nfp: fix problem caused by FEC set Chaoyong He
2024-10-10 15:15 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 09/10] net/nfp: modify the comment of some control messages Chaoyong He
2024-10-10 15:15 ` Stephen Hemminger
2024-10-10 9:17 ` [PATCH 10/10] net/nfp: fix memory leak in VF initialization logic Chaoyong He
2024-10-10 15:19 ` Stephen Hemminger
2024-10-11 2:38 ` Chaoyong He
2024-10-12 2:40 ` [PATCH v2 00/10] modify some logic of NFP PMD Chaoyong He
2024-10-12 2:40 ` Chaoyong He [this message]
2024-10-12 2:40 ` [PATCH v2 02/10] net/nfp: fix malloc name problem in secondary process Chaoyong He
2024-10-12 2:45 ` Stephen Hemminger
2024-10-12 2:47 ` Chaoyong He
2024-10-12 2:41 ` [PATCH v2 03/10] net/nfp: simplify some function parameters Chaoyong He
2024-10-12 2:41 ` [PATCH v2 04/10] net/nfp: improve the logic readability Chaoyong He
2024-10-12 2:41 ` [PATCH v2 05/10] net/nfp: fix problem caused by configure function Chaoyong He
2024-10-12 2:41 ` [PATCH v2 06/10] net/nfp: add check logic for port up/down function Chaoyong He
2024-10-12 2:41 ` [PATCH v2 07/10] net/nfp: fix problem caused by commit end function Chaoyong He
2024-10-12 2:41 ` [PATCH v2 08/10] net/nfp: fix problem caused by FEC set Chaoyong He
2024-10-12 2:41 ` [PATCH v2 09/10] net/nfp: modify the comment of some control messages Chaoyong He
2024-10-12 2:41 ` [PATCH v2 10/10] net/nfp: fix memory leak in VF initialization logic Chaoyong He
2024-10-13 2:49 ` [PATCH v2 00/10] modify some logic of NFP PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012024107.3795935-2-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).