From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9C7345B17; Sat, 12 Oct 2024 04:42:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 471E640691; Sat, 12 Oct 2024 04:41:57 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2109.outbound.protection.outlook.com [40.107.100.109]) by mails.dpdk.org (Postfix) with ESMTP id 24DA540676; Sat, 12 Oct 2024 04:41:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lLEItyn5IVkTkYpRwld6TZPkrq+dAIiLoDGfGMa1er2zU+pY1kf952UJQQpiqYaDmD/dVOOIFTPTHW/OORT+PZzgzOOFJoT5lT1XS/erbdkq2h1UsqajhgS5Ji5zgUUjfQV0ZSSl6B94kOHZwoZrNmZfJ5K0jiNCZZQkyOEQ2x7LNhMeEYgQLOePIBrVZj5ee+gYU6n8leki8JsCJsSbnK2k0M2ApgyECbVo1aWbjDBRfWVk0ZevT7uMSmV7lrK4Zj9E/Rsb4NdzdlJo5F8Rt2CGG/W/0ag8CFiJRIzcq4V7gG8XFy02r28vUvTii76eX+1xJ6y+DA/pVBsVCfllKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zO7o3w98vV2KUYosFHKvOjfiRIsHXgkIroR8lUkziXc=; b=RrdQqm45jzHGOrD75WYLTX//Blxt2CcC0oQs/4suwoMNHNTvfKagYcuUq7lS4+vn1FjngSaqGEUpsGoRtSjhNhK5mPSQcgaq3peoZ/6cEoscpUar1qo7iFyLKWDPEBOe22WRbIkJRTahDcxc6zZqYU5gsjwPpytDmKZ2ywTAOVLe+yBY12TWAHkgiuBvzkvKNTrm5dD+wT9wm1z8C40PnqLoriWyXXZbmpum3zWVRrPObUE3DxtpS4l6+gyoU6O8lcxnU5yxLsuoqKJclVWmUp0bXnD4EGBtIYp11XFVGnOFcLF2B7oS6e9ltG0Bzkjg8s/KO0NELRkPvh+rkfctTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zO7o3w98vV2KUYosFHKvOjfiRIsHXgkIroR8lUkziXc=; b=DHd33Qw0YSe0VMHkBTTVHKtaNyaa7fwqnGzKo+Tju88WVRgyZWX2Up1bWXI+nXoqxGi53OsFfy+TmciOtRlpgerlQTnpgiqiL4eXjPImM/49BEvTdvjP3NUrLR7n0uewZpYt0CuefGmZON6bXhw4CiLVUnh1dnIeUrVxT/XFAIU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO1PR13MB4902.namprd13.prod.outlook.com (2603:10b6:303:f0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.21; Sat, 12 Oct 2024 02:41:51 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8048.017; Sat, 12 Oct 2024 02:41:51 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , zerun.fu@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang , Stephen Hemminger Subject: [PATCH v2 07/10] net/nfp: fix problem caused by commit end function Date: Sat, 12 Oct 2024 10:41:04 +0800 Message-Id: <20241012024107.3795935-8-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20241012024107.3795935-1-chaoyong.he@corigine.com> References: <20241010091716.3631747-1-chaoyong.he@corigine.com> <20241012024107.3795935-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR06CA0001.apcprd06.prod.outlook.com (2603:1096:4:186::21) To PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO1PR13MB4902:EE_ X-MS-Office365-Filtering-Correlation-Id: cabce025-3230-49f6-f4d8-08dcea676d2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|52116014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UMBwKNXdSsxhwAk3sPH3ZenZWPW5HW2XvCAIrC2N4X7mjwdKeoiJxGXM2PzM?= =?us-ascii?Q?6Ho3wu2jLS1WdjR8s0C1qL33H3Cas+IG6iEIZPeLGFcy+rrOcLMjgIHIw33Y?= =?us-ascii?Q?WAxmHZaLepfyg7f3jUaGKWydcqqrQig8FLjstsY9l2kz9vbhV6mZ5OzkNUNS?= =?us-ascii?Q?x3BpRuHRz9mK4+W/HLxAlM9XLxfCv+gmLCXezg47C7qO+8mSYjOwK15yf/tg?= =?us-ascii?Q?VT8xgYJ00AZXMV+zoKhiOZ53OB9DH91OVI0cW4CjRJFSmDUqgeq2MA6VjWhx?= =?us-ascii?Q?7KXFEge05gfAW+34oJsgzPGjx9BGUkC3nIh3E9p+bh98FSDd3Nh2OfaXj7u0?= =?us-ascii?Q?uokPNNR1kdVZBMz1yOLuaVO9GVUmy5W+zqNIVxh6RtXUILhY6h6DNAz4yAum?= =?us-ascii?Q?LoI8OkGaazpryKi58MO5wWjJ0Q/v8PVXzfRXDBxIFFkl6eIrXaCP+4oXFJ8K?= =?us-ascii?Q?DraCw9KsT97M5hx/7sGwlR2MZyVn813BZ1/2In93bAKA6hFvAf4BGp0tDwCI?= =?us-ascii?Q?S0UycCI2Y4Yu+W0z+6e/aLKWUAXzGbCcv78ph0/7gD8k+Ks3ThqszGKM7J4p?= =?us-ascii?Q?W6GfeCYkgd7jsjacJBh/knNGZJXXdb6+K/58fWLUia/syZa5Caeqp3O8GSYF?= =?us-ascii?Q?C1uOhdBMioRR0lAatn7zw51TidLIf/feP9niF8lp5WXVGC9vPg0NEuJMw9Em?= =?us-ascii?Q?RPdj+gvsDh/ze0Fd7mKm2Sfpp1xLkAt3TcpklC7U+DjaKseHJDnQwtbFXKSg?= =?us-ascii?Q?BVxuoBji0cA6LXtGPi9iw+zM4x/IzGQid8+gazkrfzGZ4uPc5AvgnoO1zL5T?= =?us-ascii?Q?izjivzdow/CJA1a77VUoiutMMg0ZKMTwIbDBbIEWASycEQU90L6rcZgGx8o2?= =?us-ascii?Q?W/o3yBJBjbkKbexQu7WhcCpZ40XM/UvofhSI+rFpF5DXIFWWy8PUoZxmrXdc?= =?us-ascii?Q?BYuHHOpJ6NsQhKlcXwQqekFyVxtSTsCW4eRR4QqhGLRbhux3hpBoNIZUqQvH?= =?us-ascii?Q?JDaz6kd6UZd5vbLwa/8SNZfmS+Jp/qdA2W6N3wALBQnjk3dOD7MKtZrmq1sI?= =?us-ascii?Q?tKlOziiA7Lb6h9wuzuntagSMv1lblc0+QHjagUL4czQoobJqcp2UtmUV0zS4?= =?us-ascii?Q?l3OxYXnuQP6Xgm/Vyz2EikAbi19WPqh8ddBvkU0F4WmccetXF9ZyDxlbN08B?= =?us-ascii?Q?TXetlxqSAgojIRhazoa00hypCm09wKNIjhUmoz2r/UfWQFVNslPFOipdpTs6?= =?us-ascii?Q?J/LR3JEYq7FADXJVIUZYkiBFXvTlOv6kf3thPeMuEekMBTDQjayECvUhCiSy?= =?us-ascii?Q?DyVWNM2G0AeEPfPXJARkQmWvS9QGcQS9amktUPto9Kqd6Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(52116014)(1800799024)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HGZfNrbyYk7c4avVxoVPZik2/P4ozC/y+6Ww8HJjvJyzvcMS8AnEQ9YzZwwV?= =?us-ascii?Q?slEpqwG12ThiL7upTekgcf7/9wKK+4XIyQo99FPCby4kfcBCgWbgOQcB5/bd?= =?us-ascii?Q?LXra6Uru+M3B9Dwl3WSCWodMsnkJBAb1D9lKVwx8lVxFWWOBPh47JRl5ShPD?= =?us-ascii?Q?yiDXrgRl+eW5WApHnZRfC8buiSm1/cj1NrlvZX4qYN8IptumY/vIXBm4llp6?= =?us-ascii?Q?Ca7Nz+yTZkxSg+IfqfITz8rOYWxhNSzXJWNEn8/S4fKKt62vlYOU6IY3mRnj?= =?us-ascii?Q?Z6oqnX/PBYp+gevsOffq+JeG6NcsNMGN61zFoH0DMkFUirCYb8GoVGjRgN0U?= =?us-ascii?Q?RTGyDtNYFxS+s8mMcqH0Hd5Ud73fKt5vO+E2QECU3DDwFF/zvMkYOZfUpfg+?= =?us-ascii?Q?Cikmh16QksmfFy/g17sxdFcrwphxamTPuxeeznzi74OhGQFLhWcjIYaOAaRJ?= =?us-ascii?Q?YISclm6ERurm09iKkL6NXNbVcwa9RI+kJOMCRUPwdYb+08Jee3a5nBGEQ2IJ?= =?us-ascii?Q?dR2ajs9Smpw0kPK9s9nvd2s2xmHIRsh9WEOiG9C9UOzzl+e6LchvKKJVlu/R?= =?us-ascii?Q?cwZTn/cm3GJf9I2VvxWDTPEYkL01u7M2mPpWJpiJAhAXWPOjr8e1+yxIUqbX?= =?us-ascii?Q?gMt5EAoyEJOjL0iEV4c86ez8T7/JhVqJ0IDMrpaKzQxYeKteJ4fMEkKyvi0x?= =?us-ascii?Q?Z48HbQsQWlhuJz7bP/Jdmelst9RuQKddLubGpOtBsyIh5FpyqX8vlpNm9Fjk?= =?us-ascii?Q?yFnzzGL1y+iPPNmEtTWpVK6Ta5+UH8WfVLuIOGldy5yRMNLzqIFaN75MuRWV?= =?us-ascii?Q?QnwW+RYvraRhwjrBQ7ialOwFA3zG4KZwXW9rDgksUjpxOCKni6TWs9am09C4?= =?us-ascii?Q?VGo/2B3aRER5v7SeHmmj24cdV2knpQT1NbO3Acxhey73X+f1nYwJEAxSEcRG?= =?us-ascii?Q?t+t4nx9Pf4h7BE5fczw3MJz1T4rPrUYzLu8P/MWrJ9yA4ICrAGgP0EETYkq0?= =?us-ascii?Q?lnkPtdVDMfgt84DmGC+f6Byggz6tby7ir08YVRItlthIsuE0w8NY8G+cCLGQ?= =?us-ascii?Q?pjaiMfzWzLYuimFG2yGstvDIqB/uzXrivffTr/jS5xDTNQ5deOfqFnndMOZJ?= =?us-ascii?Q?0yqyHwlZEND9wq/GWXSFmwYLM5nw2gyIlPQlrcSQGZaQ+QuFlpcfQS1g6il3?= =?us-ascii?Q?Rgl8hoaKG/rQMaX37Mig/wKv32Qx/KUuyTINxgCXC3AR2u9VO+/2rVQwmho0?= =?us-ascii?Q?wZKkQunEPxSbigvzoxSgiarayml+i08HygiTqkysR+wsLYH/DApppXsC2m5x?= =?us-ascii?Q?RusQzZ9Ma2DFutYnByZkAW7654o7+1CisVEw2VY5tMTehJYkqv/0b9BvagZb?= =?us-ascii?Q?g7vj7OGldqKGuqyIJEYUMLSfETZMVdJ4qo1rbPY3rkXdpHmOdor6IB4DU0ZE?= =?us-ascii?Q?Y1BCa98pm1u/gU/rh+32eL4y6CauTDQzefNPJBN1cOOUCcQ557mtqMJ5inJn?= =?us-ascii?Q?uAO7qLR9GKHunuwT0pishhY8ojAO5z/C0v59DRIYwD+xcXVzcigenAYxnYI8?= =?us-ascii?Q?ueC7mnKc49xifMuJHgyBjil5HmDcZI20sO+QgbNbw/8D4jLdNecgMbgP6LSI?= =?us-ascii?Q?Aw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: cabce025-3230-49f6-f4d8-08dcea676d2a X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2024 02:41:51.8514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GIPeGdpSKOj0XuWCZH3boTbfy6aeWTTERwbVweGXVOVyTdwBBwd09GE+o6wV57mMBYfjGw+816RpDwsF9Nv26YTIH7kSX8Vcp0lx3BKjTwc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4902 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The return value of 'nfp_eth_config_commit_end()' is three ways, the original logic considered it as two ways wrongly. Fixes: 68aa35373a94 ("net/nfp: support setting pause frame switch mode") Cc: zerun.fu@corigine.com Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang Acked-by: Stephen Hemminger --- drivers/net/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c index 80d60515d8..5c3a9a7ae7 100644 --- a/drivers/net/nfp/nfp_net_common.c +++ b/drivers/net/nfp/nfp_net_common.c @@ -2520,7 +2520,7 @@ nfp_net_pause_frame_set(struct nfp_net_hw_priv *hw_priv, } err = nfp_eth_config_commit_end(nsp); - if (err != 0) { + if (err < 0) { PMD_DRV_LOG(ERR, "Failed to configure pause frame."); return err; } -- 2.39.1