From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF66B45B1F; Sun, 13 Oct 2024 03:15:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78C48402C4; Sun, 13 Oct 2024 03:15:52 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 2FB3040273 for ; Sun, 13 Oct 2024 03:15:51 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71e5b2814f6so200633b3a.2 for ; Sat, 12 Oct 2024 18:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728782150; x=1729386950; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=u6LvImnH8BtjR5KR9hf9gvtxT7c80EwOcNr2XwUs7lk=; b=gacM7mL1XmF+Me6px3n5H3evb9VI+jk5NEVXmodRxs1ZQzP1Y5sPGWHffnvjdJaHQV YowttbW5dQvdhlhohrlD4iyTmFFagG0X4fVoU2AU2CrbXQZsPP5x3B0anAgRlagQlMfH 2tqjISl3BScMq2n/jIPuCUL9Nk1YnY4njnSwP3c15aXRT5WTQGXp4idt/p7mej2Sys0q HDR0ghMkx0zqpMnuIdBkHer5TEYroOf71XKAo/gJKvZyZxogz8ni1u2Oscdn2PuvuqLF gLN6qQCvo7Em8Gy4SBB0F9lbTovSmt3drwVzGoDCjyA53ycrJyqQ58lYP2g+nrpF8Va+ c1Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728782150; x=1729386950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u6LvImnH8BtjR5KR9hf9gvtxT7c80EwOcNr2XwUs7lk=; b=gOwiqphaRfIiI1yQMj6DDYl5OfDHfIBCbTQCuqbATRz1GOUeULaCfMjNKt5dpCxhGD 71/rbqK8JzYTbYqFInhfrx7PMrvJ+ts//k6NZKeMWnWnoHIDpU6VeSJEIPuyn9bD2Rbf ozSEH2LuLDv/sUT1+qA7VngYyFFJoHze6wDkRlYmd1PnHFnFcY9b7URD9oYlSnWy1wxM S5CFqQ4pjf+26SmTWbFz9GwWETaisgRg0uIzRxIIogZQFiiHgtw3DoqdxGMHTPL8O6De dZNOhjEIOho+51ypORVx7z7OFvQPdlEhybhZ976nRRSdzbwMJlUe0dnbHFUruw3SLJo4 paHw== X-Forwarded-Encrypted: i=1; AJvYcCXrw2JG65OWvpnEPvnI6OMTto9WM10FuT2pjeAo3xFTm8P9a12Ra3dNPK27Gbo1sKbxfl0=@dpdk.org X-Gm-Message-State: AOJu0YwgkyqHD7q3yo3jsmdAu4jnyVjp/P+5oEaemsEjgmKgOUAwlvs6 9cxy3HkPtlvDwx7zcHDUFXBGy3owrACskWypfVxonb0apiB4kZa3+2W4VnqjlqQ= X-Google-Smtp-Source: AGHT+IGClfz6oMS0D9dXS9ZD5qegR65fhe4fDniIzSpQL6KhplHL18wWcIHvmAqfXiSMS1vK63Z2RA== X-Received: by 2002:a05:6a00:4612:b0:71d:feda:9939 with SMTP id d2e1a72fcca58-71e37e4bfe1mr13190017b3a.4.1728782150263; Sat, 12 Oct 2024 18:15:50 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2aa939fdsm4813414b3a.109.2024.10.12.18.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 18:15:50 -0700 (PDT) Date: Sat, 12 Oct 2024 18:15:48 -0700 From: Stephen Hemminger To: Cc: , Subject: Re: [PATCH] net/af_packet: add explicit flush for Tx Message-ID: <20241012181548.227f66a2@hermes.local> In-Reply-To: <20240815115653.603552-1-vignesh.purushotham.srinivas@ericsson.com> References: <20240815115653.603552-1-vignesh.purushotham.srinivas@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 15 Aug 2024 13:56:53 +0200 wrote: > From: Vignesh PS > > af_packet PMD uses system calls to transmit packets. Separate the > transmit function into two different calls so its possible to avoid > syscalls during transmit. > > Signed-off-by: Vignesh PS The way to avoid syscalls is for the application to call tx_burst with more than one packet. This patch makes the AF_PACKET PMD behave different than other PMD's; that is a bad idea. If this optimization is really necessary it should be setup and tuned via existing eth_tx_conf like tx_threshold. The wording of the description is awkward and not written in user focused imperative language; also has spelling errors.