DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kamil Vojanec <vojanec@cesnet.cz>
Cc: dev@dpdk.org, Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [RFC] table: report victim replace stats in LRU tables
Date: Sat, 12 Oct 2024 18:19:19 -0700	[thread overview]
Message-ID: <20241012181919.6a1f6209@hermes.local> (raw)
In-Reply-To: <20240819052330.46122-1-vojanec@cesnet.cz>

On Mon, 19 Aug 2024 07:23:30 +0200
Kamil Vojanec <vojanec@cesnet.cz> wrote:

> LRU caches replace records when requested table bucket is full. There
> is, however, no information about this happening in either the return
> value or the statistics. This commit introduces a counter for such
> cases.
> 
> Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
> ---
>  lib/table/rte_table.h            | 1 +
>  lib/table/rte_table_hash_key16.c | 4 ++++
>  lib/table/rte_table_hash_key32.c | 4 ++++
>  lib/table/rte_table_hash_key8.c  | 4 ++++
>  lib/table/rte_table_hash_lru.c   | 4 ++++
>  5 files changed, 17 insertions(+)
> 
> diff --git a/lib/table/rte_table.h b/lib/table/rte_table.h
> index 9a5faf0e32..e097e25868 100644
> --- a/lib/table/rte_table.h
> +++ b/lib/table/rte_table.h
> @@ -33,6 +33,7 @@ struct rte_mbuf;
>  struct rte_table_stats {
>  	uint64_t n_pkts_in;
>  	uint64_t n_pkts_lookup_miss;
> +	uint64_t n_pkts_insert_victims;
>  };
>  

This ABI change so it needs a release note, and has to targeted
at a LTS release, too late for 24.11; so would end up getting deferred
until 25.11..

When you send followup please reply-to the initial RFC message id
with "PATCH v3"

      parent reply	other threads:[~2024-10-13  1:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 11:58 Kamil Vojanec
2024-08-19  5:23 ` Kamil Vojanec
2024-10-12  2:57   ` Stephen Hemminger
2024-10-13  1:19   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241012181919.6a1f6209@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=vojanec@cesnet.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).