From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A661445B1F; Sun, 13 Oct 2024 03:19:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E03E402C4; Sun, 13 Oct 2024 03:19:24 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 730D740273 for ; Sun, 13 Oct 2024 03:19:22 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71e5a62031aso179930b3a.1 for ; Sat, 12 Oct 2024 18:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728782361; x=1729387161; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GAhqNY8+VhHXZLh54JH/yKnP7RZc/+G85TWRlPCGO44=; b=V0XsZ49Oh8F2J7TSBjerIHeD8wNaroheuKfUmAguo2wY+jAZwtBxDm/OWBxkyc04bX matJF4AJhmaE2tQyikO6MleRehKwoNeO0o8a1CoI28ztWlCvmIDqttr2FgVs/riP4T3g fz+/wNAQbHn8PKJVfQByPyl4DFfiTy7Qwr2rjej4XL8CQFkuMZSsz+rNhrsJ57w2A3cO 8zXQ+1Rrqr1gFKWyy4PhQOQV/ghS2vl00LrE1t1RHQf3OsBMJOH8BLNdRUakLKZapH/V 4JziuxM/MQD0SkjSzxuymlggndaj8yVb9xZnFvPA2oYUliGnMxpnaDqHeOK8+ufvDJaV aWOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728782361; x=1729387161; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GAhqNY8+VhHXZLh54JH/yKnP7RZc/+G85TWRlPCGO44=; b=Cx73+mvbr3S+MQFSzPKrPpDkJ/J+tPUCJUz3gofmrhUeiRHfOsfKjJv74kkeOdEaNy Hy6Mzm14G5qc0NblUPDf9Q8n1I5rC0UIneJtwjivN/+15hnRoF/PY7elxDZafnAv0/xr W7GaXRIRStsZamEMo3xXWMMk4a4lMzCn2Lwxy06NjqWGvpT35qSGsPWG+ELrLXbiKIEi ConP7vn2HyAzFQ43G96GQHNHJCpWxmSnqJBdzUD0Ddqt6o++fdR2qhKnI9s3fQFkbhty mXIHEWj3S/di6wN7OCvUWzI4h0hsBCYe3/RiZz8aIQp6XwPgfIgSZx1GAUxqI1mrYX/G fTpQ== X-Gm-Message-State: AOJu0Yz2MaeARGJt8t2tTHJc7aB/MU9n3XJsBLCmvuWcLcrEFS8gs3to jMiIX5UXyk9HDLe+q6hPGEzoZJl/M9WPWrMRXrIIcIGcCAcKhCFnQCR1iB1XiWs= X-Google-Smtp-Source: AGHT+IHP/hRWj7YA/n3FOoXxpwWpb5IBVrB4FmjI/6no7KTvsrPrkstZCttycreOi01KXa/fsJ2mKw== X-Received: by 2002:aa7:88d1:0:b0:71e:21:d2d8 with SMTP id d2e1a72fcca58-71e4c15128amr7103369b3a.7.1728782361626; Sat, 12 Oct 2024 18:19:21 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ea4495d331sm4413255a12.60.2024.10.12.18.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 18:19:21 -0700 (PDT) Date: Sat, 12 Oct 2024 18:19:19 -0700 From: Stephen Hemminger To: Kamil Vojanec Cc: dev@dpdk.org, Cristian Dumitrescu Subject: Re: [RFC] table: report victim replace stats in LRU tables Message-ID: <20241012181919.6a1f6209@hermes.local> In-Reply-To: <20240819052330.46122-1-vojanec@cesnet.cz> References: <20240816115848.432547-1-vojanec@cesnet.cz> <20240819052330.46122-1-vojanec@cesnet.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 19 Aug 2024 07:23:30 +0200 Kamil Vojanec wrote: > LRU caches replace records when requested table bucket is full. There > is, however, no information about this happening in either the return > value or the statistics. This commit introduces a counter for such > cases. > > Signed-off-by: Kamil Vojanec > --- > lib/table/rte_table.h | 1 + > lib/table/rte_table_hash_key16.c | 4 ++++ > lib/table/rte_table_hash_key32.c | 4 ++++ > lib/table/rte_table_hash_key8.c | 4 ++++ > lib/table/rte_table_hash_lru.c | 4 ++++ > 5 files changed, 17 insertions(+) > > diff --git a/lib/table/rte_table.h b/lib/table/rte_table.h > index 9a5faf0e32..e097e25868 100644 > --- a/lib/table/rte_table.h > +++ b/lib/table/rte_table.h > @@ -33,6 +33,7 @@ struct rte_mbuf; > struct rte_table_stats { > uint64_t n_pkts_in; > uint64_t n_pkts_lookup_miss; > + uint64_t n_pkts_insert_victims; > }; > This ABI change so it needs a release note, and has to targeted at a LTS release, too late for 24.11; so would end up getting deferred until 25.11.. When you send followup please reply-to the initial RFC message id with "PATCH v3"