From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v2 07/10] net/ice/base: remove flag checks before topology upload
Date: Mon, 14 Oct 2024 12:02:11 +0100 [thread overview]
Message-ID: <20241014110250.2314727-8-bruce.richardson@intel.com> (raw)
In-Reply-To: <20241014110250.2314727-1-bruce.richardson@intel.com>
DPDK should support more than just 9-level or 5-level topologies, so
remove the checks for those particular settings.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/ice/base/ice_ddp.c | 33 ---------------------------------
1 file changed, 33 deletions(-)
diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c
index 90aaa6b331..c17a58eab8 100644
--- a/drivers/net/ice/base/ice_ddp.c
+++ b/drivers/net/ice/base/ice_ddp.c
@@ -2384,38 +2384,6 @@ int ice_cfg_tx_topo(struct ice_hw *hw, u8 *buf, u32 len)
return status;
}
- /* Is default topology already applied ? */
- if (!(flags & ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW) &&
- hw->num_tx_sched_layers == 9) {
- ice_debug(hw, ICE_DBG_INIT, "Loaded default topology\n");
- /* Already default topology is loaded */
- return ICE_ERR_ALREADY_EXISTS;
- }
-
- /* Is new topology already applied ? */
- if ((flags & ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW) &&
- hw->num_tx_sched_layers == 5) {
- ice_debug(hw, ICE_DBG_INIT, "Loaded new topology\n");
- /* Already new topology is loaded */
- return ICE_ERR_ALREADY_EXISTS;
- }
-
- /* Is set topology issued already ? */
- if (flags & ICE_AQC_TX_TOPO_FLAGS_ISSUED) {
- ice_debug(hw, ICE_DBG_INIT, "Update tx topology was done by another PF\n");
- /* add a small delay before exiting */
- for (i = 0; i < 20; i++)
- ice_msec_delay(100, true);
- return ICE_ERR_ALREADY_EXISTS;
- }
-
- /* Change the topology from new to default (5 to 9) */
- if (!(flags & ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW) &&
- hw->num_tx_sched_layers == 5) {
- ice_debug(hw, ICE_DBG_INIT, "Change topology from 5 to 9 layers\n");
- goto update_topo;
- }
-
pkg_hdr = (struct ice_pkg_hdr *)buf;
state = ice_verify_pkg(pkg_hdr, len);
if (state) {
@@ -2462,7 +2430,6 @@ int ice_cfg_tx_topo(struct ice_hw *hw, u8 *buf, u32 len)
/* Get the new topology buffer */
new_topo = ((u8 *)section) + offset;
-update_topo:
/* acquire global lock to make sure that set topology issued
* by one PF
*/
--
2.43.0
next prev parent reply other threads:[~2024-10-14 11:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 16:44 [PATCH 0/9] net/ice: base code update for RC2 Bruce Richardson
2024-10-11 16:44 ` [PATCH 1/9] net/ice/base: re-enable bypass mode for E822 Bruce Richardson
2024-10-11 16:44 ` [PATCH 2/9] net/ice/base: add bounds check Bruce Richardson
2024-10-11 16:44 ` [PATCH 3/9] net/ice/base: fix VLAN replay after reset Bruce Richardson
2024-10-11 16:44 ` [PATCH 4/9] net/ice/base: remove 255 limit on sched child nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 5/9] net/ice/base: set VSI index on newly created nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 6/9] net/ice/base: optimize subtree searches Bruce Richardson
2024-10-11 16:44 ` [PATCH 7/9] net/ice/base: remove flag checks before topology upload Bruce Richardson
2024-10-11 16:44 ` [PATCH 8/9] net/ice/base: allow init without TC class sched nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 9/9] net/ice/base: read VSI layer info from VSI Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 00/10] net/ice: base code update for RC2 Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 01/10] net/ice/base: re-enable bypass mode for E822 Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 02/10] net/ice/base: add bounds check Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 03/10] net/ice/base: fix VLAN replay after reset Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 04/10] net/ice/base: remove 255 limit on sched child nodes Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 05/10] net/ice/base: set VSI index on newly created nodes Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 06/10] net/ice/base: optimize subtree searches Bruce Richardson
2024-10-14 11:02 ` Bruce Richardson [this message]
2024-10-14 11:02 ` [PATCH v2 08/10] net/ice/base: allow init without TC class sched nodes Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 09/10] net/ice/base: read VSI layer info from VSI Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 10/10] net/ice/base: update README Bruce Richardson
2024-10-14 17:27 ` [PATCH v2 00/10] net/ice: base code update for RC2 Medvedkin, Vladimir
2024-10-15 10:05 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014110250.2314727-8-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).