DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v2 08/10] net/ice/base: allow init without TC class sched nodes
Date: Mon, 14 Oct 2024 12:02:12 +0100	[thread overview]
Message-ID: <20241014110250.2314727-9-bruce.richardson@intel.com> (raw)
In-Reply-To: <20241014110250.2314727-1-bruce.richardson@intel.com>

If DCB support is disabled via DDP image, there will not be any traffic
class (TC) nodes in the scheduler tree immediately above the root level.
To allow the driver to work with this scenario, we allow use of the root
node as a dummy TC0 node in case where there are no TC nodes in the
tree. For use of any other TC other than 0 (used by default in the
driver), existing behaviour of returning NULL pointer is maintained.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/ice/base/ice_sched.c | 8 +++++++-
 drivers/net/ice/base/ice_type.h  | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c
index 4c5c19daf3..7e255c0337 100644
--- a/drivers/net/ice/base/ice_sched.c
+++ b/drivers/net/ice/base/ice_sched.c
@@ -293,6 +293,10 @@ struct ice_sched_node *ice_sched_get_tc_node(struct ice_port_info *pi, u8 tc)
 
 	if (!pi || !pi->root)
 		return NULL;
+	/* if no TC nodes, use root as TC node 0 */
+	if (!pi->has_tc)
+		return tc == 0 ? pi->root : NULL;
+
 	for (i = 0; i < pi->root->num_children; i++)
 		if (pi->root->children[i]->tc_num == tc)
 			return pi->root->children[i];
@@ -1306,7 +1310,9 @@ int ice_sched_init_port(struct ice_port_info *pi)
 			if (buf[0].generic[j].data.elem_type ==
 			    ICE_AQC_ELEM_TYPE_ENTRY_POINT)
 				hw->sw_entry_point_layer = j;
-
+			else if (buf[0].generic[j].data.elem_type ==
+			    ICE_AQC_ELEM_TYPE_TC)
+				pi->has_tc = 1;
 			status = ice_sched_add_node(pi, j, &buf[i].generic[j], NULL);
 			if (status)
 				goto err_init_port;
diff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h
index 6177bf4e2a..35f832eb9f 100644
--- a/drivers/net/ice/base/ice_type.h
+++ b/drivers/net/ice/base/ice_type.h
@@ -1260,6 +1260,7 @@ struct ice_port_info {
 	struct ice_qos_cfg qos_cfg;
 	u8 is_vf:1;
 	u8 is_custom_tx_enabled:1;
+	u8 has_tc:1;
 };
 
 struct ice_switch_info {
-- 
2.43.0


  parent reply	other threads:[~2024-10-14 11:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 16:44 [PATCH 0/9] net/ice: base code update for RC2 Bruce Richardson
2024-10-11 16:44 ` [PATCH 1/9] net/ice/base: re-enable bypass mode for E822 Bruce Richardson
2024-10-11 16:44 ` [PATCH 2/9] net/ice/base: add bounds check Bruce Richardson
2024-10-11 16:44 ` [PATCH 3/9] net/ice/base: fix VLAN replay after reset Bruce Richardson
2024-10-11 16:44 ` [PATCH 4/9] net/ice/base: remove 255 limit on sched child nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 5/9] net/ice/base: set VSI index on newly created nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 6/9] net/ice/base: optimize subtree searches Bruce Richardson
2024-10-11 16:44 ` [PATCH 7/9] net/ice/base: remove flag checks before topology upload Bruce Richardson
2024-10-11 16:44 ` [PATCH 8/9] net/ice/base: allow init without TC class sched nodes Bruce Richardson
2024-10-11 16:44 ` [PATCH 9/9] net/ice/base: read VSI layer info from VSI Bruce Richardson
2024-10-14 11:02 ` [PATCH v2 00/10] net/ice: base code update for RC2 Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 01/10] net/ice/base: re-enable bypass mode for E822 Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 02/10] net/ice/base: add bounds check Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 03/10] net/ice/base: fix VLAN replay after reset Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 04/10] net/ice/base: remove 255 limit on sched child nodes Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 05/10] net/ice/base: set VSI index on newly created nodes Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 06/10] net/ice/base: optimize subtree searches Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 07/10] net/ice/base: remove flag checks before topology upload Bruce Richardson
2024-10-14 11:02   ` Bruce Richardson [this message]
2024-10-14 11:02   ` [PATCH v2 09/10] net/ice/base: read VSI layer info from VSI Bruce Richardson
2024-10-14 11:02   ` [PATCH v2 10/10] net/ice/base: update README Bruce Richardson
2024-10-14 17:27   ` [PATCH v2 00/10] net/ice: base code update for RC2 Medvedkin, Vladimir
2024-10-15 10:05     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241014110250.2314727-9-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).