From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CE0145B3B; Mon, 14 Oct 2024 21:54:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49787402A9; Mon, 14 Oct 2024 21:54:21 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 6D4354026C for ; Mon, 14 Oct 2024 21:54:20 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20cd76c513cso13177225ad.3 for ; Mon, 14 Oct 2024 12:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728935659; x=1729540459; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0EXGV1JHPLIRATSU1d3lcOelmmdcpkYBZ3NnnbFFPzg=; b=xzSQoLBg/jZqKSz0lCyJXT9U7v2QLQWetyIxq4qpV8TqoeUm1Cnr4tc5IW3hPcV0Co BYB/VI/iwd+VcZ3mh9fxaPUc4JCXmmCO4XLdwAGObPXGfySapZATZ2Uz+GaNPk+yhxnj VCLGMyXTFLs/UXBPEi+E6xjtOynkWr+2QkfYWARPSR7ZILlZ/rqvjNoNlIw0LA+jkyy5 19vmmZwuVaGLCtwMmQnDFvD4CSSIu8pVjl/BsUOYUSqzzWpjcZywc9DFoXYwzGRdIzyC KgpgDhiHpKNvbcHNhwKWHK76qtx3JTQ2AZFDTPDSHZLuE71uG9aBokC6w7LuqkyvN9T9 x70Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728935659; x=1729540459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0EXGV1JHPLIRATSU1d3lcOelmmdcpkYBZ3NnnbFFPzg=; b=rafIv13MY0JZaCAuGN2BFzShO9FjHMS0oSHHZ/i0amjBsYyQ2IcE/nlIN5PHxlQJ4g TSDrNhCZz5MSY7P/cM69J3rw5hg2s5waWP5exWA75ICBpts2gp+m/bLfSyLTwWjoz7Uf qrR5vlxAX9V2oknuVF424OQlPNlXmwAXlBYspU73cRsGf/D6GQzcC5ej07Fy1+MN6T5v xZ2+8wbkvNBGBRctP8VxTOksMxxVTFI3O0i33dn84JF1JmqYPX3s7PYHfV+DrcTZT5C4 BsamUTEAjR9MTfoaHF/Bu50C8Tk5wJJLciAh8yL+ZyhXYcCPurmzOMbhJG4YNHaXJWOz X6Ag== X-Forwarded-Encrypted: i=1; AJvYcCUCpMc4/H4dojku2sfFr9kY2YNUMZK8D+iGSm5EBbUX0ao5Uyo5XRbsW7skNyOH1jVjqgM=@dpdk.org X-Gm-Message-State: AOJu0YxMExf10wR0xwrAMG1gsFtYK9tzfN7i+8SFt2JK8HGr5eL7c7ao mykEqlgfVsk1Q2gDZ2+1dh+rGd7LqVsY5tQli5bw7gnP+AcESRzhs5jnzml6X/8= X-Google-Smtp-Source: AGHT+IGPvG3PnKh2KatYZg5FTi2/pO36WXvBw8uRyzjXjx6U7h284zCVcaJg11tF1wR0da5oILjgkw== X-Received: by 2002:a17:902:dac7:b0:20d:f00:bd26 with SMTP id d9443c01a7336-20d0f00bd43mr13051675ad.36.1728935659558; Mon, 14 Oct 2024 12:54:19 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c33c83esm69656595ad.244.2024.10.14.12.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 12:54:19 -0700 (PDT) Date: Mon, 14 Oct 2024 12:54:17 -0700 From: Stephen Hemminger To: Nitin Saxena Cc: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Robin Jarry , Christophe Fontaine , , Nitin Saxena Subject: Re: [PATCH v5 4/5] test/graph_feature_arc: add functional tests Message-ID: <20241014125417.5fba4064@hermes.local> In-Reply-To: <20241014143401.3135897-5-nsaxena@marvell.com> References: <20241010133111.2764712-1-nsaxena@marvell.com> <20241014143401.3135897-1-nsaxena@marvell.com> <20241014143401.3135897-5-nsaxena@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 14 Oct 2024 20:03:57 +0530 Nitin Saxena wrote: > Added functional unit test case for verifying feature arc control plane > and fast path APIs > > How to run: > $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test > > Signed-off-by: Nitin Saxena With current upstream kernel checkpatch additional warnings: WARNING:MACRO_ARG_UNUSED: Argument 'idx' is not used in function-like macro #217: FILE: app/test/test_graph_feature_arc.c:186: +#define R(idx, node, node_cookie) { \ + if (!strcmp(child, node)) { \ + user_data += node_cookie; \ + } \ + } WARNING:MACRO_ARG_UNUSED: Argument 'user_data' is not used in function-like macro #272: FILE: app/test/test_graph_feature_arc.c:241: +#define R(idx, _name, user_data) { \ + if (!strcmp(node->name, _name)) { \ + priv->node_index = idx; \ + } \ + } Personally, using macros to generate tests like this can get confusing.