From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D798F45B3C; Tue, 15 Oct 2024 05:13:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D34894027F; Tue, 15 Oct 2024 05:13:05 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id AABB140156 for ; Tue, 15 Oct 2024 05:13:04 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71e67d12d04so1200617b3a.1 for ; Mon, 14 Oct 2024 20:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728961984; x=1729566784; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=++WYryvPZefLhKetqsQDXh9esyY2KfMh7OG5p2MAABw=; b=tLtCBJLkwMNbuKWfvmAyen9DvDJPckVZZ4eCdOUWzYjXSk7PtQa8w36Qhew3TCsajK PFTL08L1BtVLQs/KeYc5HOIuceJNXF1ombgVTwvl1b99dl10Jx1xZV0R3GCbcBMBHGgh 0LCtuYC71H1Y+EoE0mL78iZ8B/3lviPIEcWWLA7UkU89vzkN86fZ77VFih+i96tqszy9 LVEtZEjPpNPlXQlPoVfE+/mfHhnESyW12Hdm2eRqziG3ZvkpTl8Zmemur7+w1o+fYyKB 9xM27A543QlN+h0zGNAqR1z2ZppfiOpIeTfTTGSD7mZrw3JW2Ko3eEuY9hbOWzYCKS34 QEJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728961984; x=1729566784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=++WYryvPZefLhKetqsQDXh9esyY2KfMh7OG5p2MAABw=; b=owzJz4xXIgaEGF+XPmcv5ENeeUtSCJDzUanQBKugP2NPs1OeRQs5Uy5mv8NgUtHgYG QL62DdxdCFzYK+dPDeotXrSeOJXaRwx1ER52uiloWcPPGebaStJHYdEczgi2bpAhm/pB arL3NGwlgxFNEkpme0E+VqKTVPUvoaJX43Q93snh8yNpGj+O4W6Sp70JedE/6XOQSFu0 0pEeUteMV1hWC+ecaRsU8jMGpWqLpfP1Ysg7MNbYy5bsYWClZfGpaZV+2sBmU/trqSFu yCTNAO4iVgziNcJ2d8hXh68SMnNFhxn2LBUA620dCXEUcKTm1gu/qkvmQQLtHvAZWCWp VsUw== X-Gm-Message-State: AOJu0Yxc+Tx9bu3y/ywVDq2otDh+ZVeGPbu/ytOflPn2ODt+rEq72c3X MPEbKDAk8Zs2Mz7K+AmmAQSORhfZG+9lPlb8IycbqvBdBxQCaZoRshehPzmM6oc= X-Google-Smtp-Source: AGHT+IF7T3frHlOi8kqysGZQLiEhdlJzS5umgEM270LRdUj6/hZDv0dbSjUFZVxOWX2EIGZtjk1hVQ== X-Received: by 2002:a05:6a21:3990:b0:1d8:a9c0:8861 with SMTP id adf61e73a8af0-1d8bcfa7cfdmr19921280637.36.1728961983726; Mon, 14 Oct 2024 20:13:03 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e774a4328sm281018b3a.121.2024.10.14.20.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 20:13:03 -0700 (PDT) Date: Mon, 14 Oct 2024 20:12:59 -0700 From: Stephen Hemminger To: Abdullah =?UTF-8?B?w5ZtZXIgWWFtYcOn?= Cc: dev@dpdk.org Subject: Re: [PATCH v6] devtools: add .clang-format file Message-ID: <20241014201259.0413981a@hermes.local> In-Reply-To: <20241014221545.66810-1-aomeryamac@gmail.com> References: <20241007102410.6c68f2c6@hermes.local> <20241014221545.66810-1-aomeryamac@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 14 Oct 2024 22:15:45 +0000 Abdullah =C3=96mer Yama=C3=A7 wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style across the DPDK codebase. >=20 > .clang-format file overrides the default style options provided by > clang-format and large set of IDEs and text editors support it. >=20 > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 Looks good, as an experiment I ran some files through clang-format and tried to make sure that clang-format and checkpatch do not disagree. One that showed up was that clang-format liked to leave open ended function= s. CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #407: FILE: drivers/net/tap/rte_eth_tap.c:593: + *l4_cksum =3D rte_ipv4_udptcp_cksum_mbuf(