From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D9CE45B40; Tue, 15 Oct 2024 09:25:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE4B2402A1; Tue, 15 Oct 2024 09:25:42 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A59B3400EF for ; Tue, 15 Oct 2024 09:25:41 +0200 (CEST) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F1OWPr011063 for ; Tue, 15 Oct 2024 00:25:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pfpt0220; bh=0i2lrZBKMc3XrbRMXtyTFwN c6tcvRxm4ZYoShaEX/hQ=; b=bgHTzcc7BohhjRzM+LXa3uY7tnks4/DQaOvmeL7 OmL90bPmC32X+GlJr788n4jP7S8EteCm8L0vUBmMDpTgaml6hPij5a+0jEDY4Ubr mllIdJAnlgB2mCzdEHYzwrpr9xNGcKpt6MU43j1IsfYgKyaSxeuKEjF4Twz6/J/n TIcsaRlJPfJ+/PKeBGWtOI2wTL832UmCt+wdmjDLiV+o6YYWAybiF1kGNIqDklvf 9N3FWF9Yn4psUtRt3/tgg6xK3Bg3aOtqfVtBg9hU5sII9WIf4hWJlbeHJGWWfI+5 xIyLZbyIhKRCBWl5qkydP52cJeU0uRZQRpzAHOujFrR6qng== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 429eq18j9n-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 Oct 2024 00:25:40 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 15 Oct 2024 00:25:38 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 15 Oct 2024 00:25:38 -0700 Received: from cavium-VAMSI-BM.. (unknown [10.28.36.156]) by maili.marvell.com (Postfix) with ESMTP id 8EB413F7045; Tue, 15 Oct 2024 00:25:37 -0700 (PDT) From: Vamsi Krishna To: CC: , Vamsi Attunuru Subject: [PATCH v1 1/1] net/octeon_ep: fix return code Date: Tue, 15 Oct 2024 12:55:29 +0530 Message-ID: <20241015072529.1564694-1-vattunuru@marvell.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: MJXPdbFhMUpUKy8lv2pgy5Sh9Kpg8wmy X-Proofpoint-GUID: MJXPdbFhMUpUKy8lv2pgy5Sh9Kpg8wmy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Vamsi Attunuru In the changeset 304ba46be396, a goto statement was mistakenly added after a return statement. This patch corrects the code by removing the erroneous return. Coverity issue: 445484 Fixes: 304ba46be396 ("net/octeon_ep: handle device removal on probe") Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/otx_ep_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c index 42cfe4250c..b4f8baf3b3 100644 --- a/drivers/net/octeon_ep/otx_ep_ethdev.c +++ b/drivers/net/octeon_ep/otx_ep_ethdev.c @@ -849,7 +849,7 @@ otx_ep_eth_dev_init(struct rte_eth_dev *eth_dev) otx_ep_info("Using pkind %d.", otx_epvf->pkind); } else { otx_ep_err("Invalid chip id"); - return -EINVAL; + ret = -EINVAL; goto exit; } -- 2.34.1