DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Robin Jarry <rjarry@redhat.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] test/fib: fix RCU tests
Date: Tue, 15 Oct 2024 09:51:11 +0200	[thread overview]
Message-ID: <20241015075111.968663-1-david.marchand@redhat.com> (raw)

The flags field must be initialized to 0 following commit
e194f3cd5685 ("fib: lookup IPv4 address in network order").

This was missed when merging the FIB RCU reclaim.

Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation")

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Robin Jarry <rjarry@redhat.com>
---
Note: applied directly on main to fix random fib unit tests failure in CI.

---
 app/test/test_fib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_fib.c b/app/test/test_fib.c
index 08650e41ff..15035ee045 100644
--- a/app/test/test_fib.c
+++ b/app/test/test_fib.c
@@ -389,7 +389,7 @@ int32_t
 test_invalid_rcu(void)
 {
 	struct rte_fib *fib = NULL;
-	struct rte_fib_conf config;
+	struct rte_fib_conf config = { 0 };
 	size_t sz;
 	struct rte_rcu_qsbr *qsv;
 	struct rte_rcu_qsbr *qsv2;
@@ -503,7 +503,7 @@ test_fib_rcu_qsbr_reader(void *arg)
 int32_t
 test_fib_rcu_sync_rw(void)
 {
-	struct rte_fib_conf config;
+	struct rte_fib_conf config = { 0 };
 	size_t sz;
 	int32_t status;
 	uint32_t i, next_hop;
-- 
2.46.2


                 reply	other threads:[~2024-10-15  7:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015075111.968663-1-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=rjarry@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).