From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35A8645B40; Tue, 15 Oct 2024 09:51:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2FB74027C; Tue, 15 Oct 2024 09:51:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0CCE0400EF for ; Tue, 15 Oct 2024 09:51:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728978688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r+XgxVS1pZ8mnzuWt6Kqv98LavXMNa8U19gx5bpNlM8=; b=M70dOaZRckeGXaSahgFOduQ30gMVo+EC8BmRyhOm+KA39LBaxQi6xnMr/RGvywt+24/u/6 1coWNmWQh7BQxaelUy8RQFouV1Xk5QM3nQ4rm8roO95k1ntCM6WwMRGcZEyduFRhqBphsj hiV4apCUeNgywzTBKR3ARFvmHHzF8z4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-pl5Qi351Oz-EbxPfBNOzcQ-1; Tue, 15 Oct 2024 03:51:25 -0400 X-MC-Unique: pl5Qi351Oz-EbxPfBNOzcQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 505B4195608B; Tue, 15 Oct 2024 07:51:24 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.57]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8B8681956089; Tue, 15 Oct 2024 07:51:22 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Robin Jarry , Vladimir Medvedkin , Stephen Hemminger Subject: [PATCH] test/fib: fix RCU tests Date: Tue, 15 Oct 2024 09:51:11 +0200 Message-ID: <20241015075111.968663-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The flags field must be initialized to 0 following commit e194f3cd5685 ("fib: lookup IPv4 address in network order"). This was missed when merging the FIB RCU reclaim. Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation") Signed-off-by: David Marchand Acked-by: Robin Jarry --- Note: applied directly on main to fix random fib unit tests failure in CI. --- app/test/test_fib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_fib.c b/app/test/test_fib.c index 08650e41ff..15035ee045 100644 --- a/app/test/test_fib.c +++ b/app/test/test_fib.c @@ -389,7 +389,7 @@ int32_t test_invalid_rcu(void) { struct rte_fib *fib = NULL; - struct rte_fib_conf config; + struct rte_fib_conf config = { 0 }; size_t sz; struct rte_rcu_qsbr *qsv; struct rte_rcu_qsbr *qsv2; @@ -503,7 +503,7 @@ test_fib_rcu_qsbr_reader(void *arg) int32_t test_fib_rcu_sync_rw(void) { - struct rte_fib_conf config; + struct rte_fib_conf config = { 0 }; size_t sz; int32_t status; uint32_t i, next_hop; -- 2.46.2