From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFEEA45B42; Tue, 15 Oct 2024 17:30:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0478400D7; Tue, 15 Oct 2024 17:30:24 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id D59E3400D6 for ; Tue, 15 Oct 2024 17:30:22 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2e3010478e6so3416421a91.1 for ; Tue, 15 Oct 2024 08:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729006222; x=1729611022; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9J0LM8vKcHjuW4A6hsbsIqTOnJ6wS4Q91PHHjnGpYiE=; b=i8KbgfLB4q1Q2h+YhOmT1qlPAWZWGCGp3ZwWqAAsiGYn/dyLmORjjrDCWDUhx1oohX zrQVm9pxRvqhLp/fB5D6EbU5MNdIwjkJzQ4aC8MaxfJ16DwhGx67IhAJu6m7Fl3M3lHv wZOiFmX7LjaS+iyQ10B0rFPgWXPZOeUtFTcvwxlwcVWNc2+dRqGYtOzagHmogrEQkM7y hFcWb1gTFxu9Ay0wFYKagJIvGEp/29AgUih9HIbguo7hhLa0rBkhv5+n6ja3KTl65Sgj xLsIpOWpYnM8g/TUF04woNYEYQst6gDfNdKh10j95ppEKgPU0jVQHr3qMZV0t0gBva1H 5E8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729006222; x=1729611022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9J0LM8vKcHjuW4A6hsbsIqTOnJ6wS4Q91PHHjnGpYiE=; b=PLY0yGITHiJJm/wsDXN/w8sImPX1/IPCY0E3M0jz/RmgSMx1xMchueboEqFZhS0MGc X1BpDAu518JgXJh9g1ZQeTEWNyVjm3UsJLQc/Za37RKPuFZ5ws0+3yl5LZMmH0JyhQhr DK1I6YWq5vto5DyGEJPe331M3NX6dhPrlLPHQ189MKm8vKjkwWigQany8pz7ZExMSkng PrvgD32vxTAgZO6xe5Cauyivd+6yF2xzQdb19GaLmEm1RYaWuxnv2KJtFCkev+vqOE/U XcoK7RFADOUH6gAy/cEGCuCnKuQKryyixLjcKKgOrzblFe1zCfNT4rNt4YgwBQUQqmk4 lJmA== X-Gm-Message-State: AOJu0YwdC68Lfh2dh0Uj5FG5ZzcKqW0woWkXyfBh57NcygNn/18wfW3K hALVSNuxJNRg/6rUKKHbP6riKUB/tkNGn88+Ilh90MjdWnuclh+VDoUkB6qZyH8= X-Google-Smtp-Source: AGHT+IHnKkDRHntMKPTyU6MO/+7N9L8MeerjbCa167DgRDgSEyG0D7lkn4x3Qe2JtiGxDThglzsQ1Q== X-Received: by 2002:a17:90a:4e0d:b0:2e2:b41b:854e with SMTP id 98e67ed59e1d1-2e3152e4dd9mr16572979a91.20.1729006221884; Tue, 15 Oct 2024 08:30:21 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e392f62e5fsm1927920a91.39.2024.10.15.08.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 08:30:21 -0700 (PDT) Date: Tue, 15 Oct 2024 08:30:19 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v1 12/18] net/r8169: implement Tx path Message-ID: <20241015083019.1861876d@hermes.local> In-Reply-To: <20241015030928.70642-13-howard_wang@realsil.com.cn> References: <20241015030928.70642-1-howard_wang@realsil.com.cn> <20241015030928.70642-13-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 11:09:22 +0800 Howard Wang wrote: > +rtl_tx_queue_release_mbufs(struct rtl_tx_queue *txq) > +{ > + int i; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (txq != NULL) { > + if (txq->sw_ring != NULL) { > + for (i = 0; i < txq->nb_tx_desc; i++) { > + if (txq->sw_ring[i].mbuf != NULL) { > + rte_pktmbuf_free_seg(txq->sw_ring[i].mbuf); > + txq->sw_ring[i].mbuf = NULL; calling free_seg is wrong since you support multi seg transmit