From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6173D45A6D; Tue, 15 Oct 2024 17:32:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F4DD4027D; Tue, 15 Oct 2024 17:32:26 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id EBB25400D6 for ; Tue, 15 Oct 2024 17:32:24 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71e5a1c9071so2166304b3a.0 for ; Tue, 15 Oct 2024 08:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729006344; x=1729611144; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BNuCgG5b8wShk+HeFMf2wm23YUlXJxE+PStnHmG4+c4=; b=UvnQgWOxeD98zHUdWCVE6usLBDIYwsdDWDswEmydpnZ+K1H6Rmc5/1jQiFB6/0H5Wc Jyx6eiXYgolkHEDAIaQ6CTzM+GODVCsGzyIa5YHht8/3sCvAjfdoeg410PoijBAZYJUg nmxth9lElI1TzF12W7WAcEX5OVjx2CVDYAVZQwMptfUyuoycIjt0C610RXqm09MngiXH s/9MYco5186DSDTEpssBaRMvFipS1U814dUr4CTvamyiLgxvT5HJ3Icso8o5IK+fDZMu wyO18FhWHXuDnjpXUPdM0XSwTqPS5lvzqHP9qjCwMLbclJy0qIUPxCm0607pq2c64rKQ qB1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729006344; x=1729611144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNuCgG5b8wShk+HeFMf2wm23YUlXJxE+PStnHmG4+c4=; b=IuyqhajxMgEng8/FFz5bsY8axnHKHFQdMrY9QrjGmLzOe8h9cyn2UpAH1JhG0AV4PK CJJJJH2b00PYehpFhSTET4fGYicMRRDXp1QA2/13bBe3rUn4c5kSbXT3bBxrs5ix5iQ+ 9F9/mdZ+ZnWmBiLeijmEvM2xGbsghPos/KDuXWtiig3I79Br+DhgwvxIHSWK4H+ztW+F 16Wq4xHE+kxs5Z6XAUHOrtS1XP16gtKwmVq8vRu2xpUvRe5LNph+wZhqE5D+EGNksW4q VOoAr2uMLnZiYXbUyqLn4TrR0fkVvKN5IpTaaf3mw8BTXMJv2aFUzFjoB1lCPDYbM8U9 c8zA== X-Gm-Message-State: AOJu0Yzfj9/yVUXtofJgh1l7KUojvdXhj4RR5CjRiukClALmPMISHP45 xYVNN+M/S7LkVGHiGufHwpmnB3F0sXdm7JzZSPg6AE3u1NshnZT9XjSrtL5f52Q= X-Google-Smtp-Source: AGHT+IGpqeakwonT6d+bUblkXzVau/7AQO5L9QuPvAG9SbHmTWJJRgCwjrQBAdcK4Av3irvfjJWlKw== X-Received: by 2002:a05:6a00:1145:b0:71d:f510:b791 with SMTP id d2e1a72fcca58-71e37e49da7mr24116586b3a.12.1729006344005; Tue, 15 Oct 2024 08:32:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e773a2f68sm1402486b3a.65.2024.10.15.08.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 08:32:23 -0700 (PDT) Date: Tue, 15 Oct 2024 08:32:21 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v1 12/18] net/r8169: implement Tx path Message-ID: <20241015083221.2caaf450@hermes.local> In-Reply-To: <20241015030928.70642-13-howard_wang@realsil.com.cn> References: <20241015030928.70642-1-howard_wang@realsil.com.cn> <20241015030928.70642-13-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 11:09:22 +0800 Howard Wang wrote: > + /* Allocate memory for the software ring */ > + txq->sw_ring = rte_zmalloc_socket("r8169 sw tx ring", > + nb_tx_desc * sizeof(struct rtl_tx_entry), > + RTE_CACHE_LINE_SIZE, socket_id); > + Prefer use of rte_calloc when allocating array