From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1593245B42; Tue, 15 Oct 2024 17:35:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE06E4027D; Tue, 15 Oct 2024 17:35:50 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 4DC82400D6 for ; Tue, 15 Oct 2024 17:35:49 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7db637d1e4eso3955093a12.2 for ; Tue, 15 Oct 2024 08:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729006548; x=1729611348; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mMtkMaLl+2MLsLww+esEN9ncZKMrSjFP2qHsufMe+Ks=; b=YlrEqOfS0B8ffpVpwk8NuDqBEhIztoQmZbviSEgAH3uWw1tvcT9yhmG1mIQnExB7Lx DhTmq883kxyvE4RVh8bgLBSp01YjexWfPM/LBBZxXxMsPXTqgR3R0Fu+tCAiHIWWzWXH abW2Knsfa6S0iUqfvU6CaOTdbQycO/aRtXbWdKnRmBsUA/5mS+kpk0QE8kj5DryeMOP/ qwPNnRTptIJfkLnmDApm1lljMZ2c06C6K8ioy/60MbPioOsUHxQdIQmFzToDPE/KaAS9 IqV2QOk2LNXyTqA2+rSKhDgZWHY5mWs7Y+zwelU+Z2Ya2NC4d4ZSqfYJKDP00XWZe3rg iFsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729006548; x=1729611348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mMtkMaLl+2MLsLww+esEN9ncZKMrSjFP2qHsufMe+Ks=; b=vQuhOf9QQaiT/usWtBg6v/MwXiM4BiZFf16lbNwtwpLxbgu222aJ1fHcrMpJybdmzS iDJiF/881Qkr0KTeinI+pcm6NZAENNJe3RZQ12ucDpxizIrM5J6xC2ld7OqfJ60ME2qB TpNPIo9uEAAfJ8G5PPFp9r4AHstajlmeJXtwFfin/UCIbSurUNBKZgBLhFGaGSUkUly9 T6IdtfeQBDP+xKk2iDPWRlAhu4MTJ3vM094MFCQBhMGtQR7xlYXPnb2ST6upJQoc57lf Rr6qCCLZiFmWYeQzo63ufe8v9OiKa4ZxNMTB+ld11UaliquWixviQ0Wvn4f6j9IhLy1p fLMQ== X-Gm-Message-State: AOJu0Yx7+IfrDOJiGHKd14Ddq0m9rnY7GKcSxtT6Aw8O6uucbOAeFbID ATTqO5BvpaCw/DPpTUX71FQmtJmAyFjLLx5CIFX7720pwpNfTGvT8gJoZoxXxDE= X-Google-Smtp-Source: AGHT+IF6uxnAq5uDzkNRNMgStHu/wf2/PSevPr0KIi1DgERRFsVcIDj/FN5Nd0Gvvoh8phOP1O1nhg== X-Received: by 2002:a05:6a20:c901:b0:1cf:3838:1ed9 with SMTP id adf61e73a8af0-1d905f8e800mr688739637.50.1729006548356; Tue, 15 Oct 2024 08:35:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ea9c6ba4b1sm1510372a12.5.2024.10.15.08.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 08:35:48 -0700 (PDT) Date: Tue, 15 Oct 2024 08:35:45 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v1 12/18] net/r8169: implement Tx path Message-ID: <20241015083545.43504a47@hermes.local> In-Reply-To: <20241015083019.1861876d@hermes.local> References: <20241015030928.70642-1-howard_wang@realsil.com.cn> <20241015030928.70642-13-howard_wang@realsil.com.cn> <20241015083019.1861876d@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 08:30:19 -0700 Stephen Hemminger wrote: > On Tue, 15 Oct 2024 11:09:22 +0800 > Howard Wang wrote: > > > +rtl_tx_queue_release_mbufs(struct rtl_tx_queue *txq) > > +{ > > + int i; > > + > > + PMD_INIT_FUNC_TRACE(); > > + > > + if (txq != NULL) { > > + if (txq->sw_ring != NULL) { > > + for (i = 0; i < txq->nb_tx_desc; i++) { > > + if (txq->sw_ring[i].mbuf != NULL) { > > + rte_pktmbuf_free_seg(txq->sw_ring[i].mbuf); > > + txq->sw_ring[i].mbuf = NULL; > > calling free_seg is wrong since you support multi seg transmit Never mind, code is correct. Each tx ring entry is an mbuf segment.