From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD58A45B42; Tue, 15 Oct 2024 10:59:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4D7840A89; Tue, 15 Oct 2024 10:59:08 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2041.outbound.protection.outlook.com [40.107.104.41]) by mails.dpdk.org (Postfix) with ESMTP id E9CFE402ED for ; Tue, 15 Oct 2024 10:58:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SI0emCcdxrCuYhZ8BO+HJMnQHYrRt3BNHbSj0bU69P99guvO29vUKRi3f5gtK7h7RQrnp/0fSNEi3oHy/Co2zmEUDpLC0VnYHGqgzM0IBIrSqhYQ4sqWBsrjlgTs7Bf9l5R2T1B4b1hzCF+AMl5dpRuLOKJskWwJMczzoCxTsp/6wJmSRMdJ2QorIeZshVumz4Wyvvm5waySjFJuKH0TN5rmK+Kg8gtHQe4q1zUN9lN40NzwGKUX1JUgjpAE9Tvt2TZApYuhs+XEdPqWLyuiIE/vx/0JwA145CnLuNEMHwFbu92ilR99fvBXI7tr1ShLLCgdajgvXNCiRhlAsjSYVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU2CUVQ48uviCkDwDc6kGHFFFa3aXbLJlMB9Nm11VcM=; b=ZFOvXohLoR8TB51hWP76MKIl4VSDsdi9KBaRqa+/yGcDb6ELtIKpD9YydkggkAXblb/VOuKQ9rNqyWYMnsRbcx52uP7Ayt7yPg5+FfazX9d4kEm5YJwlerDdw72VnysG4hS5uyXcGqK+DqpPRs5zIgtNFHKLyhisjKEnDwxfR1mgKvqyu47i55/JZTQPeqjwCjZBaJcvtL9d6gYOmVJnimd4+O7Ygx4hNY5ZB4PRTr45iywdzytl7pqCZWmYCnTDfkQ0i1aJJW6HS6+TsGpbkb3BzVnMp9OheCDivRT6t0tkQy62Wxuc/6Gf2axtB+eDb7L5m46mAiMCeZGXEXe20Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tU2CUVQ48uviCkDwDc6kGHFFFa3aXbLJlMB9Nm11VcM=; b=ffw/6GypWSeQAxmrUg8vrCxHCvxw7qlmaqIpqt1SHYCE4xXYC9O3q6FpMznoiEXHQ4L8NC1FFYwCxMK+cLtuMBzVgaWzxAcYGuDXPsSrPl65+r6jNPsWiJys0EAw00fdUb0m+38/saOpiiP8yq6Erez06Z/zV4RSLgNAD6gQMqNz9KYYEd/ljXX3B8rjAtdVTFfl2+S6Z/w8Vk1XbsP4V17efnBcuqQxf+iLDMckdSj37vTy3eYoDyWXU1nFvKMfd0cda6HE94ve5i5vO+ZOcJQG3zQ8W3ltUnWE4BHs5VB7iaGtE/E5WclZxpUv1HLryR7BXoJ5EwqYIQPMoZ9Fhg== Received: from DUZPR01CA0305.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::26) by PAXPR07MB8674.eurprd07.prod.outlook.com (2603:10a6:102:241::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Tue, 15 Oct 2024 08:58:51 +0000 Received: from DB5PEPF00014B8B.eurprd02.prod.outlook.com (2603:10a6:10:4b7:cafe::e7) by DUZPR01CA0305.outlook.office365.com (2603:10a6:10:4b7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27 via Frontend Transport; Tue, 15 Oct 2024 08:58:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB5PEPF00014B8B.mail.protection.outlook.com (10.167.8.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.17 via Frontend Transport; Tue, 15 Oct 2024 08:58:51 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.64) with Microsoft SMTP Server id 15.2.1544.11; Tue, 15 Oct 2024 10:58:49 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id 28AC01C006D; Tue, 15 Oct 2024 10:58:49 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: Jerin Jacob CC: , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , David Marchand , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [RFC 10/10] eventdev: remove single event enqueue and dequeue Date: Tue, 15 Oct 2024 10:49:43 +0200 Message-ID: <20241015084943.823983-11-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241015084943.823983-1-mattias.ronnblom@ericsson.com> References: <20241015084943.823983-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B8B:EE_|PAXPR07MB8674:EE_ X-MS-Office365-Filtering-Correlation-Id: 650f6e88-9648-4424-5976-08dcecf79704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?REswU3RjSVFVQnVtMnhkNE5vV0dQK2s1NzV1dHJNc0pzUjZORCtMc01jWGwx?= =?utf-8?B?N1c0S1psVEQvbFVrVWhFb1F3c2ZYWEp3R25zckl2TXg3TE1leEQ4dkg0TFRS?= =?utf-8?B?cGFHYWZBd2RtKzdIYTYraXRTR1ZDSWVmOXBQdFMwSzk1T1BiNjhRUzJrMHd2?= =?utf-8?B?cWlTUHZ0UFY2RWN5cTRiWm01NVFKQy8xTjZyV3RYNFlyd203emVKZG13UjJa?= =?utf-8?B?Tmk3T1FiWkFQUDNQRU1vWGdxWmFTaFFiOS9Ca0ZKajFOQm43Tk1UOTBpTU12?= =?utf-8?B?WVJOR2hodlp0UmxXWUlpSjB6TkdjQmxlWCtOaGhSTXA0SjNTYnQ2N3ArSEha?= =?utf-8?B?M091bmJFM3VlakxlRjExb1FrSWxZeTA3M0JQSldXblM1Yi8vaHVuUG1SMEYr?= =?utf-8?B?QTBnMFNSZUFwZ3lMZ2tZbkxqS2FCTUlzN1h0Szk1ZzZXZExzM1pOUGpnTXNr?= =?utf-8?B?azVuM0hsNnpQcC80ejNKQTc1aHdkdUhyNUNYWDJIZ3lsbzFKUkJXc1hyY1FV?= =?utf-8?B?THhkZGFKcDdIWDJEVHA4TS91VnQvclp3b2pISEJqcTYwZVg1Qi9kWHBvMkpy?= =?utf-8?B?Nmp1ZHdTOXgwUkJsTU9sNUJWK3BQTjNCd2Y0OFVDZnhYby9JckdSNTBYWlZS?= =?utf-8?B?RUQ4VDFndzdKMWlhYXZlUnlNamRVMklOczRHeEdBWUxMVDdTNm5JcUEvNE96?= =?utf-8?B?TzdodTJldEsyYU5yZkJhOExObVNMd29CVi9Hby9hYzNETWF1dmp4SFJSN0NZ?= =?utf-8?B?QnhueDN2RjlTSWladStoaWw5Q1FPYWxMUm11RGlqOFZab09DRG1LYjVnbmZa?= =?utf-8?B?ZDA3L083VTJIU1QySDBGRzFKNHlwek9jdTlTSVhDczVsWmhwM3R3bmhIU01U?= =?utf-8?B?VmV4M3VWNFBqamtmeXJSQ3ByYWhVTkl6TXhrbUxWWC96cmhMUm5iNnNPMWIz?= =?utf-8?B?WG5oRlE1aUp0VWdYaHIxU2tza2RKL2g0N2hodFozcWc0Z1pBRzE0SXBTenlC?= =?utf-8?B?VThKV1loTUx4dlNCNFpxYXN2Qy91NFYvRVlvaGgxanM4alVxZ1RBL25CalVw?= =?utf-8?B?cll2N2NXbzFWU3d6TkxzOVRSODFTSXBOT1ByQ2JGZXMydE9hSmI3eFpVcXFl?= =?utf-8?B?YUNGbURkT1NsRFMwN0xZYjNEWjV4b25xU20yN0VON0puMllta2RGVG5ZbERp?= =?utf-8?B?UytQRkZ4M2VFbVpSNzJyNTY2V0hFUHR4Uzd0OXNYRGtzNk1EdEZiWEd5dkl4?= =?utf-8?B?dStUQlhSNS82V3ViSEtmSVQwVWJDV2h6VVRDTVhNbWlaZ2lzbWx5SzFTbjFr?= =?utf-8?B?NnBEVEtIZmRFQnVKQUJVQWJqNlcwakhsWmRLR1lTUHNHdWhsb2VVaHVyczlL?= =?utf-8?B?V3BUYituZ2tNWldjekVOMFpCaGNPRVpsT0tMUXFEVzhiRVVYcXIxV0FRZ21p?= =?utf-8?B?c1JXRHRVMGJnSndsdXkxanhxb2RmbFBPSDc3WUM0cWxVT0NzOHI2SzFzVmhn?= =?utf-8?B?bUFLb0JoTXJ1NytaMFBLOFljOWVVYlFKSzJNZlh6YUV2dWM3NEMyRDVDejlZ?= =?utf-8?B?bWl3ckkwZnZZdzgya1ZuelpDZWVjZllYZEtxWUZ6L3lhMllzYWRyQ2R6QXFk?= =?utf-8?B?em9uOW45T3kzRlVvVUJmdFJDemMvQXQ1QkVCZEFBUGd1a3Bzb2ZFN0M1VkQx?= =?utf-8?B?bHNqNDFERGxMM05tNkluYWJHcW1pL2ZlWGlxZU4yTTdacEJQS0tYbDdIVTBp?= =?utf-8?B?UTlXN1N2YVJsQjZCY1pzNm5Uekp4RmZDKytMeVdnQUVpNTJ4YUo2QjI0bHhV?= =?utf-8?B?OXVobW9oSm5UYzZscm5ndEljSEp5V3lwSmNMeWVZWHU0UVA1QzZjckZ6LzdW?= =?utf-8?Q?bSfIz5T+Pz3kS?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 08:58:51.3708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 650f6e88-9648-4424-5976-08dcecf79704 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8B.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR07MB8674 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove the single event enqueue and dequeue, since they did not provide any noticable performance benefits. This is a change of the ABI, previously announced as a deprecation notice. These functions were not directly called by the application, so the API remains unaffected. Signed-off-by: Mattias Rönnblom --- doc/guides/rel_notes/deprecation.rst | 6 +----- lib/eventdev/eventdev_pmd.h | 4 ---- lib/eventdev/eventdev_private.c | 22 ---------------------- lib/eventdev/rte_eventdev.h | 21 ++++----------------- lib/eventdev/rte_eventdev_core.h | 4 ---- 5 files changed, 5 insertions(+), 52 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 7bc2310bc4..6a6fd54444 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -173,11 +173,7 @@ Deprecation Notices * eventdev: The single-event (non-burst) enqueue and dequeue operations, used by static inline burst enqueue and dequeue functions in ``rte_eventdev.h``, - will be removed in DPDK 23.11. - This simplification includes changing the layout and potentially also - the size of the public ``rte_event_fp_ops`` struct, breaking the ABI. - Since these functions are not called directly by the application, - the API remains unaffected. + are removed in DPDK 24.11. * pipeline: The pipeline library legacy API (functions rte_pipeline_*) will be deprecated and subsequently removed in DPDK 24.11 release. diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h index af855e3467..36148f8d86 100644 --- a/lib/eventdev/eventdev_pmd.h +++ b/lib/eventdev/eventdev_pmd.h @@ -158,16 +158,12 @@ struct __rte_cache_aligned rte_eventdev { uint8_t attached : 1; /**< Flag indicating the device is attached */ - event_enqueue_t enqueue; - /**< Pointer to PMD enqueue function. */ event_enqueue_burst_t enqueue_burst; /**< Pointer to PMD enqueue burst function. */ event_enqueue_burst_t enqueue_new_burst; /**< Pointer to PMD enqueue burst function(op new variant) */ event_enqueue_burst_t enqueue_forward_burst; /**< Pointer to PMD enqueue burst function(op forward variant) */ - event_dequeue_t dequeue; - /**< Pointer to PMD dequeue function. */ event_dequeue_burst_t dequeue_burst; /**< Pointer to PMD dequeue burst function. */ event_maintain_t maintain; diff --git a/lib/eventdev/eventdev_private.c b/lib/eventdev/eventdev_private.c index b628f4a69e..6df129fc2d 100644 --- a/lib/eventdev/eventdev_private.c +++ b/lib/eventdev/eventdev_private.c @@ -5,15 +5,6 @@ #include "eventdev_pmd.h" #include "rte_eventdev.h" -static uint16_t -dummy_event_enqueue(__rte_unused void *port, - __rte_unused const struct rte_event *ev) -{ - RTE_EDEV_LOG_ERR( - "event enqueue requested for unconfigured event device"); - return 0; -} - static uint16_t dummy_event_enqueue_burst(__rte_unused void *port, __rte_unused const struct rte_event ev[], @@ -24,15 +15,6 @@ dummy_event_enqueue_burst(__rte_unused void *port, return 0; } -static uint16_t -dummy_event_dequeue(__rte_unused void *port, __rte_unused struct rte_event *ev, - __rte_unused uint64_t timeout_ticks) -{ - RTE_EDEV_LOG_ERR( - "event dequeue requested for unconfigured event device"); - return 0; -} - static uint16_t dummy_event_dequeue_burst(__rte_unused void *port, __rte_unused struct rte_event ev[], @@ -129,11 +111,9 @@ event_dev_fp_ops_reset(struct rte_event_fp_ops *fp_op) { static void *dummy_data[RTE_MAX_QUEUES_PER_PORT]; static const struct rte_event_fp_ops dummy = { - .enqueue = dummy_event_enqueue, .enqueue_burst = dummy_event_enqueue_burst, .enqueue_new_burst = dummy_event_enqueue_burst, .enqueue_forward_burst = dummy_event_enqueue_burst, - .dequeue = dummy_event_dequeue, .dequeue_burst = dummy_event_dequeue_burst, .maintain = dummy_event_maintain, .txa_enqueue = dummy_event_tx_adapter_enqueue, @@ -153,11 +133,9 @@ void event_dev_fp_ops_set(struct rte_event_fp_ops *fp_op, const struct rte_eventdev *dev) { - fp_op->enqueue = dev->enqueue; fp_op->enqueue_burst = dev->enqueue_burst; fp_op->enqueue_new_burst = dev->enqueue_new_burst; fp_op->enqueue_forward_burst = dev->enqueue_forward_burst; - fp_op->dequeue = dev->dequeue; fp_op->dequeue_burst = dev->dequeue_burst; fp_op->maintain = dev->maintain; fp_op->txa_enqueue = dev->txa_enqueue; diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index b5c3c16dd0..fabd1490db 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -2596,14 +2596,8 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id, } #endif rte_eventdev_trace_enq_burst(dev_id, port_id, ev, nb_events, (void *)fn); - /* - * Allow zero cost non burst mode routine invocation if application - * requests nb_events as const one - */ - if (nb_events == 1) - return (fp_ops->enqueue)(port, ev); - else - return fn(port, ev, nb_events); + + return fn(port, ev, nb_events); } /** @@ -2852,15 +2846,8 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[], } #endif rte_eventdev_trace_deq_burst(dev_id, port_id, ev, nb_events); - /* - * Allow zero cost non burst mode routine invocation if application - * requests nb_events as const one - */ - if (nb_events == 1) - return (fp_ops->dequeue)(port, ev, timeout_ticks); - else - return (fp_ops->dequeue_burst)(port, ev, nb_events, - timeout_ticks); + + return (fp_ops->dequeue_burst)(port, ev, nb_events, timeout_ticks); } #define RTE_EVENT_DEV_MAINT_OP_FLUSH (1 << 0) diff --git a/lib/eventdev/rte_eventdev_core.h b/lib/eventdev/rte_eventdev_core.h index 2706d5e6c8..78b06d1f2e 100644 --- a/lib/eventdev/rte_eventdev_core.h +++ b/lib/eventdev/rte_eventdev_core.h @@ -60,16 +60,12 @@ typedef void (*event_preschedule_t)(void *port, struct __rte_cache_aligned rte_event_fp_ops { void **data; /**< points to array of internal port data pointers */ - event_enqueue_t enqueue; - /**< PMD enqueue function. */ event_enqueue_burst_t enqueue_burst; /**< PMD enqueue burst function. */ event_enqueue_burst_t enqueue_new_burst; /**< PMD enqueue burst new function. */ event_enqueue_burst_t enqueue_forward_burst; /**< PMD enqueue burst fwd function. */ - event_dequeue_t dequeue; - /**< PMD dequeue function. */ event_dequeue_burst_t dequeue_burst; /**< PMD dequeue burst function. */ event_maintain_t maintain; -- 2.43.0