From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 917D945B42; Tue, 15 Oct 2024 17:57:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 248B0400D7; Tue, 15 Oct 2024 17:57:34 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 78C42400D6 for ; Tue, 15 Oct 2024 17:57:32 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20ca7fc4484so26661995ad.3 for ; Tue, 15 Oct 2024 08:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729007851; x=1729612651; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=l6Z8hVx6ako31Napgdiv39EbJ8SvvgHoVck8CkCzAfQ=; b=r659JcZlFvfBwDGoHEV6I6UBu6ufYhXhUl/vw6oz+DZkvbnvHLDUH+mOR80UKEMbzD td8T4T1Z0LkzyvH36pS8oE2II9laMcGSqffo+bn2cvJZSOcg5wrWKV8EHSf0koLq3O2y UFIjCSHbSyE1NWoNHySE31YlVmhH9EPWpkVZ4NY1iPgqJ0SS2UVU0svKJteyLFkIDO33 msva5EqBr7fYM3mq4mODDM5asUdukKul8bzuQMSvVuevqXYecsgeRfAua+47laOiuBva vblWjyyfH4kNtSnsmV3mI+g47OJc5RgXPIgsivlacznR6zg5nNoV1rpU5Yx5YbmLEzAM f9vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729007851; x=1729612651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l6Z8hVx6ako31Napgdiv39EbJ8SvvgHoVck8CkCzAfQ=; b=b91lt5qLeVYUm+o3fj6dyxl57NJCTPQu7FiRK1tC1LmzzdkG1+CGp6G/fcFHKooERs 7xtEetc3OzuqJXFZrENpem2Qi+sgCA7SrV9OaZFuPasbyTjLvaxC9sqdfq6rJDS2cKP0 EcUjOkefxs4PFC3/vXqQLZld5ucKIsxX27pKwNChSd507aZ3g7joAq3tE3PQZFJuOMPw Mk6WO9HsIQZapIB9Lw8rWSQoXrFtZwMczfIbK3lPVJIblCMIckf0pGJDlB4pl1uBjImY 4VC6DLCPxbdbWLC+MXDjTwJo3CNN2qqsWxMS90Xh9NUE+0hFuIasbjwg1dzu5cQNmctR WbOw== X-Gm-Message-State: AOJu0YwkTwc8K47Qq4G6sf3ia9CFderzHip9k+vfum0wVJaGDT5Muf/N YMFHNHzQEVkGOBQrS3Z+U7gBY+B+I30A2ufJfueeRi2V8745o7hb1hj0mx5mS54= X-Google-Smtp-Source: AGHT+IHEKxeR0Sqk6Av2BDWjsuO73z2PMrdq2SPVv9KOFkdpZIVPClxVC13HRZ5GkEfl14DJaY9JVg== X-Received: by 2002:a17:903:1c5:b0:20c:d8e4:8798 with SMTP id d9443c01a7336-20cd8e48a54mr154030745ad.49.1729007851406; Tue, 15 Oct 2024 08:57:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d17f9b082sm13667705ad.64.2024.10.15.08.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 08:57:31 -0700 (PDT) Date: Tue, 15 Oct 2024 08:57:29 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, ferruh.yigit@amd.com, wang.yong19@zte.com.cn Subject: Re: [PATCH v5 9/9] net/zxdh: add zxdh dev configure ops Message-ID: <20241015085729.49852445@hermes.local> In-Reply-To: <20241015054435.1751245-8-wang.junlong1@zte.com.cn> References: <20241015054306.1751147-2-wang.junlong1@zte.com.cn> <20241015054435.1751245-1-wang.junlong1@zte.com.cn> <20241015054435.1751245-8-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 13:44:35 +0800 Junlong Wang wrote: > provided zxdh dev configure ops for queue > check,reset,alloc resources,etc. >=20 > Signed-off-by: Junlong Wang These build failures need to be addressed. Probably as simple as adding struct bar_msg_header msg_header =3D { 0 }; ###########################################################################= ######### #### [Begin job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test ###########################################################################= ######### 951 | struct bar_msg_header msg_header; | ^~~~~~~~~~ ../drivers/net/zxdh/zxdh_msg.c:976:60: error: =E2=80=98msg_header.sync=E2= =80=99 may be used uninitialized [-Werror=3Dmaybe-uninitialized] 976 | uint64_t reps_addr =3D zxdh_reply_addr_get(msg_header.sync,= src, dst, virt_addr); | ~~~~~~~~~~^~~~~ ../drivers/net/zxdh/zxdh_msg.c:951:31: note: =E2=80=98msg_header=E2=80=99 d= eclared here 951 | struct bar_msg_header msg_header; | ^~~~~~~~~~ In function =E2=80=98zxdh_bar_msg_ack_async_msg_proc=E2=80=99, inlined from =E2=80=98zxdh_bar_irq_recv=E2=80=99 at ../drivers/net/zxdh= /zxdh_msg.c:984:3: ../drivers/net/zxdh/zxdh_msg.c:860:78: error: =E2=80=98msg_header.msg_id=E2= =80=99 may be used uninitialized [-Werror=3Dmaybe-uninitialized] 860 | struct seqid_item *reps_info =3D &g_seqid_ring.reps_info_tb= l[msg_header->msg_id]; | = ~~~~~~~~~~^~~~~~~~ ../drivers/net/zxdh/zxdh_msg.c: In function =E2=80=98zxdh_bar_irq_recv=E2= =80=99: ../drivers/net/zxdh/zxdh_msg.c:951:31: note: =E2=80=98msg_header=E2=80=99 d= eclared here 951 | struct bar_msg_header msg_header; | ^~~~~~~~~~ cc1: all warnings being treated as errors [2198/3046] Compiling C object 'drivers/a715181@@tmp_rte_net_zxdh at sta/ne= t_zxdh_zxdh_queue.c.o'. [2199/3046] Compiling C object 'drivers/a715181@@tmp_rte_raw_cnxk_bphy at s= ta/raw_cnxk_bphy_cnxk_bphy_cgx.c.o'. [2200/3046] Generating rte_net_vmxnet3.pmd.c with a custom command. [2201/3046] Compiling C object 'drivers/a715181@@tmp_rte_raw_cnxk_bphy at s= ta/raw_cnxk_bphy_cnxk_bphy.c.o'. [2202/3046] Compiling C object 'drivers/a715181@@tmp_rte_net_zxdh at sta/ne= t_zxdh_zxdh_common.c.o'. ninja: build stopped: subcommand failed. ##[error]Process completed with exit code 1. ###########################################################################= ######### #### [End job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test ###########################################################################= #########