From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDDA345A78; Tue, 15 Oct 2024 19:07:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3093E40273; Tue, 15 Oct 2024 19:07:34 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id CEF954021F for ; Tue, 15 Oct 2024 19:07:32 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71e625b00bcso1930324b3a.3 for ; Tue, 15 Oct 2024 10:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729012052; x=1729616852; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZJEkoXyQLo73P5uFdo12QMK8CAbWuDAmwyQYkkVH7c4=; b=1fMgTxGWlvJnW0Y01LdKMB7QXvqqX+5TzGKcKvbhMsS0+F9tyzbwSmn/NdFYDmlaAE bvW0WoK05ndjtE65zFN2tifymdlNrO2sA0fu+zMZ7cS2djgdy7srnRX78eD3YGFQeO3f QbjJ2nthCh4x5pC+rze718onjdToVI6KTHbdMa4Mi/xkd1sVQ9CyFRFglJerUXbx/T9y 16CVcaC+xeuAo4Mn+xyQyEDr0Gz6P7Az/R8F6Q6ia/kRsB5VX+8WdjRk+KcQ82+oSeSF S6AS+xzjwB9NvzJwUllY+9+lkdVl+QIuWdmeCWgldLaAgdHOiYy70hYT4/54H/0o8FbM ShAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729012052; x=1729616852; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZJEkoXyQLo73P5uFdo12QMK8CAbWuDAmwyQYkkVH7c4=; b=mdVafa79dr2+Dp82rFoJJY8obKdMVD7ch485vOEQfulb9tY4jS07hqpxGJRNbR2kzX iVwrAhiOW8KPZQfwK4gKsYXeQOr9hCRWhzbvGhRbdjSFUojxcCLLceHFfRdk6yWka1QI eGRIBkCYQ34VFPT1v2iCaUsqVbwTgaebEHbYUH+X1zECu6hj0Ez9iQ0VSuIGn1zcdx09 Q4ZTSrYJSaBRVHa46xR9947jaA1r3ZJ8QFwvJIifmnpRXIUxvuhqHxnlAfam1MsGBeLJ VAcx7Z7fbhAtMmSlv/ZY1SqUEjHHyOQmc/Ec2Z4eUWkOcnUH13/YVkkOVZsqun8B+4Gp 1dmg== X-Forwarded-Encrypted: i=1; AJvYcCW7xKBHl2zwQefqmLJo+GxSc2U4FED14qpo8HrIfz0CSZJlfE0K+rTn8TLQK8h5A7FAVqo=@dpdk.org X-Gm-Message-State: AOJu0Yx452gmGbfgx0Rjsed31vjt/z/uIpW5Zyye/FgWMKJ8QgGd+pCc DLKaSo+xcpWm19G+yUz85wq1bKAWd7RmkM/1P8F25hDpBfhj5aIWlQmPRr3xS+E= X-Google-Smtp-Source: AGHT+IGU6b3La4pa7+FK+aI+NWFcV4uf2ZZw1uh61IvJk0AWu46eMvBir7lQq+b0vKVoaVRaw+dSZg== X-Received: by 2002:a05:6a00:8717:b0:71e:4fe4:354d with SMTP id d2e1a72fcca58-71e4fe43604mr12405615b3a.18.1729012051840; Tue, 15 Oct 2024 10:07:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e773716afsm1517846b3a.29.2024.10.15.10.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 10:07:31 -0700 (PDT) Date: Tue, 15 Oct 2024 10:07:30 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Jerin Jacob , , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , David Marchand Subject: Re: [RFC 00/10] eventdev: remove single-event enqueue and dequeue Message-ID: <20241015100730.2ab1a501@hermes.local> In-Reply-To: <20241015084943.823983-1-mattias.ronnblom@ericsson.com> References: <20241015084943.823983-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 10:49:33 +0200 Mattias R=C3=B6nnblom wrote: > Remove the single-event enqueue and dequeue functions from the > eventdev "ops" struct, to reduce complexity, leaving performance > unaffected. >=20 > This ABI change has been announced as a DPDK deprication notice, > originally scheduled for DPDK 23.11. >=20 > Mattias R=C3=B6nnblom (10): > event/dsw: remove single event enqueue and dequeue > event/dlb2: remove single event enqueue and dequeue > event/cnxk: remove single event enqueue and dequeue > event/octeontx: remove single event enqueue and dequeue > event/sw: remove single event enqueue and dequeue > event/dpaa: remove single event enqueue and dequeue > event/dpaa2: remove single event enqueue and dequeue > event/opdl: remove single event enqueue and dequeue > event/skeleton: remove single event enqueue and dequeue > eventdev: remove single event enqueue and dequeue >=20 > doc/guides/rel_notes/deprecation.rst | 6 +-- > drivers/event/cnxk/cn10k_eventdev.c | 2 - > drivers/event/cnxk/cn10k_worker.c | 49 ++++++++++------------ > drivers/event/cnxk/cn10k_worker.h | 9 ---- > drivers/event/cnxk/cn9k_eventdev.c | 1 - > drivers/event/cnxk/cn9k_worker.c | 26 ++++-------- > drivers/event/cnxk/cn9k_worker.h | 17 -------- > drivers/event/dlb2/dlb2.c | 33 +-------------- > drivers/event/dpaa/dpaa_eventdev.c | 27 +----------- > drivers/event/dpaa2/dpaa2_eventdev.c | 2 - > drivers/event/dsw/dsw_evdev.c | 2 - > drivers/event/dsw/dsw_evdev.h | 2 - > drivers/event/dsw/dsw_event.c | 12 ------ > drivers/event/octeontx/ssovf_evdev.h | 1 - > drivers/event/octeontx/ssovf_worker.c | 40 ++---------------- > drivers/event/opdl/opdl_evdev.c | 2 - > drivers/event/skeleton/skeleton_eventdev.c | 4 -- > drivers/event/sw/sw_evdev.c | 2 - > drivers/event/sw/sw_evdev.h | 2 - > drivers/event/sw/sw_evdev_worker.c | 12 ------ > lib/eventdev/eventdev_pmd.h | 4 -- > lib/eventdev/eventdev_private.c | 22 ---------- > lib/eventdev/rte_eventdev.h | 21 ++-------- > lib/eventdev/rte_eventdev_core.h | 4 -- > 24 files changed, 43 insertions(+), 259 deletions(-) Looks good always like to see code removed. You missed one place though. *Build Failed #1: OS: RHEL94-64 Target: x86_64-native-linuxapp-clang FAILED: drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_dlb2.c.o=20 clang -Idrivers/libtmp_rte_event_dlb2.a.p -Idrivers -I../drivers -Idrivers/= event/dlb2 -I../drivers/event/dlb2 -Ilib/eventdev -I../lib/eventdev -I. -I.= . -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/lin= ux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x8= 6/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib= /kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metri= cs -Ilib/telemetry -I../lib/telemetry -Ilib/ring -I../lib/ring -Ilib/ethdev= -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/memp= ool -I../lib/mempool -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -I= lib/rcu -I../lib/rcu -Ilib/timer -I../lib/timer -Ilib/cryptodev -I../lib/cr= yptodev -Ilib/dmadev -I../lib/dmadev -Ilib/pci -I../lib/pci -Idrivers/bus/p= ci -I../drivers/bus/pci -I../drivers/bus/pci/linux -fcolor-diagnostics -D_F= ILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11 -O3 -in= clude rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -W= format-security -Wmissing-declarations -Wmissing-prototypes -Wnested-extern= s -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes= -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-i= nitializers -D_GNU_SOURCE -fPIC -march=3Dnative -mrtm -DALLOW_EXPERIMENTAL_= API -DALLOW_INTERNAL_API -DCC_AVX512_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=3Dpm= d.event.dlb2 -DRTE_ANNOTATE_LOCKS -Wthread-safety -MD -MQ drivers/libtmp_rt= e_event_dlb2.a.p/event_dlb2_dlb2.c.o -MF drivers/libtmp_rte_event_dlb2.a.p/= event_dlb2_dlb2.c.o.d -o drivers/libtmp_rte_event_dlb2.a.p/event_dlb2_dlb2.= c.o -c ../drivers/event/dlb2/dlb2.c ../drivers/event/dlb2/dlb2.c:3303:1: error: unused function 'dlb2_event_enq= ueue_delayed' [-Werror,-Wunused-function] 3303 | dlb2_event_enqueue_delayed(void *event_port, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. [2373/3000] Compiling C object drivers/libtmp_rte_event_dlb2.a.p/event_dlb2= _dlb2_iface.c.o [2374/3000] Compiling C object drivers/libtmp_rte_event_dlb2.a.p/event_dlb2= _dlb2_xstats.c.o [2375/3000] Compiling C object drivers/event/dlb2/libavx512_tmp.a.p/dlb2_av= x512.c.o [2376/3000] Compiling C object drivers/libtmp_rte_event_dlb2.a.p/event_dlb2= _rte_pmd_dlb2.c.o [2377/3000] Compiling C object drivers/libtmp_rte_event_cnxk.a.p/event_cnxk= _cn10k_eventdev.c.o [2378/3000] Compiling C object drivers/libtmp_rte_event_dlb2.a.p/event_dlb2= _pf_dlb2_pf.c.o [2379/3000] Compiling C object drivers/libtmp_rte_event_dpaa.a.p/event_dpaa= _dpaa_eventdev.c.o [2380/3000] Compiling C object drivers/libtmp_rte_event_dlb2.a.p/event_dlb2= _dlb2_selftest.c.o [2381/3000] Compiling C object drivers/libtmp_rte_event_dlb2.a.p/event_dlb2= _pf_base_dlb2_resource.c.o ninja: build stopped