From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6B2945B01; Tue, 15 Oct 2024 14:10:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DFC1400D7; Tue, 15 Oct 2024 14:10:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 33A7A400D6 for ; Tue, 15 Oct 2024 14:10:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728994252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+sKx/V8VX+JE1nRmQGlw0mvdxCWc2lH5h5fqcuaiM7E=; b=GLNESQeCuwxPEfkdsyNyVwD2orxDwxgMw7hKqELn1EUMU4hI/NGvmuZev1m4B/yg6LSEpb EtHdXN8fsLlqzAaoiknkFilxb0CD+UjdHVvBXnsuvMcJCDxgZ8Dte7icTzPwCTuC6ZgIMn LE1dwTWQ5o2PDooADu0urRZYtcdZ24E= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-coUzFpwFP1OuXHcXF5h2qg-1; Tue, 15 Oct 2024 08:10:51 -0400 X-MC-Unique: coUzFpwFP1OuXHcXF5h2qg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6BF9519560A3; Tue, 15 Oct 2024 12:10:50 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.57]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7DB891956089; Tue, 15 Oct 2024 12:10:48 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com Subject: [PATCH 0/3] Enhance headers check Date: Tue, 15 Oct 2024 14:10:42 +0200 Message-ID: <20241015121046.2556695-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org We currently check that exported headers are fine with -DALLOW_EXPERIMENTAL_API and -DALLOW_INTERNAL_API. Such a check won't catch issues like the one fixed in patch 1, where OVS compilation is broken by the additional of experimental API in a header commonly included in other parts of DPDK. Ideally, I would like to merge patch 1 in rc1. The patch 2 is not a real issue (more like the enhanced check would complain about this header). In any case, I think it would not hurt merging everything now. Comments, please. -- David Marchand David Marchand (3): bitops: fix build for GCC without experimental API bitset: fix build for GCC without experimental API buildtools/chkincs: check headers with stable API only buildtools/chkincs/meson.build | 27 +++++++- lib/eal/include/rte_bitops.h | 6 ++ lib/eal/include/rte_bitset.h | 123 +++++++++++++++++++++++++++++++++ 3 files changed, 154 insertions(+), 2 deletions(-) -- 2.46.2