From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A555145B01; Tue, 15 Oct 2024 14:11:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91910402ED; Tue, 15 Oct 2024 14:11:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AF6A3402E3 for ; Tue, 15 Oct 2024 14:10:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728994259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tc/2c+L/bO8QtR83sJkXb93OoHLdduqVtYv7wR1XiTI=; b=PFR390qxQz1pkN0fqo3kBJb0o2H5RD8aCNcqKvuz4WAyINE9FWROi3dPFDm6AdOqhSn3sy /q4WOjq/Pfg1xEv9y0NkpzGSQvV3CPEJ6L2A6vy+vl4uWuu/HihgnrLcGGxjFV2NFiPmMx CAhHpKWVxZurRnmM/y9u64ZkhB/p3F8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-55X54IasMg-z_K9zQfEaSA-1; Tue, 15 Oct 2024 08:10:58 -0400 X-MC-Unique: 55X54IasMg-z_K9zQfEaSA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AAED919560B4; Tue, 15 Oct 2024 12:10:56 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.57]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 38B3119560A2; Tue, 15 Oct 2024 12:10:52 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com, Jack Bond-Preston , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [PATCH 1/3] bitops: fix build for GCC without experimental API Date: Tue, 15 Oct 2024 14:10:43 +0200 Message-ID: <20241015121046.2556695-2-david.marchand@redhat.com> In-Reply-To: <20241015121046.2556695-1-david.marchand@redhat.com> References: <20241015121046.2556695-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Building OVS against current DPDK fails with following warnings: In file included from .../ovs/dpdk-dir/include/rte_memory.h:18, from .../ovs/dpdk-dir/include/rte_ring_core.h:29, from .../ovs/dpdk-dir/include/rte_ring.h:37, from .../ovs/dpdk-dir/include/rte_mempool.h:49, from .../ovs/dpdk-dir/include/rte_mbuf.h:38, from lib/dp-packet.h:25, from lib/ofp-packet.c:20: .../ovs/dpdk-dir/include/rte_bitops.h: In function ‘__rte_bit_assign32’: .../ovs/dpdk-dir/include/rte_bitops.h:528:1: error: ‘__rte_bit_set32’ is deprecated: Symbol is not yet part of stable ABI [-Werror=deprecated-declarations] ... This comes from the fact that some (experimental) inline helpers are calling other experimental API. Hide those calls. Fixes: 471de107ae23 ("bitops: add new bit manipulation API") Reported-by: Kevin Traynor Signed-off-by: David Marchand --- lib/eal/include/rte_bitops.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index e08e41199a..deb1fd43f2 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -525,8 +525,10 @@ __rte_bit_ ## variant ## flip ## size(qualifier uint ## size ## _t *addr, unsign __RTE_GEN_BIT_OPS(,, size) \ __RTE_GEN_BIT_OPS(v_, volatile, size) +#ifdef ALLOW_EXPERIMENTAL_API __RTE_GEN_BIT_OPS_SIZE(32) __RTE_GEN_BIT_OPS_SIZE(64) +#endif #define __RTE_GEN_BIT_ATOMIC_TEST(variant, qualifier, size) \ __rte_experimental \ @@ -651,8 +653,10 @@ __rte_bit_atomic_ ## variant ## test_and_assign ## size( \ __RTE_GEN_BIT_ATOMIC_OPS(,, size) \ __RTE_GEN_BIT_ATOMIC_OPS(v_, volatile, size) +#ifdef ALLOW_EXPERIMENTAL_API __RTE_GEN_BIT_ATOMIC_OPS_SIZE(32) __RTE_GEN_BIT_ATOMIC_OPS_SIZE(64) +#endif /*------------------------ 32-bit relaxed operations ------------------------*/ @@ -1481,6 +1485,7 @@ rte_bit_ ## family ## fun(qualifier uint ## size ## _t *addr, arg1_type arg1_nam __RTE_BIT_OVERLOAD_SZ_4R(family, fun, qualifier, 64, ret_type, arg1_type, arg1_name, \ arg2_type, arg2_name, arg3_type, arg3_name) +#ifdef ALLOW_EXPERIMENTAL_API __RTE_BIT_OVERLOAD_2R(, test, const, bool, unsigned int, nr) __RTE_BIT_OVERLOAD_2(, set,, unsigned int, nr) __RTE_BIT_OVERLOAD_2(, clear,, unsigned int, nr) @@ -1496,6 +1501,7 @@ __RTE_BIT_OVERLOAD_3R(atomic_, test_and_set,, bool, unsigned int, nr, int, memor __RTE_BIT_OVERLOAD_3R(atomic_, test_and_clear,, bool, unsigned int, nr, int, memory_order) __RTE_BIT_OVERLOAD_4R(atomic_, test_and_assign,, bool, unsigned int, nr, bool, value, int, memory_order) +#endif #endif -- 2.46.2