From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDE6445B47; Wed, 16 Oct 2024 00:00:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9914C402B5; Wed, 16 Oct 2024 00:00:25 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id A7D9C4028F for ; Wed, 16 Oct 2024 00:00:23 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7ea78037b7eso2750414a12.0 for ; Tue, 15 Oct 2024 15:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729029623; x=1729634423; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xoefsAdiqVnKkidRIN2GklIdD8wRunM3IANqmExbf60=; b=FdWf0ESQP3d1Npp4fzZcmMFck8qfIhpIXL2nbRQjpvoMN8calfuTQ+djxyVoUiVW9Z eU/y6viocZA0CrNQPyW/0sYmdVtJ+1BefM5Wh/KvjALcKoTEG3qK7I/uzNJyZO8B3dl6 bxcV6Q9/TpCe9/I7lPVNgkcZWUqL6VsLl5/a5tEzN43PCrlPVEDcUaIq8yz8967Cyq9y MeiZHKDYTFV6B5u9STGnZj7VCE7p/8V8OWulP9Aq7HyPaeGpLM4iazR3S722IZnyatoi DMDah67lJgRTilrg9NUgibaa7lIQD6Tw/RDQK/GrNLh5LnoConvJGtHhDPjuT/qgZxtl UwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729029623; x=1729634423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoefsAdiqVnKkidRIN2GklIdD8wRunM3IANqmExbf60=; b=Drq624XgR1iN9YEzRhSzcHAl2mpK0habvfLbV5qoDKCPhY8OkTUSdKXEujhIr1iKir K8RgRr5f93+tImGOq5rhoqdegOyBUEDVeZ08hRTGP1eX6E/4ZxcGuVX36wYGwAMmbuAn tvMbiEn8Lz3ef2qnYQszQcQ+JlL970wOodP78bgaUr/wkuwcTTCfabaxf1XG2m3Th9K8 v3/1pA3uVJLt5mNpY/LKFHuw+CLs87r4I5IOiogKC83eY09BznKVP3IVjlrIMbFIckTp 4JqpN/XUj9KHX2Z4G10hPzYab/ATV73aSLmE6Z0EBq6a34tqJhnddgv7bBzUAytPDvms TB7A== X-Forwarded-Encrypted: i=1; AJvYcCUz4dygZA828n7IXhNIR9SLnuE0zsvVncxhAxI3oDSqC8/UbWOZJgamwQ0SjzGH6QzUh/o=@dpdk.org X-Gm-Message-State: AOJu0Yy83a8UpY3PeOfIjZTtmoyHqtAxSChRPrqggqloHrm+uGu9by3o ZBYNPaWGs7HTF4z7mAAbPjyoyk08ejqlFGbSWkw9vaFOVcU2Wklyfw3JwqP/djo= X-Google-Smtp-Source: AGHT+IFkoiyB2UKT1zU2ICgNoJT4Yoz7xNGuDu/98qOI6OShusKZ+5E7ltKiA4VMTVNnCfL0HAX6IQ== X-Received: by 2002:a05:6a20:2d2a:b0:1d8:aa64:8733 with SMTP id adf61e73a8af0-1d8bcf430edmr23373539637.26.1729029622517; Tue, 15 Oct 2024 15:00:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e773a301asm1814824b3a.70.2024.10.15.15.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 15:00:22 -0700 (PDT) Date: Tue, 15 Oct 2024 15:00:20 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Jerin Jacob , , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , David Marchand , Anoob Joseph , Hemant Agrawal , Sachin Saxena , Abdullah Sevincer , Pavan Nikhilesh , Shijith Thotton , Harry van Haaren Subject: Re: [RFC v2 10/10] eventdev: remove single event enqueue and dequeue Message-ID: <20241015150020.7d1a57f4@hermes.local> In-Reply-To: <20241015182535.825098-11-mattias.ronnblom@ericsson.com> References: <20241015084943.823983-2-mattias.ronnblom@ericsson.com> <20241015182535.825098-1-mattias.ronnblom@ericsson.com> <20241015182535.825098-11-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 20:25:35 +0200 Mattias R=C3=B6nnblom wrote: > Remove the single event enqueue and dequeue, since they did not > provide any noticable performance benefits. >=20 > This is a change of the ABI, previously announced as a deprecation > notice. These functions were not directly called by the application, > so the API remains unaffected. >=20 > Signed-off-by: Mattias R=C3=B6nnblom Still have a build failure with one driver. -------------------------------BEGIN LOGS---------------------------- ###########################################################################= ######### #### [Begin job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build and te= st ###########################################################################= ######### | ^~~~~~ ../drivers/event/cnxk/cn9k_eventdev.c: In function =E2=80=98cn9k_sso_fp_fns= _set=E2=80=99: ../drivers/event/cnxk/cn9k_eventdev.c:576:20: error: =E2=80=98struct rte_ev= entdev=E2=80=99 has no member named =E2=80=98enqueue=E2=80=99; did you mean= =E2=80=98ca_enqueue=E2=80=99? 576 | event_dev->enqueue =3D cn9k_sso_hws_enq; | ^~~~~~~ | ca_enqueue ../drivers/event/cnxk/cn9k_eventdev.c:576:30: error: =E2=80=98cn9k_sso_hws_= enq=E2=80=99 undeclared (first use in this function); did you mean =E2=80= =98cn9k_sso_hws_link=E2=80=99? 576 | event_dev->enqueue =3D cn9k_sso_hws_enq; | ^~~~~~~~~~~~~~~~ | cn9k_sso_hws_link ../drivers/event/cnxk/cn9k_eventdev.c:584:28: error: =E2=80=98struct rte_ev= entdev=E2=80=99 has no member named =E2=80=98enqueue=E2=80=99; did you mean= =E2=80=98ca_enqueue=E2=80=99? 584 | event_dev->enqueue =3D cn9k_sso_hws_dual_enq; | ^~~~~~~ | ca_enqueue ../drivers/event/cnxk/cn9k_eventdev.c:584:38: error: =E2=80=98cn9k_sso_hws_= dual_enq=E2=80=99 undeclared (first use in this function); did you mean =E2= =80=98cn9k_sso_hws_dual_ca_enq=E2=80=99? 584 | event_dev->enqueue =3D cn9k_sso_hws_dual_enq; | ^~~~~~~~~~~~~~~~~~~~~ | cn9k_sso_hws_dual_ca_enq [2451/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at sta/= event_cnxk_deq_cn9k_deq_64_79_seg_burst.c.o'. [2452/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at sta/= event_cnxk_deq_cn9k_deq_80_95_seg_burst.c.o'. [2453/4290] Generating rte_crypto_octeontx.sym_chk with a meson_exe.py cust= om command. [2454/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at sta/= event_cnxk_deq_cn9k_deq_96_111_seg_burst.c.o'. [2455/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at sta/= event_cnxk_deq_cn9k_deq_112_127_seg_burst.c.o'. ninja: build stopped: subcommand failed. ##[error]Process completed with exit code 1. ###########################################################################= ######### #### [End job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build and test ###########################################################################= ######### --------------------------------END LOGS-----------------------------