From: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com
Subject: [PATCH] fib: fix return value behavior
Date: Tue, 15 Oct 2024 17:11:43 +0000 [thread overview]
Message-ID: <20241015171143.497709-1-vladimir.medvedkin@intel.com> (raw)
Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its
return value to align with the existing rte_fib API.
Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation")
Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
lib/fib/dir24_8.c | 21 ++++++++-------------
lib/fib/rte_fib.h | 8 ++++----
2 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/lib/fib/dir24_8.c b/lib/fib/dir24_8.c
index 2fb01a3f99..73a59f3397 100644
--- a/lib/fib/dir24_8.c
+++ b/lib/fib/dir24_8.c
@@ -617,15 +617,11 @@ dir24_8_rcu_qsbr_add(struct dir24_8_tbl *dp, struct rte_fib_rcu_config *cfg,
struct rte_rcu_qsbr_dq_parameters params = {0};
char rcu_dq_name[RTE_RCU_QSBR_DQ_NAMESIZE];
- if (dp == NULL || cfg == NULL) {
- rte_errno = EINVAL;
- return 1;
- }
+ if (dp == NULL || cfg == NULL)
+ return -EINVAL;
- if (dp->v != NULL) {
- rte_errno = EEXIST;
- return 1;
- }
+ if (dp->v != NULL)
+ return -EEXIST;
if (cfg->mode == RTE_FIB_QSBR_MODE_SYNC) {
/* No other things to do. */
@@ -648,12 +644,11 @@ dir24_8_rcu_qsbr_add(struct dir24_8_tbl *dp, struct rte_fib_rcu_config *cfg,
dp->dq = rte_rcu_qsbr_dq_create(¶ms);
if (dp->dq == NULL) {
FIB_LOG(ERR, "LPM defer queue creation failed");
- return 1;
+ return -rte_errno;
}
- } else {
- rte_errno = EINVAL;
- return 1;
- }
+ } else
+ return -EINVAL;
+
dp->rcu_mode = cfg->mode;
dp->v = cfg->v;
diff --git a/lib/fib/rte_fib.h b/lib/fib/rte_fib.h
index 9732ace2e4..c49b02ab11 100644
--- a/lib/fib/rte_fib.h
+++ b/lib/fib/rte_fib.h
@@ -266,10 +266,10 @@ rte_fib_select_lookup(struct rte_fib *fib, enum rte_fib_lookup_type type);
* @param cfg
* RCU QSBR configuration
* @return
- * On success - 0
- * On error - 1 with error code set in rte_errno.
- * Possible rte_errno codes are:
- * - EINVAL - invalid pointer
+ * 0 on success
+ * Negative otherwise
+ * Possible error codes are:
+ * - EINVAL - invalid parameters
* - EEXIST - already added QSBR
* - ENOMEM - memory allocation failure
* - ENOTSUP - not supported by configured dataplane algorithm
--
2.43.0
next reply other threads:[~2024-10-15 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 17:11 Vladimir Medvedkin [this message]
2024-10-16 5:29 ` Stephen Hemminger
2024-10-16 9:28 ` David Marchand
2024-10-16 15:59 ` Medvedkin, Vladimir
2024-10-16 17:11 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015171143.497709-1-vladimir.medvedkin@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).