From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F94245A78; Tue, 15 Oct 2024 20:35:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B653C40669; Tue, 15 Oct 2024 20:34:52 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by mails.dpdk.org (Postfix) with ESMTP id A825D402DE for ; Tue, 15 Oct 2024 20:34:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VqCSW0d+kSrv7NtIXBoVsDRXxdiV+rZDrBwBqtSCx6zHlN67fewEqMRX3a4jeYAFl1fSTlTAyscEWWeChAwCDqmJktHfiTkqDiT8mP9fec5kll1+c+JQ7J09bmDmHIyWUNbbsHqwEmW1eZxN2Jf5Q3YKWKENPe8/FbN84riUDed1av3yE5xfxOP1f9kzRXVJqSEcKe6PbrJ7q3XiKlUhU0MQ7oZRL2RA9GBZBgmFXbX01T2qgxQBZ+Kcpgh/KdDUV7YgHTr+ErHS66cpVuQc8S8k57zAmSRUSwikczUsYKrwQgWXPek1co/NvNn9an1XcDjnalRANE8Rf8VoLYWEiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU2CUVQ48uviCkDwDc6kGHFFFa3aXbLJlMB9Nm11VcM=; b=OivXrSL/E1PpUpeUnRrDYa52sNb9pvJ/wehiJMJuz9x/sXh1tFqjfKIvhX5J5p57AoIUcXeNKBXXZ+ZITBKZjZRLJspVSYWYsenA/C7Vp/oBdm3Vb3usqUfu5EYRIoE6i2QngqdvgXOuVgNdo7xQRy+M6FcBz1wLDOjfDMe4n1HSe8E4aPqBQAltt6/GQDZ7O+9CuRet/IPBxfQrt/Dq7PFTSlzUbEFCxN8r8zFtd+TIMnozh8icrlH6RzIigPLbwmLYb1DMJ6kgaGRRo+KyPCKudeJA4FzY18rDG3fu5de/G7/PByxB5EaYStFhe4z6k+VXpj5Q8hV67RrN9KVNRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tU2CUVQ48uviCkDwDc6kGHFFFa3aXbLJlMB9Nm11VcM=; b=nm7MvivrmYNp+QiEyoAb3iiqK5EwOFnjMv/ldC5y4i8XWsGvCb8UPCuGlYfQU5r6MepotFAiZWVR1yVjjARdRYz12YseApLwOeLpYp5IBbE62B2f4Kj99N2dA0TLxgMiiK5z0upNaOyHzjm5LxZ/anWVdzk3MBZ1ejJ2uODfBwZIRoUdEwW3o2hosdUgzjeL3i9i7QYKwmr70x/+KUBOM7hKXXQJvUClBwAqAlFgdktukELnVE457BI5hzbzs9OECtvmZJJyomilYpVmIlFwnnBnRB//x8YST7PHAmks1CMCRTTsyalh9VLRxk5KaEjEk4LceEIZomu32vHZynLYQQ== Received: from AM0PR08CA0034.eurprd08.prod.outlook.com (2603:10a6:208:d2::47) by AM8PR07MB7556.eurprd07.prod.outlook.com (2603:10a6:20b:242::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Tue, 15 Oct 2024 18:34:42 +0000 Received: from AMS0EPF000001A3.eurprd05.prod.outlook.com (2603:10a6:208:d2:cafe::b5) by AM0PR08CA0034.outlook.office365.com (2603:10a6:208:d2::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27 via Frontend Transport; Tue, 15 Oct 2024 18:34:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AMS0EPF000001A3.mail.protection.outlook.com (10.167.16.228) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Tue, 15 Oct 2024 18:34:42 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.68) with Microsoft SMTP Server id 15.2.1544.11; Tue, 15 Oct 2024 20:34:41 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id 66A911C0070; Tue, 15 Oct 2024 20:34:41 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: Jerin Jacob CC: , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , David Marchand , "Stephen Hemminger" , Anoob Joseph , Hemant Agrawal , Sachin Saxena , Abdullah Sevincer , Pavan Nikhilesh , Shijith Thotton , Harry van Haaren , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [RFC v2 10/10] eventdev: remove single event enqueue and dequeue Date: Tue, 15 Oct 2024 20:25:35 +0200 Message-ID: <20241015182535.825098-11-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241015182535.825098-1-mattias.ronnblom@ericsson.com> References: <20241015084943.823983-2-mattias.ronnblom@ericsson.com> <20241015182535.825098-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001A3:EE_|AM8PR07MB7556:EE_ X-MS-Office365-Filtering-Correlation-Id: b7fe370a-3b83-41ed-9bc2-08dced480948 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ckJpdXpBYkZ4UXhuQmZ4QlJJQkNZVGs3MlRnbDNtS1FFTGpRNWV6QWRWTEFF?= =?utf-8?B?Rk8zdWlyR1NqWjkyWFFuRGpCczZxajdPZHV5ZzZxNE9zUmJla3ZwQXZlRFZ1?= =?utf-8?B?OEZPR0gvNzhHVDJDd0QrczRpZHBvcWV5bE1VMG5CYWI2TmRKMUUya016aHB0?= =?utf-8?B?K21lQnBFV0NkVzIxTTZLVVY1UlZFZjNnWlJmT3RFY0F1TjQ5WXQxT3JGdHdJ?= =?utf-8?B?YW80UWp6dkE3eUZmOG9abGFhQnc1Y3NWZllQRnVmbnM3MTNINzFLK2tuRGk1?= =?utf-8?B?ZUdXcFBGR3Y2cmhaYzFDakVNNzVtbEtGMGZSMmwxMWpqTkZpRHpxSWF4Qkhq?= =?utf-8?B?RmlZQVhRVndLNktSUWYwU0pDQmsrWWt5T2o2bWhwU0hteGhMOElXdXRtbUR1?= =?utf-8?B?QzVHNHdIQUlDNlJsai9OQ29MNW00ZDc2Ly9tUHhJdHV4c0haU3ZlRXBRQnVl?= =?utf-8?B?K0d2ckdnS014eEpDNXFyeUVHWmNya05ZS2JubjVHSzRMdHk3T1dWeXgzNUdS?= =?utf-8?B?ZnNGU0xZaXdXclowc2o1N0pyZEI5Zmk2Q2YrbHpoeWQ5ZEUrNzI3R2hXeDM3?= =?utf-8?B?eW0wZzlTSTFVa2dXNDNDMEJVSHZ3QmZqQ1JHaWpmaDJ1ZmtqdW9SS1IzMEUz?= =?utf-8?B?ZkF1S09NcmxjcDhsUDkvb3hjS3UzM3M0NGpIMkFYY0hDYVNEV2lFT2J6STZV?= =?utf-8?B?TjlQdTJLSWluMEtBTTlSaHkvYUV4Z3Bmd2dWc3NwWDFxVGNaUEo0bFdVTDQv?= =?utf-8?B?RE9GRVpyUExLMG54bnRsYVdCOXU0NFhXZlhiVEd5UGhPcVRsQnhFMG92R0xi?= =?utf-8?B?TUZKQWRVZUtjUno3QW8wOHkvVEc1Snc4YzZET0tzeFRPTWlhT3dqUk9FR004?= =?utf-8?B?Zk1PTEN3cStqcEZMcTN3THlpOWc2WE1NbVZvaTRKUkNJckNURnk4MzZLVUc5?= =?utf-8?B?Yk5qMThGYndRSTBFV081b2hheFJHcEVUOEgyQTVpS3RKbmFVdTBRZW5Bb0dK?= =?utf-8?B?Q3dGU2xQWG5XdU8waHVlQUM2aGpFYkhMRU5PWlZpM241eExZRnI2Tnp5Vlcw?= =?utf-8?B?RCtxY0Fva01vSXN6czZYMTJDQnh6R0dERVBEbUxRQjVZN0dGWk1hNW5SczFU?= =?utf-8?B?TExlR2l6QUtTMi9pYTZGRGorOWltNUJCREptaWVtdmpEem5jRTA4YUNMSFlX?= =?utf-8?B?UHVQUHFxNVEvdWNHZnk4MFZraXRoNTRkVXJKUS96d0lUYS81b0hYSWgwbzMx?= =?utf-8?B?Mnd6Vldic0k2ZUlKQlFJSzVXTUlsQ0M2aEhoVE9PR2ZXTVltOWE4ajd0QjM1?= =?utf-8?B?TFJzZldVMDJkTGc2WkJHVFRTSngydFl2STZZMkJGNGpGYkl4YU42RXYwSGpi?= =?utf-8?B?eUNrdWRpMGtGa1RiTnlwRUJwbFVZeUgxUGJ3MUhSTW0zYkxBdk05UnRiRGtq?= =?utf-8?B?VkZPMmNDYlhvVElGRXlxRDRRcjBOVG1JUlhuRzIxTUgyZkM3R0RZbUtVWTE2?= =?utf-8?B?dTQ4OTFpZWF4eUVhQUQwK2JGdm1nUVVLL0psQkh6MVoxVHhRMnFNam9oVEFs?= =?utf-8?B?Wlk1YXRGZ1NwV2Y1M1hiSW1mQVQ4SkRMZjUrYTR5RFZmTjg3dTlOYmRwUy9G?= =?utf-8?B?dDFlTjJoR0JuVGYwSE5DNHgwWU90eWtja09Jb3VJcGdCR1RMMEwwNGl4S01M?= =?utf-8?B?eml2eElFNzBmRC9VMnA4cFR1eEJIL29XY0lFWFZmbXNpdW5IOHk2Rnc0ekxu?= =?utf-8?B?TzF4NDZwdC9DZnZiL0hBTDhKa0JidC9rZEpFWDZrQ3VxUHlEdmdpUWNhY0xG?= =?utf-8?B?VTc3UTVtc2k5d0YrVnZDTUEyeXZiajJTaDVxbWVFR1RrVXQwK2xLRkxIWVNP?= =?utf-8?Q?wUVdZ8ZTskIV5?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7416014); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 18:34:42.8480 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7fe370a-3b83-41ed-9bc2-08dced480948 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A3.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB7556 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove the single event enqueue and dequeue, since they did not provide any noticable performance benefits. This is a change of the ABI, previously announced as a deprecation notice. These functions were not directly called by the application, so the API remains unaffected. Signed-off-by: Mattias Rönnblom --- doc/guides/rel_notes/deprecation.rst | 6 +----- lib/eventdev/eventdev_pmd.h | 4 ---- lib/eventdev/eventdev_private.c | 22 ---------------------- lib/eventdev/rte_eventdev.h | 21 ++++----------------- lib/eventdev/rte_eventdev_core.h | 4 ---- 5 files changed, 5 insertions(+), 52 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 7bc2310bc4..6a6fd54444 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -173,11 +173,7 @@ Deprecation Notices * eventdev: The single-event (non-burst) enqueue and dequeue operations, used by static inline burst enqueue and dequeue functions in ``rte_eventdev.h``, - will be removed in DPDK 23.11. - This simplification includes changing the layout and potentially also - the size of the public ``rte_event_fp_ops`` struct, breaking the ABI. - Since these functions are not called directly by the application, - the API remains unaffected. + are removed in DPDK 24.11. * pipeline: The pipeline library legacy API (functions rte_pipeline_*) will be deprecated and subsequently removed in DPDK 24.11 release. diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h index af855e3467..36148f8d86 100644 --- a/lib/eventdev/eventdev_pmd.h +++ b/lib/eventdev/eventdev_pmd.h @@ -158,16 +158,12 @@ struct __rte_cache_aligned rte_eventdev { uint8_t attached : 1; /**< Flag indicating the device is attached */ - event_enqueue_t enqueue; - /**< Pointer to PMD enqueue function. */ event_enqueue_burst_t enqueue_burst; /**< Pointer to PMD enqueue burst function. */ event_enqueue_burst_t enqueue_new_burst; /**< Pointer to PMD enqueue burst function(op new variant) */ event_enqueue_burst_t enqueue_forward_burst; /**< Pointer to PMD enqueue burst function(op forward variant) */ - event_dequeue_t dequeue; - /**< Pointer to PMD dequeue function. */ event_dequeue_burst_t dequeue_burst; /**< Pointer to PMD dequeue burst function. */ event_maintain_t maintain; diff --git a/lib/eventdev/eventdev_private.c b/lib/eventdev/eventdev_private.c index b628f4a69e..6df129fc2d 100644 --- a/lib/eventdev/eventdev_private.c +++ b/lib/eventdev/eventdev_private.c @@ -5,15 +5,6 @@ #include "eventdev_pmd.h" #include "rte_eventdev.h" -static uint16_t -dummy_event_enqueue(__rte_unused void *port, - __rte_unused const struct rte_event *ev) -{ - RTE_EDEV_LOG_ERR( - "event enqueue requested for unconfigured event device"); - return 0; -} - static uint16_t dummy_event_enqueue_burst(__rte_unused void *port, __rte_unused const struct rte_event ev[], @@ -24,15 +15,6 @@ dummy_event_enqueue_burst(__rte_unused void *port, return 0; } -static uint16_t -dummy_event_dequeue(__rte_unused void *port, __rte_unused struct rte_event *ev, - __rte_unused uint64_t timeout_ticks) -{ - RTE_EDEV_LOG_ERR( - "event dequeue requested for unconfigured event device"); - return 0; -} - static uint16_t dummy_event_dequeue_burst(__rte_unused void *port, __rte_unused struct rte_event ev[], @@ -129,11 +111,9 @@ event_dev_fp_ops_reset(struct rte_event_fp_ops *fp_op) { static void *dummy_data[RTE_MAX_QUEUES_PER_PORT]; static const struct rte_event_fp_ops dummy = { - .enqueue = dummy_event_enqueue, .enqueue_burst = dummy_event_enqueue_burst, .enqueue_new_burst = dummy_event_enqueue_burst, .enqueue_forward_burst = dummy_event_enqueue_burst, - .dequeue = dummy_event_dequeue, .dequeue_burst = dummy_event_dequeue_burst, .maintain = dummy_event_maintain, .txa_enqueue = dummy_event_tx_adapter_enqueue, @@ -153,11 +133,9 @@ void event_dev_fp_ops_set(struct rte_event_fp_ops *fp_op, const struct rte_eventdev *dev) { - fp_op->enqueue = dev->enqueue; fp_op->enqueue_burst = dev->enqueue_burst; fp_op->enqueue_new_burst = dev->enqueue_new_burst; fp_op->enqueue_forward_burst = dev->enqueue_forward_burst; - fp_op->dequeue = dev->dequeue; fp_op->dequeue_burst = dev->dequeue_burst; fp_op->maintain = dev->maintain; fp_op->txa_enqueue = dev->txa_enqueue; diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index b5c3c16dd0..fabd1490db 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -2596,14 +2596,8 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id, } #endif rte_eventdev_trace_enq_burst(dev_id, port_id, ev, nb_events, (void *)fn); - /* - * Allow zero cost non burst mode routine invocation if application - * requests nb_events as const one - */ - if (nb_events == 1) - return (fp_ops->enqueue)(port, ev); - else - return fn(port, ev, nb_events); + + return fn(port, ev, nb_events); } /** @@ -2852,15 +2846,8 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, struct rte_event ev[], } #endif rte_eventdev_trace_deq_burst(dev_id, port_id, ev, nb_events); - /* - * Allow zero cost non burst mode routine invocation if application - * requests nb_events as const one - */ - if (nb_events == 1) - return (fp_ops->dequeue)(port, ev, timeout_ticks); - else - return (fp_ops->dequeue_burst)(port, ev, nb_events, - timeout_ticks); + + return (fp_ops->dequeue_burst)(port, ev, nb_events, timeout_ticks); } #define RTE_EVENT_DEV_MAINT_OP_FLUSH (1 << 0) diff --git a/lib/eventdev/rte_eventdev_core.h b/lib/eventdev/rte_eventdev_core.h index 2706d5e6c8..78b06d1f2e 100644 --- a/lib/eventdev/rte_eventdev_core.h +++ b/lib/eventdev/rte_eventdev_core.h @@ -60,16 +60,12 @@ typedef void (*event_preschedule_t)(void *port, struct __rte_cache_aligned rte_event_fp_ops { void **data; /**< points to array of internal port data pointers */ - event_enqueue_t enqueue; - /**< PMD enqueue function. */ event_enqueue_burst_t enqueue_burst; /**< PMD enqueue burst function. */ event_enqueue_burst_t enqueue_new_burst; /**< PMD enqueue burst new function. */ event_enqueue_burst_t enqueue_forward_burst; /**< PMD enqueue burst fwd function. */ - event_dequeue_t dequeue; - /**< PMD dequeue function. */ event_dequeue_burst_t dequeue_burst; /**< PMD dequeue burst function. */ event_maintain_t maintain; -- 2.43.0