From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH] fib: fix return value behavior
Date: Tue, 15 Oct 2024 22:29:38 -0700 [thread overview]
Message-ID: <20241015222938.359f7193@hermes.local> (raw)
In-Reply-To: <20241015171143.497709-1-vladimir.medvedkin@intel.com>
On Tue, 15 Oct 2024 17:11:43 +0000
Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:
> Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its
> return value to align with the existing rte_fib API.
>
> Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation")
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
Looks good, although DPDK often uses rte_errno, it is better for this part
in fib to be consistent across rcu and non-rcu variants.
PS: there don't seem to be any negative tests on this function in test_fib.c
would be good to hit some of the basics.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2024-10-16 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 17:11 Vladimir Medvedkin
2024-10-16 5:29 ` Stephen Hemminger [this message]
2024-10-16 9:28 ` David Marchand
2024-10-16 15:59 ` Medvedkin, Vladimir
2024-10-16 17:11 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015222938.359f7193@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).