From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42EF045B4A; Wed, 16 Oct 2024 07:29:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDDD14021F; Wed, 16 Oct 2024 07:29:43 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id D18F0400D6 for ; Wed, 16 Oct 2024 07:29:41 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20cb89a4e4cso28965785ad.3 for ; Tue, 15 Oct 2024 22:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729056581; x=1729661381; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7v6O6pHw5znE3XWDfX1b/XxuBzNCLT/9WTHvJ7XkIvw=; b=fzWxpQob6kcV9ZdLRS5bF3bjWhPnQ+Igp/kqVh26PnLKi4jH0t38Mp6OV8zXCjEtcS cp3fShUQZRGMD8+Zb+XVCPrKoaiKR6HUbd+HODWuC7wYzJJ716c5skdMFfWHPqIcZNdM h9clX0FnCx2ccIS7LSLD7mi6EU66nEOch08cgPlWrAzzVfxhv3APkIPVPwfAmN912gRN IsHwUOSn3XDmfBaXYIVqa/hsWVuvLf/4Fe6tJ1wPTr2gzdO4uK/1DX1UgFUptBtoA2lG rF407r2CMb6cDb0AyfHPWmQezffG9//yJ/h5/yVGRuKfsbZUVxqYbzjpwsjjPG1LYI+x UGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729056581; x=1729661381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7v6O6pHw5znE3XWDfX1b/XxuBzNCLT/9WTHvJ7XkIvw=; b=X/tVmIuvDUK1LtK1+NMBQvblWTTxWY494bg/iNnN/uCDUer3VufOrZFBTI4QDbHVxd eoulHCUkifNpx+0vRoY+LCd79Wra0LCrYktQ2fA0z4gdh13fMSYBr1OnYWcso9gSnm5F 1vpdzpuG7wl0OXEcSVDx9XNGY5MQGHNvp6xjKBhOoMA4Vw81Eh7RM0s90DrF3zpRUINl PStp7gm0rFzQiVLqvOACAQ6a8xQHMrQfII/G2ynrfMswStPxiYRlIQhIGUbb7rxiZkE4 zV1KrsF1/U7ekjOOpYOCLrHosVjs0E+9aTdc/WGbTBPG/lx2NHu2pipL3zT8YBclLWwN pvcg== X-Gm-Message-State: AOJu0YyFJxQJkQSUImQj6HE73xG/OLyRkTxRrFwtMnt0xv7q0bmD3XQa D58fkb3n+xgatB1u2DUiC67Tg1JBpeOlSQYKJeqb9IJGutFCtVCAw2c9g58BVsU= X-Google-Smtp-Source: AGHT+IGGigiE6g7/NLRYj7xPAPbXDIRuCLOsDDEhevAcRJT9/TcpjjQLwXzzExRRZqV08j8yAvHsvw== X-Received: by 2002:a17:902:db07:b0:20c:8df8:5066 with SMTP id d9443c01a7336-20d27f0d106mr40344175ad.45.1729056580782; Tue, 15 Oct 2024 22:29:40 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d180361c1sm21332675ad.169.2024.10.15.22.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 22:29:40 -0700 (PDT) Date: Tue, 15 Oct 2024 22:29:38 -0700 From: Stephen Hemminger To: Vladimir Medvedkin Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH] fib: fix return value behavior Message-ID: <20241015222938.359f7193@hermes.local> In-Reply-To: <20241015171143.497709-1-vladimir.medvedkin@intel.com> References: <20241015171143.497709-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 15 Oct 2024 17:11:43 +0000 Vladimir Medvedkin wrote: > Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its > return value to align with the existing rte_fib API. > > Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation") > > Signed-off-by: Vladimir Medvedkin > --- Looks good, although DPDK often uses rte_errno, it is better for this part in fib to be consistent across rcu and non-rcu variants. PS: there don't seem to be any negative tests on this function in test_fib.c would be good to hit some of the basics. Reviewed-by: Stephen Hemminger