From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7083E45B51; Wed, 16 Oct 2024 17:02:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02AA740150; Wed, 16 Oct 2024 17:02:46 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 609CD400D6 for ; Wed, 16 Oct 2024 17:02:45 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-71e6d988ecfso2398395b3a.0 for ; Wed, 16 Oct 2024 08:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729090964; x=1729695764; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=VNTl3SWA2WJQ/S+1ieH1SiSyWib9NxVj/p5odZjqe/4=; b=CobyjNYcp6F8sOmeiN1ZK1lkwHkpcVxyz6XOZcA6zHbIv1a6Ib35lCTi7tR7SLHzkg kDmkc/YvTmL993ncTatzmr9PabUwR4Xeg2i8mwikgBaVcawOLLcgSxqzgEZN0GzXB255 JVvR4ezLDjF+Puk2P4jNpOCwp4I+Jbw8BIvAWH8fs22HOEDbH7rYzYI7vDWfUvJIbYUk FgVzjOinVRS2mJuDLXqtyovYXs5TR3jD3KnGcBcgFxNEX3bIRwbJ2AF90tGuSoAWmnSp YnC62f+FxDXYVm6OvohhEiStPSZsy3y7l3vR0rQQt8GDYLZ2zK9hDS2wRzia86CBtrlZ d3Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729090964; x=1729695764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VNTl3SWA2WJQ/S+1ieH1SiSyWib9NxVj/p5odZjqe/4=; b=gpdeZTplSzL6AohJFuQWrAsbGRUR5+km0QxpG+bkf/wWD2tgOLPv/S1/sokHXciEbW VlDp9qYyFOJ96ka7oJKAiBXLsKqdcjxWBQWaSAD2B0ttEwTSwZSJBWQsf9uiejUrFlus kSCG2dcCZJakM4jxkgvX5tuhutm9x6dGm78v9Tg0KmkY9DatnI8oS1D3ZxReYIcUT9XR CpGBiXdxUiK5LgwEInmf5aJmQ9PasFtM7u69Onq4PzCyb0jjLITNDSpcjHWFq0uhxYUV aVCjUFwvAnCasftiBVDmE+eFFU6Um1l96tRqeuWf1lXkuHhnUWD+UIIHi2OEEAH9aZdF 4WHQ== X-Gm-Message-State: AOJu0YzdVgb1w1sc9RDg+DJyajBf7nfX9oTmPWz51lhayRaMZdv3w+al QRHFrDeiBxs60eKQv6P/X/ZdqhVrT4ed4E+tBxlJnLpuze2YbDRHZL665Wm7jAg= X-Google-Smtp-Source: AGHT+IGhjZ1RyiBHTd3N9Hal2m123uKFwKDHskgmMAvUfbG1KrXOIcucjcCstS7dtqMdJuBWSSFFKQ== X-Received: by 2002:a05:6a00:c8e:b0:71e:44f6:6904 with SMTP id d2e1a72fcca58-71e44f66cbcmr24147683b3a.13.1729090964296; Wed, 16 Oct 2024 08:02:44 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e77509e15sm3166698b3a.195.2024.10.16.08.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 08:02:44 -0700 (PDT) Date: Wed, 16 Oct 2024 08:02:42 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu Subject: Re: [PATCH] examples/l3fwd: support setting the data size of mbuf Message-ID: <20241016080242.12c75c2c@hermes.local> In-Reply-To: <20241016082232.4005800-1-chaoyong.he@corigine.com> References: <20241016082232.4005800-1-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 16 Oct 2024 16:22:32 +0800 Chaoyong He wrote: > From: Long Wu > > The previous code used a macro as the data size for mbuf > to create the mempool and users cannot modify the size. > > Now modify the code to support setting the data size of > mbuf by '--mbuf-size' parameter. If user does not add the > parameter in start command line, the default size is still > 'RTE_MBUF_DEFAULT_BUF_SIZE'. > > Examples: > dpdk-l3fwd -l 0-3 -- -p 0x03 --mbuf-size=4096 > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He Why not automatically determine the mbuf size based on mtu? Would be more natural. L3fwd functions as a test program and often used as a starting point for best practices for doing new applications.