From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A74245B4D; Wed, 16 Oct 2024 13:38:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 160C140264; Wed, 16 Oct 2024 13:38:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 135C7400D5 for ; Wed, 16 Oct 2024 13:38:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729078718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1TkLIlAhh71V1/+NEixuw6LZLUZch5617yw7TJzj+7k=; b=TrWdK16/dTik9QwbKR7j8C4pfw2trhoiTPt68Gyc7kgpKOIkZjaVUKcv1Gmw6a40DsD5e/ G11548yxnQ9+HE2FbOIV/Z9ABJ2Vge/zEKA6MXxhfI6xlhMtHDBsO0BHay1bc2Kq1cV5tO oAj7hI/G1fC48mPPxnhNnhh2gwrXXSY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-At88xpC-MqyJN_qgJngYoQ-1; Wed, 16 Oct 2024 07:38:33 -0400 X-MC-Unique: At88xpC-MqyJN_qgJngYoQ-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 444461955F45; Wed, 16 Oct 2024 11:38:32 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.57]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 63DF1300018D; Wed, 16 Oct 2024 11:38:30 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com Subject: [PATCH v2 0/4] Enhance headers check Date: Wed, 16 Oct 2024 13:38:12 +0200 Message-ID: <20241016113817.3956187-1-david.marchand@redhat.com> In-Reply-To: <20241015121046.2556695-1-david.marchand@redhat.com> References: <20241015121046.2556695-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org We currently check that exported headers are fine with -DALLOW_EXPERIMENTAL_API and -DALLOW_INTERNAL_API. Such a check won't catch issues like the one fixed in patch 1, where OVS compilation is broken by the additional of experimental API in a header commonly included in other parts of DPDK. Ideally, I would like to merge patch 1 in rc1. The patch 2 is not a real issue (more like the enhanced check would complain about this header). In any case, I think it would not hurt merging everything now. Comments, please. -- David Marchand Changes since v1: - fixed additional issue in vDPA header, raised by CI, David Marchand (4): bitops: fix build for GCC without experimental API bitset: fix build for GCC without experimental API vhost: remove internal vDPA API description from public header buildtools/chkincs: check headers with stable API only buildtools/chkincs/meson.build | 27 +++++++- lib/eal/include/rte_bitops.h | 6 ++ lib/eal/include/rte_bitset.h | 123 +++++++++++++++++++++++++++++++++ lib/vhost/rte_vdpa.h | 17 ----- 4 files changed, 154 insertions(+), 19 deletions(-) -- 2.46.2