From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>
Cc: "Mattias Rönnblom" <hofors@lysator.liu.se>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: [PATCH 2/2] devtools: forbid the use of ffs compiler builtins
Date: Wed, 16 Oct 2024 15:54:11 +0200 [thread overview]
Message-ID: <20241016135411.827850-2-mattias.ronnblom@ericsson.com> (raw)
In-Reply-To: <20241016135411.827850-1-mattias.ronnblom@ericsson.com>
Extend checkpatches.sh to detect the use of __builtin_(ffs|ffsll).
These intrinsics are not available in MSVC, and there are perfectly
serviceable alternatives in <rte_bitops.h>.
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Suggested-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index c23792025a..411c40d275 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -179,7 +179,7 @@ check_forbidden_additions() { # <patch>
# forbid use of non abstracted bit count operations
awk -v FOLDERS="lib drivers app examples" \
- -v EXPRESSIONS='\\<__builtin_(clz|clzll|ctz|ctzll|popcount|popcountll)\\>' \
+ -v EXPRESSIONS='\\<__builtin_(clz|clzll|ctz|ctzll|popcount|popcountll|ffs|ffsll)\\>' \
-v RET_ON_FAIL=1 \
-v MESSAGE='Using __builtin helpers for bit count operations' \
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
--
2.43.0
next prev parent reply other threads:[~2024-10-16 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 13:54 [PATCH 1/2] bitset: discontinue the use of GCC builtin Mattias Rönnblom
2024-10-16 13:54 ` Mattias Rönnblom [this message]
2024-10-16 15:04 ` [PATCH 2/2] devtools: forbid the use of ffs compiler builtins Stephen Hemminger
2024-10-16 15:32 ` David Marchand
2024-10-16 15:39 ` Stephen Hemminger
2024-10-16 20:55 ` David Marchand
2024-10-17 5:50 ` Mattias Rönnblom
2024-10-16 15:19 ` [PATCH 1/2] bitset: discontinue the use of GCC builtin David Marchand
2024-10-16 20:55 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016135411.827850-2-mattias.ronnblom@ericsson.com \
--to=mattias.ronnblom@ericsson.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).