DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nicholas Pratte <npratte@iol.unh.edu>
To: dmarx@iol.unh.edu, probb@iol.unh.edu, luca.vizzarro@arm.com,
	Honnappa.Nagarahalli@arm.com, yoan.picchi@foss.arm.com,
	paul.szczepanek@arm.com
Cc: dev@dpdk.org, Nicholas Pratte <npratte@iol.unh.edu>
Subject: [PATCH v9 2/3] dts: add capability check for multicast filtering
Date: Wed, 16 Oct 2024 13:13:06 -0400	[thread overview]
Message-ID: <20241016171307.18635-3-npratte@iol.unh.edu> (raw)
In-Reply-To: <20241016171307.18635-1-npratte@iol.unh.edu>

The multicast address filter component of the mac filter test suite
is definitively supported across all vendors. Thus, a simple capability
check is added to ensure that this functionality is supported.

Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
---
 dts/framework/remote_session/testpmd_shell.py | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index 6beec66e43..f350568b70 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -2086,6 +2086,27 @@ def get_capabilities_show_port_info(
             self.ports[0].device_capabilities,
         )
 
+    def get_capabilities_mcast_filtering(
+        self,
+        supported_capabilities: MutableSet["NicCapability"],
+        unsupported_capabilities: MutableSet["NicCapability"],
+    ) -> None:
+        """Get multicast filtering capability from mcast_addr add and check for testpmd error code.
+
+        Args:
+            supported_capabilities: Supported capabilities will be added to this set.
+            unsupported_capabilities: Unsupported capabilities will be added to this set.
+        """
+        self._logger.debug("Getting mcast filter capabilities.")
+        command = f"mcast_addr add {self.ports[0].id} 01:00:5E:00:00:00"
+        output = self.send_command(command)
+        if "diag=-95" in output:
+            unsupported_capabilities.add(NicCapability.MCAST_FILTERING)
+        else:
+            supported_capabilities.add(NicCapability.MCAST_FILTERING)
+            command = str.replace(command, "add", "remove", 1)
+            self.send_command(command)
+
 
 class NicCapability(NoAliasEnum):
     """A mapping between capability names and the associated :class:`TestPmdShell` methods.
@@ -2217,6 +2238,10 @@ class NicCapability(NoAliasEnum):
     FLOW_SHARED_OBJECT_KEEP: TestPmdShellCapabilityMethod = functools.partial(
         TestPmdShell.get_capabilities_show_port_info
     )
+    #: Device supports multicast address filtering.
+    MCAST_FILTERING: TestPmdShellCapabilityMethod = functools.partial(
+        TestPmdShell.get_capabilities_mcast_filtering
+    )
 
     def __call__(
         self,
-- 
2.44.0


  parent reply	other threads:[~2024-10-16 17:14 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 19:24 [PATCH v2 0/3] Mac Filter Port to New DTS Nicholas Pratte
2024-07-02 19:24 ` [PATCH v2 1/3] dts: add boolean to adjust addresses Nicholas Pratte
2024-07-11 19:31   ` Jeremy Spewock
2024-07-17 17:19     ` Nicholas Pratte
2024-07-19 15:37     ` Jeremy Spewock
2024-07-22 13:09   ` Dean Marx
2024-07-02 19:24 ` [PATCH v2 2/3] dts: add testpmd methods for test suite Nicholas Pratte
2024-07-11 19:33   ` Jeremy Spewock
2024-07-17 19:57     ` Nicholas Pratte
2024-07-02 19:24 ` [PATCH v2 3/3] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-07-11 19:34   ` Jeremy Spewock
2024-07-18 19:05 ` [PATCH v3 0/3] Mac Filter Port to New DTS Nicholas Pratte
2024-07-18 19:05   ` [PATCH v3 1/3] dts: add boolean to adjust addresses Nicholas Pratte
2024-07-18 19:05   ` [PATCH v3 2/3] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-07-19 15:37     ` Jeremy Spewock
2024-07-22 13:08     ` Dean Marx
2024-07-18 19:40   ` [PATCH v3 3/3] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-07-19 15:38     ` Jeremy Spewock
2024-07-22 13:08     ` Dean Marx
2024-07-26 16:39 ` [PATCH v4 0/2] Mac Filter Port to New DTS Nicholas Pratte
2024-07-26 16:45   ` [PATCH v4 1/2] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-08-02 20:26     ` Jeremy Spewock
2024-08-12 18:58     ` Dean Marx
2024-09-09 18:29     ` Dean Marx
2024-07-26 16:46   ` [PATCH v4 2/2] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-08-02 20:25     ` Jeremy Spewock
2024-08-02 20:27       ` Jeremy Spewock
2024-08-12 18:47     ` Dean Marx
2024-09-04 21:14     ` Dean Marx
2024-09-05 19:11       ` Nicholas Pratte
2024-09-09 18:28     ` Dean Marx
2024-07-26 16:39 ` [PATCH v4 1/2] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-08-02 20:02   ` Jeremy Spewock
2024-07-26 16:39 ` [PATCH v4 2/2] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-08-02 20:02   ` Jeremy Spewock
2024-09-12 19:00 ` [PATCH v5 0/2] Mac Filter Port to New DTS Nicholas Pratte
2024-09-12 19:00   ` [PATCH v5 1/2] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-09-12 19:00   ` [PATCH v5 2/2] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-10-08 20:45 ` [PATCH v6 0/2] Mac Filter Port to New DTS Nicholas Pratte
2024-10-08 20:45   ` [PATCH v6 1/2] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-10-09 22:54     ` Patrick Robb
2024-10-09 22:59     ` Patrick Robb
2024-10-08 20:45   ` [PATCH v6 2/2] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-10-09 22:43     ` Patrick Robb
2024-10-09 22:55   ` [PATCH v6 0/2] Mac Filter Port to New DTS Patrick Robb
2024-10-10 19:21 ` [PATCH v7 0/2] dts: mac filter port to new dts Nicholas Pratte
2024-10-10 19:21   ` [PATCH v7 1/2] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-10-10 19:21   ` [PATCH v7 2/2] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-10-10 20:11 ` [PATCH v8 0/2] dts: mac filter port to " Nicholas Pratte
2024-10-10 20:11   ` [PATCH v8 1/2] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-10-10 20:11   ` [PATCH v8 2/2] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-10-16 17:13 ` [PATCH v9 0/3] dts: mac filter port to " Nicholas Pratte
2024-10-16 17:13   ` [PATCH v9 1/3] dts: add methods for setting mac and multicast addresses Nicholas Pratte
2024-11-14 23:11     ` Patrick Robb
2024-10-16 17:13   ` Nicholas Pratte [this message]
2024-11-14 23:10     ` [PATCH v9 2/3] dts: add capability check for multicast filtering Patrick Robb
2024-10-16 17:13   ` [PATCH v9 3/3] dts: mac filter test suite refactored for new dts Nicholas Pratte
2024-11-14 23:10     ` Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016171307.18635-3-npratte@iol.unh.edu \
    --to=npratte@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).