From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 806F245B53; Thu, 17 Oct 2024 05:20:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C9DD4021F; Thu, 17 Oct 2024 05:20:22 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 04E2A40144 for ; Thu, 17 Oct 2024 05:20:19 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20ca388d242so3397455ad.2 for ; Wed, 16 Oct 2024 20:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729135219; x=1729740019; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=II5epCqV4YZtDUCitH0cJk9XzYfAmlMTNRm5PK+bjjo=; b=NbTOu2fdrBVzW4blDBbu7r1TP/Ik6z8MC1YcoOKUgRR0jIPIBMnGazzIzNRXRr4k/e z/wargUh8HZN1+I1AmKblzeBRgyk9+qXzApc9aR0Uk2E6jt049xxPfsbMI3y5AFK7Kt6 u/v3pktxmbphTAan+ju2GXxD6sqv+aeXg3K62A1twvs85pea1DtQO89vJBqMTSZRCPGx 3g6ADOlLOUZ47ub9I0onh3zn0NOAR3YRzyRVt3+kRjc5SuRLkhu1RIc6oLQ4hn+0dv0D kbLbMoo0eNGXRocY6gfV2TP8xvPRLhAezMPA1rAildmMX98zvjEVAwx1X0M8WArwH2iq anjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729135219; x=1729740019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=II5epCqV4YZtDUCitH0cJk9XzYfAmlMTNRm5PK+bjjo=; b=YyJ2PV77XuoZqDg4QdgzRxuJr9NqnucXAbznPMZc0eeHeqFxMw14fvakV5AeKR1cBR snSgJrbpvC7wawhNI5Go37mlzVeUFMfGy3FPipZzgvDU+SQo2wjsKQnOAleZMrxQ6x89 hnc/0ASqCfx5nd5ZgHAZIajBFWcGcmonz8FRV4ddNArZK2XTUZP4Uhhg9Aox4Y6F/rnb frahqKsLBKjR+pFlW2qCpi4HYQYxaXrqwLCyf6RF9PoWlXpVCi7KJxTlHV/I/szpQ8rs GAGXoarYZsfpaHiR//2bVuHWH2rVLpR08dIQTVgtE47Tw4qRYucSu07qra7Sy+jOmLhd uKig== X-Gm-Message-State: AOJu0Yx5zlDNA8A+dsRA6CMV5dVCBTnpwq5Sg6kKkAbziphxhIvE7gRv WB/gyiql2rIDEW+X3QqgMLSKfKnV4mRWJp4zKvPzTkJb48neLF3TVngNkM58gxs= X-Google-Smtp-Source: AGHT+IFNvkkg1bE6929ojcnK+0TgnvdQ2Sh0BukgbQoQ1GGMNo4JQYOtk/GTdtyDcmQs6q6tv6o+AA== X-Received: by 2002:a17:903:2447:b0:20c:7ae1:92cb with SMTP id d9443c01a7336-20cbb195f8fmr282252725ad.15.1729135219068; Wed, 16 Oct 2024 20:20:19 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d180365fbsm35253345ad.127.2024.10.16.20.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 20:20:18 -0700 (PDT) Date: Wed, 16 Oct 2024 20:20:16 -0700 From: Stephen Hemminger To: "lihuisong (C)" Cc: , , , , , , , , , , "konstantin.ananyev@huawei.com" Subject: Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide Message-ID: <20241016202016.14182322@hermes.local> In-Reply-To: <87ebf2dd-dc08-c32c-5a30-c6712a62b9b6@huawei.com> References: <20240320105529.5626-1-lihuisong@huawei.com> <20240912023812.30885-1-lihuisong@huawei.com> <20240912023812.30885-2-lihuisong@huawei.com> <20241012181030.60d7647a@hermes.local> <39734c23-0f65-1bae-bb4e-2c6bf06aa97c@huawei.com> <20241015084555.3f9f7669@hermes.local> <87ebf2dd-dc08-c32c-5a30-c6712a62b9b6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 10:11:13 +0800 "lihuisong (C)" wrote: > Hi Stephen, >=20 > =E5=9C=A8 2024/10/15 23:45, Stephen Hemminger =E5=86=99=E9=81=93: > > On Tue, 15 Oct 2024 17:41:39 +0800 > > "lihuisong (C)" wrote: > > =20 > >> Hi Stephen, > >> > >> Can you take a look at this reply so as to send out the next version A= SAP? > >> Thanks.=F0=9F=98=81 > >> > >> /Huisong > >> =E5=9C=A8 2024/10/14 20:19, lihuisong (C) =E5=86=99=E9=81=93: =20 > > The biggest issue is that lcore is not the same as cpu as far as kernel= is concerned. > > DPDK support mapping lcore to a cpuset, and that is not necessarily the= same one-to-one mapping > > as values in sysfs. In documentation of eal see. =20 > Yes, you are right. > > > > For example, "--lcores=3D'1,2@(5-7),(3-5)@(0,2),(0,6),7-8'" which means= start 9 EAL thread; > > lcore 0 runs on cpuset 0x41 (cpu 0,6); > > lcore 1 runs on cpuset 0x2 (cpu 1); > > lcore 2 runs on cpuset 0xe0 (cpu 5,6,7); > > lcore 3,4,5 runs on cpuset 0x5 (cpu 0,2); > > lcore 6 runs on cpuset 0x41 (cpu 0,6); > > lcore 7 runs on cpuset 0x80 (cpu 7); > > lcore 8 runs on cpuset 0x100 (cpu 8). > > > > This problem existed in power library and this new API still has it. =20 > How about use lcore_config[lcore_id].cpuset to get the real cpu_id? > And for this case that application use '--lcores', we simply do some=20 > operations in power lib for all mapping CPUs in lcore's cpuset. > If it is ok, I will fix it for the entire power library and this new API. > > Using the lcore_config is the right direction but the cpuset may have more = than one cpu, so the code needs to iterate over those cpus. Probably safe to ig= nore problems the case where user misconfigures to have two lcores using an overlapping s= et of cpu's like the example in the doc.