From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F11645B56; Wed, 16 Oct 2024 22:24:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F80740670; Wed, 16 Oct 2024 22:24:05 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 52CC44064E for ; Wed, 16 Oct 2024 22:24:01 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20cb7139d9dso1964025ad.1 for ; Wed, 16 Oct 2024 13:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729110240; x=1729715040; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=b8Ytv7ZE88H/j4qYlDMr+mjKFxLt/nAnQDMZWBtLTqDbKFP+SgFsevYo2lke31v/qE c/F+zKxmjYk/7IEJ0Wqyox52mKj41a9++m0wnn8Od/lt2A0IL5jOmRYdoxGF30oswMwS 5N2gLB5Gb7b4F8IV0YFelwdKFldlF0tANnDXm8j3SQ4MRt6JIIzeZKd00IUDPq92cPQK IT6T/tBJSQuXUtQgHnPuSLvShKyJFDrmemex8x/c3wm2HdSl7JAfMT9h0qDCc+9FEScy 7+aQqi8PV4jG6Bp4DY4QEoE+OhSkylmfrKS7fi76nozNwPcgwznK7exxL7JAcLsJWReV 97Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729110240; x=1729715040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=Yll0bXvxagmVqUwskGFnZxrJ6n5HsIo2z+jD86awKptoXiwf8K1b1RPeW4FDs7jQGx GhuL4NRKZxg0pDSp8HVG8uq7iNPdGiwmL4pyToLfVqx6vkIEmCT8AI5Ul95DcGaf0lCH 2wdHPhspGj5UcL5Vz/+ukj9HBlscHjBuUMsM/5uwTF1zeOR7x9twJS6B+yajgT2RzRzP imkvACd9iqk8QwrJu7+ow8CFIpg7NvcM4ha6QFnEVJrHzs3v/ws5Hkbg5vwcgfglkUoc IhrA3uKCt2LxF9NDbplimokZZPM3Q+qjrgNDtAq+vvRfJBOOHEobKNEBfGEhFzkLApsi L5Gg== X-Gm-Message-State: AOJu0YyFU8+938yNHxfzhY+8JYnplrz1UmrruoTXKhedBCTLAiSVRKBo nlRFuhIHxyALD1lFewPtbHsqJEUlOIKjmsJBDyg4ecLaeL0ZMSJPuNfnmQfGbfcinkllMWNa5cr F X-Google-Smtp-Source: AGHT+IHn+Clp/LBCWJjSmQZ9JB+mhgc2yoAsV/BwO52a9vMtD66ot2BWOzFSVfyYJVD47uc43JRI1Q== X-Received: by 2002:a17:903:228b:b0:20b:bad4:5b6e with SMTP id d9443c01a7336-20d27f0cf15mr67169225ad.38.1729110240499; Wed, 16 Oct 2024 13:24:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d180361e5sm32308825ad.120.2024.10.16.13.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 13:24:00 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v26 06/15] eal: change rte_exit() output to match rte_log() Date: Wed, 16 Oct 2024 13:20:33 -0700 Message-ID: <20241016202343.190653-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241016202343.190653-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241016202343.190653-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with code: 1 [ 0.006250] EAL: Cannot init EAL: Permission denied Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 3e77995896..bcfcd6df6f 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -36,15 +36,13 @@ rte_exit(int exit_code, const char *format, ...) va_list ap; if (exit_code != 0) - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" - " Cause: ", exit_code); + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); va_start(ap, format); rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) - EAL_LOG(CRIT, - "EAL could not release all resources"); + EAL_LOG(CRIT, "EAL could not release all resources"); exit(exit_code); } -- 2.45.2