DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Zerun Fu <zerun.fu@corigine.com>,
	Chaoyong He <chaoyong.he@corigine.com>,
	Long Wu <long.wu@corigine.com>,
	Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 2/6] net/nfp: modify the level of speed update log
Date: Thu, 17 Oct 2024 14:15:43 +0800	[thread overview]
Message-ID: <20241017061547.4068520-3-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20241017061547.4068520-1-chaoyong.he@corigine.com>

From: Zerun Fu <zerun.fu@corigine.com>

Here the invoke of `nfp_eth_read_ports()` may fail, but it's acceptable
because it will recover soon once the link status changed.

So modify the level of the log to avoid confusing users.

Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_net_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index de7140db0a..70531bc337 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -779,7 +779,7 @@ nfp_net_pf_speed_update(struct rte_eth_dev *dev,
 	if (pf_dev->speed_updated || aneg == NFP_ANEG_AUTO) {
 		nfp_eth_table = nfp_eth_read_ports(pf_dev->cpp);
 		if (nfp_eth_table == NULL) {
-			PMD_DRV_LOG(WARNING, "Failed to update port speed.");
+			PMD_DRV_LOG(DEBUG, "Failed to get nfp_eth_table.");
 		} else {
 			pf_dev->nfp_eth_table->ports[idx] = nfp_eth_table->ports[idx];
 			free(nfp_eth_table);
-- 
2.39.1


  parent reply	other threads:[~2024-10-17  6:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  6:15 [PATCH 0/6] Adjust format and level of log Chaoyong He
2024-10-17  6:15 ` [PATCH 1/6] net/nfp: modify the level of some logs Chaoyong He
2024-10-17  6:15 ` Chaoyong He [this message]
2024-10-17  6:15 ` [PATCH 3/6] net/nfp: reformat the header of logs Chaoyong He
2024-10-17  6:15 ` [PATCH 4/6] net/nfp: reformat the abbreviations " Chaoyong He
2024-10-17  6:15 ` [PATCH 5/6] net/nfp: reformat the period " Chaoyong He
2024-10-17  6:15 ` [PATCH 6/6] net/nfp: correct of misspellings Chaoyong He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017061547.4068520-3-chaoyong.he@corigine.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=zerun.fu@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).