From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Zerun Fu <zerun.fu@corigine.com>,
Chaoyong He <chaoyong.he@corigine.com>,
Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 4/6] net/nfp: reformat the abbreviations of logs
Date: Thu, 17 Oct 2024 14:15:45 +0800 [thread overview]
Message-ID: <20241017061547.4068520-5-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20241017061547.4068520-1-chaoyong.he@corigine.com>
From: Zerun Fu <zerun.fu@corigine.com>
Unified do not apply abbreviations in log.
Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/flower/nfp_flower.c | 2 +-
drivers/net/nfp/flower/nfp_flower_flow.c | 8 ++++----
drivers/net/nfp/nfp_ethdev.c | 16 ++++++++--------
drivers/net/nfp/nfp_mtr.c | 2 +-
drivers/net/nfp/nfp_net_common.c | 6 +++---
drivers/net/nfp/nfp_net_flow.c | 2 +-
drivers/net/nfp/nfpcore/nfp_cppcore.c | 4 ++--
drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +-
8 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c
index 7c612e471a..d38b077c09 100644
--- a/drivers/net/nfp/flower/nfp_flower.c
+++ b/drivers/net/nfp/flower/nfp_flower.c
@@ -703,7 +703,7 @@ nfp_init_app_fw_flower(struct nfp_net_hw_priv *hw_priv)
ext_features = nfp_rtsym_read_le(pf_dev->sym_tbl, "_abi_flower_extra_features",
&err);
if (err != 0) {
- PMD_INIT_LOG(ERR, "Couldn't read extra features from fw");
+ PMD_INIT_LOG(ERR, "Could not read extra features from fw");
ret = -EIO;
goto pf_cpp_area_cleanup;
}
diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c
index b605bced3a..e65b47e007 100644
--- a/drivers/net/nfp/flower/nfp_flower_flow.c
+++ b/drivers/net/nfp/flower/nfp_flower_flow.c
@@ -517,7 +517,7 @@ nfp_flow_table_delete_merge(struct nfp_flow_priv *priv,
flow_find = nfp_flow_table_search(priv, nfp_flow);
if (flow_find == NULL) {
- PMD_DRV_LOG(ERR, "Can't delete a non-existing flow.");
+ PMD_DRV_LOG(ERR, "Can not delete a non-existing flow.");
return -EINVAL;
}
@@ -1485,7 +1485,7 @@ nfp_flow_action_check_modify(struct nfp_action_calculate_param *param)
dst_width = nfp_flow_field_width(dst_data->field, 0);
src_width = nfp_flow_field_width(src_data->field, dst_width);
if (width > dst_width || width > src_width) {
- PMD_DRV_LOG(ERR, "Cannot modify more bits than the width of a field");
+ PMD_DRV_LOG(ERR, "Can not modify more bits than the width of a field");
return -EINVAL;
}
@@ -3499,7 +3499,7 @@ nfp_flower_del_tun_neigh(struct nfp_app_fw_flower *app_fw_flower,
}
if (!flag) {
- PMD_DRV_LOG(DEBUG, "Can't find nn entry in the nn list");
+ PMD_DRV_LOG(DEBUG, "Can not find nn entry in the nn list");
return -EINVAL;
}
@@ -4156,7 +4156,7 @@ nfp_flow_action_meter(struct nfp_flower_representor *representor,
}
if (!mtr->shared && mtr->ref_cnt > 0) {
- PMD_DRV_LOG(ERR, "Can't use a used unshared meter");
+ PMD_DRV_LOG(ERR, "Can not use a used unshared meter");
return -EINVAL;
}
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 1f9b191c7c..2b55076a18 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -418,7 +418,7 @@ nfp_net_start(struct rte_eth_dev *dev)
/* Checking MTU set */
if (dev->data->mtu > net_hw->flbufsz) {
- PMD_INIT_LOG(ERR, "MTU (%u) can't be larger than the current NFP_FRAME_SIZE (%u)",
+ PMD_INIT_LOG(ERR, "MTU (%u) can not be larger than the current NFP_FRAME_SIZE (%u)",
dev->data->mtu, net_hw->flbufsz);
return -ERANGE;
}
@@ -1709,7 +1709,7 @@ nfp_fw_setup(struct nfp_pf_dev *pf_dev,
if (policy != NFP_NSP_APP_FW_LOAD_FLASH) {
err = nfp_fw_get_name(pf_dev, fw_name, sizeof(fw_name));
if (err != 0) {
- PMD_DRV_LOG(ERR, "Can't find suitable firmware.");
+ PMD_DRV_LOG(ERR, "Can not find suitable firmware.");
goto close_nsp;
}
}
@@ -1798,7 +1798,7 @@ nfp_enable_multi_pf(struct nfp_pf_dev *pf_dev)
cap_extend = nn_cfg_readl(hw, NFP_NET_CFG_CAP_WORD1);
if ((cap_extend & NFP_NET_CFG_CTRL_MULTI_PF) == 0) {
- PMD_INIT_LOG(ERR, "Loaded firmware doesn't support multiple PF");
+ PMD_INIT_LOG(ERR, "Loaded firmware does not support multiple PF");
err = -EINVAL;
goto end;
}
@@ -2070,7 +2070,7 @@ nfp_net_speed_cap_get_one(struct nfp_pf_dev *pf_dev,
nsp = nfp_nsp_open(pf_dev->cpp);
if (nsp == NULL) {
- PMD_DRV_LOG(ERR, "Couldn't get NSP.");
+ PMD_DRV_LOG(ERR, "Could not get NSP.");
return -EIO;
}
@@ -2350,7 +2350,7 @@ nfp_pf_init(struct rte_pci_device *pci_dev)
snprintf(name, sizeof(name), "nfp_pf%u", function_id);
pf_dev = rte_zmalloc(name, sizeof(*pf_dev), 0);
if (pf_dev == NULL) {
- PMD_INIT_LOG(ERR, "Can't allocate memory for the PF device");
+ PMD_INIT_LOG(ERR, "Can not allocate memory for the PF device");
ret = -ENOMEM;
goto hw_priv_free;
}
@@ -2459,7 +2459,7 @@ nfp_pf_init(struct rte_pci_device *pci_dev)
snprintf(app_name, sizeof(app_name), "_pf%u_net_app_id", function_id);
app_fw_id = nfp_rtsym_read_le(sym_tbl, app_name, &ret);
if (ret != 0) {
- PMD_INIT_LOG(ERR, "Couldn't read %s from firmware", app_name);
+ PMD_INIT_LOG(ERR, "Could not read %s from firmware", app_name);
ret = -EIO;
goto sym_tbl_cleanup;
}
@@ -2704,7 +2704,7 @@ nfp_pf_secondary_init(struct rte_pci_device *pci_dev)
snprintf(name, sizeof(name), "nfp_pf%d", 0);
pf_dev = rte_zmalloc(name, sizeof(*pf_dev), 0);
if (pf_dev == NULL) {
- PMD_INIT_LOG(ERR, "Can't allocate memory for the PF device");
+ PMD_INIT_LOG(ERR, "Can not allocate memory for the PF device");
ret = -ENOMEM;
goto hw_priv_free;
}
@@ -2764,7 +2764,7 @@ nfp_pf_secondary_init(struct rte_pci_device *pci_dev)
snprintf(app_name, sizeof(app_name), "_pf%u_net_app_id", function_id);
app_fw_id = nfp_rtsym_read_le(sym_tbl, app_name, &ret);
if (ret != 0) {
- PMD_INIT_LOG(ERR, "Couldn't read %s from fw", app_name);
+ PMD_INIT_LOG(ERR, "Could not read %s from fw", app_name);
ret = -EIO;
goto sym_tbl_cleanup;
}
diff --git a/drivers/net/nfp/nfp_mtr.c b/drivers/net/nfp/nfp_mtr.c
index 2370349534..ae7f9558be 100644
--- a/drivers/net/nfp/nfp_mtr.c
+++ b/drivers/net/nfp/nfp_mtr.c
@@ -861,7 +861,7 @@ nfp_mtr_disable(struct rte_eth_dev *dev,
if (mtr->ref_cnt > 0) {
return -rte_mtr_error_set(error, EINVAL,
RTE_MTR_ERROR_TYPE_MTR_ID,
- NULL, "Can't disable a used meter");
+ NULL, "Can not disable a used meter");
}
mtr->enable = false;
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 9f06536dfc..7a37b9c2aa 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -1777,7 +1777,7 @@ nfp_net_rss_reta_write(struct rte_eth_dev *dev,
if (reta_size != NFP_NET_CFG_RSS_ITBL_SZ) {
PMD_DRV_LOG(ERR, "The size of hash lookup table configured (%hu)"
- " doesn't match hardware can supported (%d)",
+ " does not match hardware can supported (%d)",
reta_size, NFP_NET_CFG_RSS_ITBL_SZ);
return -EINVAL;
}
@@ -1869,7 +1869,7 @@ nfp_net_reta_query(struct rte_eth_dev *dev,
if (reta_size != NFP_NET_CFG_RSS_ITBL_SZ) {
PMD_DRV_LOG(ERR, "The size of hash lookup table configured (%d)"
- " doesn't match hardware can supported (%d)",
+ " does not match hardware can supported (%d)",
reta_size, NFP_NET_CFG_RSS_ITBL_SZ);
return -EINVAL;
}
@@ -2194,7 +2194,7 @@ nfp_net_check_dma_mask(struct nfp_pf_dev *pf_dev,
{
if (pf_dev->ver.extend == NFP_NET_CFG_VERSION_DP_NFD3 &&
rte_mem_check_dma_mask(40) != 0) {
- PMD_DRV_LOG(ERR, "Device %s can't be used: restricted dma mask to 40 bits!",
+ PMD_DRV_LOG(ERR, "Device %s can not be used: restricted dma mask to 40 bits!",
name);
return -ENODEV;
}
diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c
index 430eca1c7a..a5d1362001 100644
--- a/drivers/net/nfp/nfp_net_flow.c
+++ b/drivers/net/nfp/nfp_net_flow.c
@@ -210,7 +210,7 @@ nfp_net_flow_calculate_items(const struct rte_flow_item items[],
*item_type = RTE_FLOW_ITEM_TYPE_IPV6;
return 0;
default:
- PMD_DRV_LOG(ERR, "Can't calculate match length");
+ PMD_DRV_LOG(ERR, "Can not calculate match length");
*match_len = 0;
return -ENOTSUP;
}
diff --git a/drivers/net/nfp/nfpcore/nfp_cppcore.c b/drivers/net/nfp/nfpcore/nfp_cppcore.c
index 0e6045f2f0..06996b7bc8 100644
--- a/drivers/net/nfp/nfpcore/nfp_cppcore.c
+++ b/drivers/net/nfp/nfpcore/nfp_cppcore.c
@@ -967,7 +967,7 @@ nfp_cpp_alloc(struct rte_pci_device *pci_dev,
xpb_addr = 0x000a0000 + (target * 4);
err = nfp_xpb_readl(cpp, xpb_addr, &cpp->imb_cat_table[target]);
if (err < 0) {
- PMD_DRV_LOG(ERR, "Can't read CPP mapping from device");
+ PMD_DRV_LOG(ERR, "Can not read CPP mapping from device");
free(cpp);
return NULL;
}
@@ -975,7 +975,7 @@ nfp_cpp_alloc(struct rte_pci_device *pci_dev,
err = nfp_cpp_set_mu_locality_lsb(cpp);
if (err < 0) {
- PMD_DRV_LOG(ERR, "Can't calculate MU locality bit offset");
+ PMD_DRV_LOG(ERR, "Can not calculate MU locality bit offset");
free(cpp);
return NULL;
}
diff --git a/drivers/net/nfp/nfpcore/nfp_nsp.c b/drivers/net/nfp/nfpcore/nfp_nsp.c
index f9480b24c1..a2f4f70081 100644
--- a/drivers/net/nfp/nfpcore/nfp_nsp.c
+++ b/drivers/net/nfp/nfpcore/nfp_nsp.c
@@ -210,7 +210,7 @@ nfp_nsp_check(struct nfp_nsp *state)
}
if (FIELD_GET(NSP_STATUS_MAGIC, reg) != NSP_MAGIC) {
- PMD_DRV_LOG(ERR, "Cannot detect NFP Service Processor");
+ PMD_DRV_LOG(ERR, "Can not detect NFP Service Processor");
return -ENODEV;
}
--
2.39.1
next prev parent reply other threads:[~2024-10-17 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 6:15 [PATCH 0/6] Adjust format and level of log Chaoyong He
2024-10-17 6:15 ` [PATCH 1/6] net/nfp: modify the level of some logs Chaoyong He
2024-10-17 6:15 ` [PATCH 2/6] net/nfp: modify the level of speed update log Chaoyong He
2024-10-17 6:15 ` [PATCH 3/6] net/nfp: reformat the header of logs Chaoyong He
2024-10-17 6:15 ` Chaoyong He [this message]
2024-10-17 6:15 ` [PATCH 5/6] net/nfp: reformat the period " Chaoyong He
2024-10-17 6:15 ` [PATCH 6/6] net/nfp: correct of misspellings Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017061547.4068520-5-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=zerun.fu@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).