From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 575A845B5A; Thu, 17 Oct 2024 09:36:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2919540279; Thu, 17 Oct 2024 09:36:54 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2104.outbound.protection.outlook.com [40.107.101.104]) by mails.dpdk.org (Postfix) with ESMTP id AB60F40261; Thu, 17 Oct 2024 09:36:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dl+NhwB6m9fXk1dG0i9i9OylAT04Sjrz1igJULcOTIKh6ebaxVucmWa/VQZdLcdKUji4m+vPdHrD3FliQtgfHbSw09oWmJ6GPegsQ8u+BNXsSQ2oSeDFfhwSArjELoZRJCTLFU2iwy8Nx6eRPTQLYumQzvc6TEikswvAv+QJhw+HExVtblNP+UECd0CK0buVrSCNDynZcDMIpbzfJUtBAmR0v3dzbm1QaLXyHHPfT6jLz57rH5zHn+08HzX4rAHK+Ns7UwQ7oPD1MumT/S2Ankg09jvr9KqdJqisI1ju4BZZORkezQXn0OdCMDmtwoADq45NU5WxipSyi88usMLmKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HVO1hVMPXUFw9H6hKhYfJutEt0yUbenzmvPzS+Js0n0=; b=HPtwkC22dbk7bloAYJmrGwDmhWYrEss2gjSdwy3tuKW69IrNEpcDyI6EwzG4u7VLvNvL2NYm7BDSK2rIFWAaSbyIxvFZthOcs6I3+xG3pswOwZ/Cdd8phM3B7bAnYxuGm6RAbERbcALamPw/QIWfCY/WAZ4MBLEOSU+v8YV16S5KYRTeLDWgYvMnWaRq2AvN+o5JYEM+t5yrDBQ8efCFW+S3cUe4dk1MsVwqD/oo1Ipk3KnsgeSjNW5i2Ga9HMQLygNeYw2qalotP1xVWaxwQ1S89qZy6LRHxoWrK7i8V9L7d0CuY9MFU+GNSo1DJZ1q5sWvSK1iXruuYEfAqwlF+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HVO1hVMPXUFw9H6hKhYfJutEt0yUbenzmvPzS+Js0n0=; b=XVGbE9Loyjg0ADMRrZexPjeeAdLvNQ+onx7bhmwWKvqjuRbHhePBGtTdcyBSwEk8LHBM0Y+g6YdBC+OMZQdygkphSSbAM4lZWXhJ1tfW89va3QR5+YLMrSxInRll4cdzmZQo8o1p4OoSrYNTcH8+8m39Pky1yOVzJKKslLtyDm4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) by SA0PR13MB3997.namprd13.prod.outlook.com (2603:10b6:806:9b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Thu, 17 Oct 2024 07:36:49 +0000 Received: from PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::277d:5013:95a1:d8b9]) by PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::277d:5013:95a1:d8b9%3]) with mapi id 15.20.8069.016; Thu, 17 Oct 2024 07:36:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Peng Zhang Subject: [PATCH] net/nfp: fix return value check problem Date: Thu, 17 Oct 2024 15:36:29 +0800 Message-Id: <20241017073629.4071562-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG2PR06CA0241.apcprd06.prod.outlook.com (2603:1096:4:ac::25) To PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB5568:EE_|SA0PR13MB3997:EE_ X-MS-Office365-Filtering-Correlation-Id: 0add99f3-9176-4aec-fa10-08dcee7e75c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tmgIWV/TCX9C9DGu9lVTNsrDPqO1+ukFSVjfvDfOpMnPS9NlhOudpbhJXZTS?= =?us-ascii?Q?/Pk2WI/GQ7eImD/GWRVPdB5s2KuEeS6f+6CiVnMRXWMrfMsWJaDoIsZKfW0Q?= =?us-ascii?Q?nRf9OdDUsLsCIJk8tNvNRR2dSiLaG0h0xXCTRm3EI/PWXtMhPF80L7bz/l0X?= =?us-ascii?Q?D1sXfv68suCZyk9OzvxzJSmZkKYPRkZGR0sw9HCo1T0As+4DB9WYHWXvsY0J?= =?us-ascii?Q?jp75WhG5CCwEtIx4Xh5ltm1FceNXq3LpVJWyIe30RzEiOjdt40mG8hghpbQi?= =?us-ascii?Q?Q6UrIj9DxkDXnzOXNzsQ/5Q/A2X/RJbGrbJBH9qFgQ8fo8nMDirVhJuKuTy0?= =?us-ascii?Q?WapKqtQfUuRgmDRp+yrm71KQFh3WV1zSLBy0kvkT61y7r4YE3fnl6FUBnhVt?= =?us-ascii?Q?bMV3+mrdwTv3JA/fjQkrrwxtPWhtKLJR9fn/k8bco26d8NxNDgVh7u69qhX2?= =?us-ascii?Q?U2vLJ0np1eTeK+O5v+33BUhCQabFLCR8IAfWRjhS5zCKomG3Kl5cxR5yhzl3?= =?us-ascii?Q?aDUGYFqTdiqkJ97c0J6P2k4KWtkFfH6P1nbJ4GOCzDIpdu8ZAmyTI9AV0VXh?= =?us-ascii?Q?jTGgnQky7NSqBUMHJ58jvcRMtaxO+6zUZn/PWexZ/7fIUXq23RH4Q9zs8d6C?= =?us-ascii?Q?ING71gd3qd+lMqhTrRnL6AVsI3Z8/93PxCwCJ8aD1oz1z7hiAREmmb+X55e3?= =?us-ascii?Q?J5E2MX9lxOjYoGObKRyzIK+xSjsjQzAr/g8Jjkk5vzaLd579lAw+UFQHiSEY?= =?us-ascii?Q?YoGPXwhftUhUfUjrDU+bMBoHb8eka1DeE/qlxA5M7JQ8o/+ouf2+mFbtKtvN?= =?us-ascii?Q?t28mkKNi5OIMcdaP9+i0Ffg0tcw5XsGzliRd13QV+AI4soOlromaGreAgqJ0?= =?us-ascii?Q?tAZudlu/hmoBSBhKQ6rsiiXx4+KsAteL5cnEA2dbT7B9hChbquiHm8Bh351k?= =?us-ascii?Q?BNZnVl8jEU+lAVKgmWugjYhOgxFnYOOUHmeoZezosofcuWAixtpzaApNdWI5?= =?us-ascii?Q?201M2qjxBiKeVbWIzjBWNo/9IKwX818VaZx7E5jEFpjlNEbbErlO4mqHRjjn?= =?us-ascii?Q?oZUmxS2yGxLxV4hX15+JlKm8sWYCscPpXOf3MP8BvTt+oJIn2EW8dVa1WB/O?= =?us-ascii?Q?lhEFO2YSvX5AmCjn0eY/luT3dc8Zo7Bps+aK3TeITa7s0i/LCR/Y8NgyYxpF?= =?us-ascii?Q?3yCelOTROlokZ2RQ/f02an+Tb3bHRACjb1KJGgUq3uCzyKeCXSUbkcKBR3CJ?= =?us-ascii?Q?siQZPzOCQ95RWawIOdcSbSBlOzxSnnpOM+J/i6hRXil2gzK+etaKSUWSikmc?= =?us-ascii?Q?pGdvVAx0Ei5H5DQ3zgdquIVi2SuAlHctp5fhuJRZlJ5u5KM/fsdz3DtuqSkQ?= =?us-ascii?Q?8ujQdyQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR13MB5568.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WkP+DAGnkuTD1b0hX3espaIHMccrZ7mG7gzrES2VruLdeD/chrvhLSRsYHJg?= =?us-ascii?Q?ywL4k3UAklRHBE3rgc+Ky4COIO7zpaBmL3aeeM8VVLw2JXWlKSuseRxxCT1g?= =?us-ascii?Q?yvZMVQRDF/475cZVWupwaGWErH/VNx3d4bxxPIPX1qc/fpsqdDguVBcZ32lJ?= =?us-ascii?Q?tfNVZxRuo71Xl59gd4s8Vd4dSFXgs9NfykqV318snUTLuE0USRs+j+3GQ/Vj?= =?us-ascii?Q?JQIOwEx5JV5ExiI7iDSrglgZVeQEM5rv9yManIRPN4tYAPrmVhIH327Pyf0G?= =?us-ascii?Q?Tu5whRnY63KjAmGV3Vbq0+wRslLxh4+FXCv/MilzY5eaI2AMcYT4xiIIdkGb?= =?us-ascii?Q?HgkqMKyASAQy+EALFX54yLeOot7cQ5heSgObrHa8vDOExt4THm8sfSxNms4+?= =?us-ascii?Q?v1lROZv+8LfkqYz6HQfrpfqm65AN7nemGt53DTjP1lqOLtsUZH8MYGpxq/xn?= =?us-ascii?Q?3RX+BLTEf5Kubu6yWm1EG0vb+bsUSc+UrM1DH9pfalR2NlAlgMv5m5epe4Yk?= =?us-ascii?Q?LS+o6KCD00So5zrp66BFlNtWQajvg2ct1OV0Qs5ns4v+oyGDqTSybUUUvoFd?= =?us-ascii?Q?ZZ+uoxFVLfaMbfg6ILb3tJqU1XOlJT/B7qdE+eB10rrKsmvwOCl2z3/NU0TG?= =?us-ascii?Q?nIJn20iZ3CYdL0upySEg3iWHeQs1x3TJOdTRAmqoY0lu+rPwOnCwMVPWHYu6?= =?us-ascii?Q?41bsEkYXGrE0/mOPF/InNpCsp/x231/HOxJr4sbrpr5ouuk7TQDwjfYRmqvv?= =?us-ascii?Q?Po6z769QCFUJlL5E2pakEmUVAa5x7FaxFQewcqKNJxVosnM4AQGwhClyvExr?= =?us-ascii?Q?EKBVxDpEwN+TKKXLhDsZqD+J8MuYqBANaJbNSRXPbJkgDXVTRWV3SG0QyINE?= =?us-ascii?Q?RfZXVcYC6KDOXC3cCY2mmpMu1ogHHIROl9bWEgccbxvoWrIPyJ3Rg9Wo+rCy?= =?us-ascii?Q?3J3DJdqNjRL51gConQt1CkOMQWjgaK1n1ttwVDlBfuYajWl7jsmZ2v6u5mEH?= =?us-ascii?Q?x2r/6Z/o2iyci2ZRL2M0RqqZ0Yno+91nUM113MFgjkF+jU5DSYSWK1vZNN0B?= =?us-ascii?Q?woBTSZN5iaGKR0rwk1SZGUlmD4OGngeT4vsPROs+dJ5SJFCrtIfYFe7aXJYG?= =?us-ascii?Q?GjWQus/lWlu+mr1wwUE3Gd8evmW/YXsuqSHib/JBgFxGWwf53C2fMf/OA3vW?= =?us-ascii?Q?FQKCtyxmf1ewF3atcXFQfQACbSp1jWVHro69uY8eGDXR2MnzQaIA1WtsenyG?= =?us-ascii?Q?g949EUy6k+Y4CXRkpza+MeNRRjupNfpJDN1u1QLe10q/Q7eAvSj6LmHgqz99?= =?us-ascii?Q?ebyNmsxDD9POy/rEyHDi8kmp4Wih5MezXQqZPpDzSBGgkPCZFdGazmbE6dll?= =?us-ascii?Q?6mPKTr8+Fq+uCPv71h1EBHtS66v0LYMVQqAh1kvLdy8Og8+JDVXa6Mh0+5tN?= =?us-ascii?Q?nfGEHA71tpbVTIDlGNIPbLy0SyAcffcLcYltospyWHb4lhg9Ns0qGCKrMsvd?= =?us-ascii?Q?Xk2QL6p54wgeyi/3m6hUnXxP5i5Zm2bH8z9IbUtCxHHV51+a+u9kGnOI9ebR?= =?us-ascii?Q?5Rwanl8y6zUkUvL8jRuRQSlBv5M1F13rWpC9K/t8NqVTyn6h7nn8EVfpYDD3?= =?us-ascii?Q?tg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0add99f3-9176-4aec-fa10-08dcee7e75c5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2024 07:36:49.2488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J6/wx6j33+t0PRxtKuqkondc1Ie0f3qRYSFJkipVfbnsI9YRaEkz36bl4A5g8209/uor//45Qam0FskYWMJsj1Acqml/iKvKuSNM0OGoir0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR13MB3997 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix one return value check problem found by the CI. Coverity issue: 445519 Fixes: 08ea495d624b ("net/nfp: support loading firmware from flash") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index b16fbe7db7..812c48ff4c 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -1807,7 +1807,13 @@ nfp_enable_multi_pf(struct nfp_pf_dev *pf_dev) net_hw.tx_bar = pf_dev->qc_bar + tx_base * NFP_QCP_QUEUE_ADDR_SZ; nfp_net_cfg_queue_setup(&net_hw); rte_spinlock_init(&hw->reconfig_lock); - nfp_ext_reconfig(&net_hw.super, NFP_NET_CFG_CTRL_MULTI_PF, NFP_NET_CFG_UPDATE_GEN); + err = nfp_ext_reconfig(&net_hw.super, NFP_NET_CFG_CTRL_MULTI_PF, + NFP_NET_CFG_UPDATE_GEN); + if (err != 0) { + PMD_INIT_LOG(ERR, "Configure multiple PF failed."); + goto end; + } + end: nfp_cpp_area_release_free(area); return err; -- 2.39.1