From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E82D45B60; Thu, 17 Oct 2024 18:11:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29C614025F; Thu, 17 Oct 2024 18:11:24 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 6841A4021E for ; Thu, 17 Oct 2024 18:11:23 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-20cdda5cfb6so11509425ad.3 for ; Thu, 17 Oct 2024 09:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729181482; x=1729786282; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=l79AzXsfQaUKLCyUKV7X2JDvBAvVpjNNYmmrvSHBqcU=; b=2YrZFC796Z03pf3WUm5dl6cem4keB4cLRKO0+qeYv2BojtJjI2hpxkg/4dzxwrLhtT N3QU5eERlWr02h1Ofn1dJNbFBtsfGfmYe2d7DK51SxAzDWlrOXzKjmXQ7ci0n7u88Ik3 GFlPl2sYJJPPmInUP9/n/HcHHv3vElRAKBdIptGekaJkCSWMln/vqNp1CSYeggbe8pNm WZho/bitVVOG6roxeEvLS3KbKVZ+GrZs1YLYf54cnHtgRReXIkoIMYz8iGTZLwRcasg6 Af+A/6/j124eem3zCRk4PKkdoWv4Xg1T39VO33k3E+uGyYi3zlcT8qStoemmXJgnlw8q nnbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729181482; x=1729786282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l79AzXsfQaUKLCyUKV7X2JDvBAvVpjNNYmmrvSHBqcU=; b=MSfNWPPoA9RsPsmicIzUis5qofkoi42BSdBWRTvGkTI/7jPlZtoGtm/2TVVE2SS3uU vjgGt+mB5bL7yM1ZH8eA3f2lJEhZYwSBzPocKcHSKoyxEeu77oV6nJ5u9/Vnkapd8w5B NOQP3sDdwynmAyjrg7T2iWwc+QfcUpIs7oyVGS4ueW36xPVLEDpozgwNRlQ6kNk6VF7o juvwuoJvYn9bjiBybxPzsY30NY6+gvcAbwAAGuDoeix2nqMWm569K3m41sqaiElEwUWy WTIcolO7N1e1X+MzwQ27X/IdgLAE2OYiaUCQgcsNbGPbtYoC+uxyDM2l5b39zhN7N1z9 mIxA== X-Gm-Message-State: AOJu0Ywdh6u+II2R7lOfI5h02YJzdzJ/2H8jjlVOpfgtI4eVdhgt+t4P ssz/H7u3oY9zY2YGAMGepuaMVi9PebDYROGFbG4HUM/h9XlLKEKa8odBvAbL0/4= X-Google-Smtp-Source: AGHT+IEiYnHsVR4RSjIoaKBOYCdPp8jQpIuahQjzUSGNtpiMWk9J+aPspLYVWx5VyAwmIQgtKWoUtA== X-Received: by 2002:a17:902:db12:b0:20c:5ba1:e8e5 with SMTP id d9443c01a7336-20ca145d515mr329545635ad.19.1729181482348; Thu, 17 Oct 2024 09:11:22 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d1806b5d5sm45779235ad.291.2024.10.17.09.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:11:22 -0700 (PDT) Date: Thu, 17 Oct 2024 09:11:20 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v2 11/18] net/r8169: implement Rx path Message-ID: <20241017091120.679ee0bc@hermes.local> In-Reply-To: <20241017063200.26101-12-howard_wang@realsil.com.cn> References: <20241017063200.26101-1-howard_wang@realsil.com.cn> <20241017063200.26101-12-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 14:31:53 +0800 Howard Wang wrote: > +/* > + * The overhead from MTU to max frame size. > + * Considering VLAN so a tag needs to be counted. > + */ > +#define RTL_ETH_OVERHEAD (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + VLAN_TAG_SIZE) > + > +#define ETH_HLEN 14 > +#define VLAN_HLEN 4 > +#define Jumbo_Frame_9k (9 * 1024 - ETH_HLEN - VLAN_HLEN - RTE_ETHER_CRC_LEN) You might want to consider using the defines in rte_ether.h Also please don't use CamelCase unless it is coming from some other place (ie cloning of headers from base code).