From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E8AB45B60; Thu, 17 Oct 2024 18:17:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C5CB40616; Thu, 17 Oct 2024 18:17:15 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 40D264025F for ; Thu, 17 Oct 2024 18:17:13 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20cbcd71012so10704245ad.3 for ; Thu, 17 Oct 2024 09:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729181832; x=1729786632; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/nHpyLWfD+ANChrcJcO0AHXXES8xxed+IQ8guk0vRSE=; b=lEnRQjGchJNhKgBySmRsczXA3jLdZ5J2BJuhZ90uaJYjO64x5LShfQoPnRvuM0iftn /PS5neHwx7QI2Zex5v4quppmOx2/EgIIrs1GwupghPfcoaoofr1GJoF7FX4NlWUOMTd8 i6bQocCLe+WEh6ST3EyN6sCxC/x7p6dJOamiIQsR34adUZlwl4uQh7y0S+bA3W5ttpZJ wYlvPQdwXA7cUEaZ8RjlAO502TRYIB05T+5g8Hcist6Wxgi60P8ekcx3BhMFmWPIuczZ /l8E/SWtl+pXGb0h4Hk866UzaIXuZbOqcVcWRp9OCgw92Pvh4Lcvz4Qrf6YBTt5m7uvi VMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729181832; x=1729786632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/nHpyLWfD+ANChrcJcO0AHXXES8xxed+IQ8guk0vRSE=; b=eG6/kSRPfroMnYZLDeaWkr/kEU/3CrkW+NAoo+p/xr3+lBCiQPJxm+jYTISt+H4ksL da1Zf/tlVK76NxS/cgCW3k0DC8ikyWuxZQ5iYFtlVBEch26MnW4OqdXznviLCTPY4ltl oU7D6xFcjnDU1+4+iczX8mqjGOXd2I692CoZJl+jJrIPgrLG18ryUURYe0pGM8ddXtEe 2RNK97Xed2KoMDVv2YcEz2FYUyI8Aw6eLAPFxLwZOBaQCcWD8EnyVPkdcVptHH+ijzR9 rgmwGeeSnof8jaBKutnUZiDYI47x2ktyRqQKR8DmoZwVAnLbrqug1Jz6OiwQBihB/Ed+ V9fg== X-Forwarded-Encrypted: i=1; AJvYcCUBV5A3VZc1xIPWPyg7Z7jqfJk0PnL7MuKj8EgL5jC6u3urM15mlmDxaZ3YkpGjqzUsPQk=@dpdk.org X-Gm-Message-State: AOJu0YypFpEz4ybk3/8/agvHr9Nn6yP8cX711WifGKLD8hugsfsXWo3M 48LgbqDlDG6s7wG9Hc2PkK7Nbn74JcF740c41/t8OTG5+xWNiz9byBZWvleWm+g= X-Google-Smtp-Source: AGHT+IG9UY/bLTHB3wwa4w8LscHlI2keyyIwPzv57HcYL1Z3sEofpdDR7QOcbhgfdr2fBS96wGmtoQ== X-Received: by 2002:a17:902:f68d:b0:20c:6f55:2195 with SMTP id d9443c01a7336-20cbb283424mr274641135ad.47.1729181832059; Thu, 17 Oct 2024 09:17:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d18059caasm46039165ad.244.2024.10.17.09.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:17:11 -0700 (PDT) Date: Thu, 17 Oct 2024 09:17:10 -0700 From: Stephen Hemminger To: Sivaprasad Tummala Cc: , , , , , , , , Subject: Re: [PATCH v5 0/5] power: refactor power management library Message-ID: <20241017091710.2036c59c@hermes.local> In-Reply-To: <20241017102650.1041030-1-sivaprasad.tummala@amd.com> References: <20241015024959.3478399-1-sivaprasad.tummala@amd.com> <20241017102650.1041030-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 10:26:44 +0000 Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers/power/uncore/*'. >=20 > This refactor significantly improves code organization, enhances > clarity, and boosts maintainability. It lays the foundation for more > focused development on individual drivers and facilitates seamless > integration of future enhancements, particularly the AMD uncore driver. >=20 > Furthermore, this effort aims to streamline code maintenance by > consolidating common functions for cpufreq and cppc across various > core drivers, thus reducing code duplication. Does not build. *Build Failed #2: OS: RHEL94-64 Target: x86_64-native-linuxapp-gcc FAILED: examples/dpdk-distributor.p/distributor_main.c.o=20 gcc -Iexamples/dpdk-distributor.p -Iexamples -I../examples -Iexamples/distr= ibutor -I../examples/distributor -I../examples/common -I. -I.. -Iconfig -I.= ./config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I.= ./lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ili= b/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../l= ib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telem= etry -I../lib/telemetry -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/= ring -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/= ethdev -Ilib/meter -I../lib/meter -Ilib/cmdline -I../lib/cmdline -Ilib/dist= ributor -I../lib/distributor -Ilib/power -I../lib/power -Ilib/timer -I../li= b/timer -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winval= id-pch -Wextra -Werror -std=3Dc11 -O3 -include rte_config.h -Wcast-qual -Wd= eprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarat= ions -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer= -arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-addr= ess-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializer= s -Wno-zero-length-bounds -D_GNU_SOURCE -march=3Dnative -mrtm -Wno-format-t= runcation -DALLOW_EXPERIMENTAL_API -MD -MQ examples/dpdk-distributor.p/dist= ributor_main.c.o -MF examples/dpdk-distributor.p/distributor_main.c.o.d -o = examples/dpdk-distributor.p/distributor_main.c.o -c ../examples/distributor= /main.c In file included from ../examples/distributor/main.c:20: In function =E2=80=98rte_power_get_capabilities=E2=80=99, inlined from =E2=80=98main=E2=80=99 at ../examples/distributor/main.c:8= 88:4: ../lib/power/rte_power.h:285:42: error: call to =E2=80=98rte_power_get_core= _ops=E2=80=99 declared with attribute error: Symbol is not public ABI 285 | struct rte_power_core_ops *ops =3D rte_power_get_core_ops(); | ^~~~~~~~~~~~~~~~~~~~~~~~ [2962/3118] Compiling C object examples/dpdk-fips_validation.p/fips_validat= ion_fips_validation_hmac.c.o [2963/3118] Compiling C object examples/dpdk-bbdev_app.p/bbdev_app_main.c.o [2964/3118] Compiling C object examples/dpdk-fips_validation.p/fips_validat= ion_fips_validation_xts.c.o [2965/3118] Compiling C object examples/dpdk-fips_validation.p/fips_validat= ion_fips_validation_sha.c.o [2966/3118] Linking target examples/dpdk-bond [2967/3118] Compiling C object examples/dpdk-fips_validation.p/fips_validat= ion_main.c.o [2968/3118] Compiling C object app/dpdk-test.p/test_test_ring_perf.c.o [2969/3118] Compiling C object app/dpdk-test.p/test_test_trace_perf.c.o [2970/3118] Compiling C object app/dpdk-test.p/test_test_ring.c.o ninja: build stopped