From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB17245B60; Thu, 17 Oct 2024 18:21:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFC904025F; Thu, 17 Oct 2024 18:21:51 +0200 (CEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 8809C4021E for ; Thu, 17 Oct 2024 18:21:50 +0200 (CEST) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2e2b549799eso876650a91.3 for ; Thu, 17 Oct 2024 09:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729182110; x=1729786910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lfzd8ox1+iqXoSX3shaQy5MIukUN6RwIVxiOg8yLzEs=; b=1v7uGsAN1VFjY/jIQPXJ79cpCBOkHrd0sfEBvryYNVJLP/+gCq/36V5TOOVrsxqeyk xB3CXIV9X4MU1nvkhD/O78waYYOCjFGIeyss48E7gWc5dwKnLwYBYgDbFWv3kyJ9D7yG FJsK0vuYVG6uskBL8KObYujkWEdbOgf3c0v1rb69JpnwIshrUTbpamg/NGe0oh0Xasim vhkqhH+DDaZWtaF/LLNh48DEZSkvxeAB02D8pi19zdfiIqTrHhUNZ/tW0v0JL8V8hdme t0YBTAz/A2nbG1dFGbmsfnWKTAKPraNQzevhMsb2hiV81hVONIJ7cIZuPt4fZi+HgTjb HmDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729182110; x=1729786910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lfzd8ox1+iqXoSX3shaQy5MIukUN6RwIVxiOg8yLzEs=; b=bzcUsz+mOjCgQTaaBsan0ZccynkDtW4IsCZctDbvmSoCis25KuMoD+BOBXgNGaA0+B 5na1ZJdWx9D96WPKezsy8MFOkNxr4jBvj3WtkjE3WT4ykxUQA3XeNGWzzmvP2VJqdsdH Cf3nc2S5lgDAmXOYrIHpGSkJV/hbthmP2G+cHJV8+JcKdCri/qalB0o+v6PyS4OJ0Dxy dNd70UQLuqA56aXexC34YK1Hut2GSf9ynVpKAJ5xBll67TlGOYtOeS1VWzThmXVwv573 7zcnsA+1tTbXyLlz7papTLbTEHzsQJZ7CufpSEnpcaGOjyeZXqK/wcxIbwaUmZFpoezq 1q3w== X-Gm-Message-State: AOJu0YxXbk7edAYwkxnfZ72dLisl1agDZ0i7tesFmpNJV3jRcQiGuaUO gzPTaxZMWERb3UJRnnmMIm9rfZat1oArsDPKKuIagqjTeWvOb1CSLjgPsQGQhIM= X-Google-Smtp-Source: AGHT+IHSYZkbX0gLCRsy9Tucyxb7lW8PEMaWLVh3Qb5sRsjvKO23KXolk6pWQCoFSePoOpBx50OBFw== X-Received: by 2002:a17:90b:e8c:b0:2e0:a77e:8305 with SMTP id 98e67ed59e1d1-2e31536f27cmr22551114a91.39.1729182109720; Thu, 17 Oct 2024 09:21:49 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55da0ffa5sm7223a91.51.2024.10.17.09.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:21:49 -0700 (PDT) Date: Thu, 17 Oct 2024 09:21:48 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH 0/6] Reduce scope address-of-packed-member warning Message-ID: <20241017092148.60429247@hermes.local> In-Reply-To: <20241017142214.1669370-1-bruce.richardson@intel.com> References: <20241017142214.1669370-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 15:22:07 +0100 Bruce Richardson wrote: > The warning for address-of-packed-member was being disabled globally in > DPDK. While for drivers which need to access hardware-defined > data-structures the use of packed may make sense, for normal libs and > applications the use of packed data should be generally avoided. > > This patchset initially applies some fixes for cases where we are > unnecessarily causing the warning to trigger. Thereafter the 6th patch > removes the global enabling of the warning and replaces it with more > selective disabling for drivers and for a couple of other components > which have not yet been fixed. > > Bruce Richardson (6): > ip_frag: remove use of unaligned variable > efd: remove unnecessary packed attributes > bus/ifpga: remove packed attribute > pipeline: remove packed attribute > net: add smaller IPv4 cksum function for simple cases > build: limit scope of packed member warning disabling > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > app/test-pmd/icmpecho.c | 23 +---------- > app/test-pmd/txonly.c | 22 +---------- > app/test/packet_burst_generator.c | 49 +----------------------- > app/test/test_reassembly_perf.c | 29 +------------- > config/meson.build | 1 - > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > drivers/meson.build | 9 +++-- > examples/ipsec-secgw/meson.build | 6 +++ > lib/efd/rte_efd.c | 4 +- > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > lib/net/rte_ip.h | 33 ++++++++++++++++ > lib/pipeline/rte_table_action.c | 2 +- > lib/vhost/meson.build | 5 ++- > 14 files changed, 60 insertions(+), 154 deletions(-) Any chance to just fix all the places and have it enabled globally?