From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80B7145B60; Thu, 17 Oct 2024 18:26:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 532F140616; Thu, 17 Oct 2024 18:26:42 +0200 (CEST) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 1DBD540616 for ; Thu, 17 Oct 2024 18:26:40 +0200 (CEST) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2e2e23f2931so983334a91.0 for ; Thu, 17 Oct 2024 09:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729182399; x=1729787199; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=PscVk/cEekiVY3eaPH3dX4TeaHgaJ666aItxtZO84YE=; b=VlXTqiBDbcFuTWOJyaaedJ+ru72jgQc1bqgjdxS1po2QgE7uyfIghV+h0FIa+HxVif U8YTmKwHNY2KrLH826wUe8OBmUPxddD7PBV4fnuiHlEHmaHTQV3AmOVaEA6WPSlrfAjL fkoqAbqNyP8R3gY86l1+tuayUOAeZlgnfmvR26FOQ7TDN0RCPoFwzkpO85B52fSLrDzP 0WRcwTlgk0g69EwBVuWPZQctbmDclX9k9Q4fXmrN0e/nIuV77cba3aSMbHzaSzHvfqIg jcl3dKUWF+HFdNaf2YkuM7A5nEiJO9NnvGgD/dURVoYpc7yHWoDpX8pf6b3Po/bU6l8T aNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729182399; x=1729787199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PscVk/cEekiVY3eaPH3dX4TeaHgaJ666aItxtZO84YE=; b=pdp7oQxeN4baOzUb15z9KwPXNMj77rrpFvKl4LC1MdNhldHj9T68SGqJ2OmxaP9Eal 6F2XSoHcpAnF7IDZzS2gCPOFQ29LbFIqe0J+nKx5yvfQhfZo9JAGyWrTC/K5BuDUYGwT qkb9bvPIO9VTnehXri87shf7FjiZzhpq0YuRtGvsNcDMyRiFl9v/277l1AaGEOCMPhp3 fbohcgH3anBOuIf4IJ2f5W1TKZiylfw/y6q89bz1hCWI7uXuONW1xIVYxIOjDhLVthJE EdFK0LGRN4Tf/QUJw2qMs/kvT/fXAIK2fNyTd5Rh/wKn7B01kZ9IZXNPjiYch5mtcorm 7JaQ== X-Gm-Message-State: AOJu0YwEm4q0u2K9EOZ9cz947ObykDFw3JsVPk/OqzUxkMflwoeM9brV qS3ywMKr0Pk9MsK07VNNPaVdvLc8jHH9Ba6rbKqqK+yE1ZJJ0BQGvr8DdSV7HqI= X-Google-Smtp-Source: AGHT+IHbi+bAfutdM/UnSmnPn7eH2CRTFchdWmTNnPHG3pYKvL0APlmxXtAjdvzLO5uVHD4Od0Cpmg== X-Received: by 2002:a17:90b:4a89:b0:2e2:d33b:cc with SMTP id 98e67ed59e1d1-2e3152e76admr24338951a91.21.1729182399206; Thu, 17 Oct 2024 09:26:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55d796a2csm23257a91.7.2024.10.17.09.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:26:38 -0700 (PDT) Date: Thu, 17 Oct 2024 09:22:55 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, Byron Marohn , Yipeng Wang Subject: Re: [PATCH 2/6] efd: remove unnecessary packed attributes Message-ID: <20241017092255.2f4fcb36@hermes.local> In-Reply-To: <20241017142214.1669370-3-bruce.richardson@intel.com> References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241017142214.1669370-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 15:22:09 +0100 Bruce Richardson wrote: > The structure "efd_online_group_entry" only consists of values which are > typedefs of "uint16_t", so packing the structure has no effect. The > "efd_online_chunk" structure has a mix of "uint8_t" and the > "efd_online_group_entry" struct, i.e. uint16_t values, but since the > first, uint8_t, member array is of even size, the packed attribute does > not affect the structure layout. > > Removing these packed attributes allows the library to compile cleanly > without "-Wno-address-of-packed-member" compiler flag. > > Signed-off-by: Bruce Richardson > --- Acked-by: Stephen Hemminger