From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFC1945B60; Thu, 17 Oct 2024 18:26:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D817540669; Thu, 17 Oct 2024 18:26:49 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 520C740669 for ; Thu, 17 Oct 2024 18:26:48 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2e2ad9825a7so836376a91.0 for ; Thu, 17 Oct 2024 09:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729182407; x=1729787207; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=l5Ft7fAqeaSZK6naGtX/QSeUEtWTHNgE4aHnxiGUylg=; b=B1Ve31vQOR6Owudd3YB79TvoqjskA+SXv1aJRZnPB/xBx5q3ro4e5Lmx8CBL5ORWvs z+nXE0MR/hmHItks5qcuf/JxgerouHXL/HhzR89nGhuXP0Fmk+u/IzCQcjvb85diDWhh AkoMfohc7bU7yNKbR8uoh1lXLojf0OxmoB+CvS3IdHOTBJQRDf+XfmD8f0WDGLBxfUWX Y3iAkJfss1tYNa9GxvpdFiSXk27bbLYxMLRQhbqJIkQOS/9Rqr+q3cM4ITMuyTjo/uOq dWSGu7M8Ifn4SjXa5oAuCNYb81uDdp4WNENu3JgxnkkPmay8MfX5ku2HUAbb9GSga4uL 1tlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729182407; x=1729787207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l5Ft7fAqeaSZK6naGtX/QSeUEtWTHNgE4aHnxiGUylg=; b=lfEJ3jTb98zY8U89lfKQyf1N59/zoqo+qKngXMw90l5sgNbSAC1ePIVtuOl6gKGNlc 48fme2cr+FowxJ1+1dOxVDaE10k7JE8+y8j+D5fg0f4qxoacEnsY3s+Q0ojdBfZbWubY jx3tOfF5lcWyZbjd+aO2vWaT6zJEBE0ZkzP2yzifmnro4Rzz0Eh1OObOtYTQmNqw8+qo sIrgxSHZX0KZpJPzoj+RKomKP6BwOgtbV/DhKK0C3Z5A+dr0KaFbe5v05zy+cQo+UAcD PYYKzpbdK47QXY77IGD8Z7FNrcnIKij+XoHjfI4PzicbxoS+MuW80To09FeIS00/H6rf yg5g== X-Gm-Message-State: AOJu0YyAzyez9MY/JuB6GocRbrPJA/D6huqhEozqVsnopHKovgsZD1IC R/kQdf2G7RLdybWXoecygm2mZJrU9TaHfFP38t8CBVgU7dNBhPuj/+xaDziumTypdfSDZSFIjJ7 b X-Google-Smtp-Source: AGHT+IEn/LBcPjO2Jev4RC12AuUke1FAVG1Ey11+VcS0JnkwCfH8PWuPxUPc7XPzRou3D2HthBRiog== X-Received: by 2002:a17:90a:2ec5:b0:2e2:c15f:1ffd with SMTP id 98e67ed59e1d1-2e3ab800acemr8866123a91.14.1729182407521; Thu, 17 Oct 2024 09:26:47 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55d796a2csm23257a91.7.2024.10.17.09.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:26:47 -0700 (PDT) Date: Thu, 17 Oct 2024 09:26:22 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, Konstantin Ananyev Subject: Re: [PATCH 1/6] ip_frag: remove use of unaligned variable Message-ID: <20241017092622.74f71061@hermes.local> In-Reply-To: <20241017142214.1669370-2-bruce.richardson@intel.com> References: <20241017142214.1669370-1-bruce.richardson@intel.com> <20241017142214.1669370-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 15:22:08 +0100 Bruce Richardson wrote: > If compiling with -Waddress-of-packed-member, we get a warning about the > use of the unaligned uint64_t value which is used to copy 8 bytes from > ip_hdr to the key. Replace this unaligned assignment with an equivalent > 8-byte constant-sized memcpy, allowing the compiler to choose optimal > instructions to do the assignment. > > Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger