From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB69F45B60; Thu, 17 Oct 2024 18:44:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4A8E40676; Thu, 17 Oct 2024 18:44:16 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 9579A4067E for ; Thu, 17 Oct 2024 18:44:14 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20c693b68f5so13068325ad.1 for ; Thu, 17 Oct 2024 09:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729183454; x=1729788254; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tLwmmAv1SuaSgGVXdL4ZW16DYTdqgVCZA47oirOwPVk=; b=cpEs9324XycNygsq1jp+nI6ff23mZ96oBVx2R6gObzAjChblmFy4gYQpEiLd/FFj9F bnuIEe1OBQabEJPzSbQWUcU32od04y/1tCAjSWkrOG2PrXK+pmTDic89ECRAXR7New6p V6wQvL5cCQNcH5IhQ0wSewSrR2JUR2O7I6gyyvA3WGT8KBrcCEF0laaCA/bxz44NWIK+ xAVi+0U2bQco7wyjFxU9YRGkSvjX7FD5xTPeLVqi/QrpY3AiSA4hujF2w3sANiRq9lC2 Ml4BAOfvwpKVFDsJ1EJNVHqjMaGOUtqJ25iyG51eo0VCyksh6XQC6vgKE2eORFjjqAA7 +TTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729183454; x=1729788254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tLwmmAv1SuaSgGVXdL4ZW16DYTdqgVCZA47oirOwPVk=; b=G+J6Bugqw40lAnAmm6X7Mo0NhIIKRGxeOJfFmt7R1NPF83lG9jV7/L4PjCy6cME/YK jyLRv392oIyXDi0nkXjbW0ZjoVlWjXBdP3oFybVDIRY/0opE+1nkaLWlkH0WTh86sYhN zBIoFmDzVWdhRGr2MIJ9RTSlhBpqQZf4l7qVuaNs2btqDZcISfBDkmiXUB+3BOK/TsY7 UwRD9Xmg3kk7Pa7QiG3VY/lHSVJxqiYdWKhBKmZ8yahglAz6jzYyV4EsXdbGGWEYiV7k l+0d7ln4PUaj2AJpGVmfwRUZ0yB02cyscuXMGDgRTUkWT4s22luGlGzI01OBXBD7450Y hobQ== X-Gm-Message-State: AOJu0YxMfaY4CMAGvjtG9XqWGPF88+U46Kp0+o1NdoiKfcLKZi81IN0M rqsUFLPsIJrfIW7/CGafljWGZ479lAJo5k3lOXxB8RRfdPybK56gAVa7A4lIfqU= X-Google-Smtp-Source: AGHT+IGbx+h/cQMe0wsTY5r+70UXkvsW2RxPmOv+v06MaYx4dlPp9wmEtEh4vSHMGkAeaKnYBcQNQw== X-Received: by 2002:a17:903:2309:b0:20b:6f02:b4e5 with SMTP id d9443c01a7336-20ca13f727dmr329313405ad.9.1729183453749; Thu, 17 Oct 2024 09:44:13 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d17fa5d55sm46684745ad.109.2024.10.17.09.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 09:44:13 -0700 (PDT) Date: Thu, 17 Oct 2024 09:35:51 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v2 05/18] net/r8169: add support for hw config Message-ID: <20241017093551.743eecc5@hermes.local> In-Reply-To: <20241017063200.26101-6-howard_wang@realsil.com.cn> References: <20241017063200.26101-1-howard_wang@realsil.com.cn> <20241017063200.26101-6-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 17 Oct 2024 14:31:47 +0800 Howard Wang wrote: > Implement the rtl_hw_config function to configure the hardware. > > Signed-off-by: Howard Wang More indent issues flagged in this patch ERROR:CODE_INDENT: code indent should use tabs where possible #292: FILE: drivers/net/r8169/r8169_hw.c:19: + int type, const u32 base_address)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #292: FILE: drivers/net/r8169/r8169_hw.c:19: + int type, const u32 base_address)$ ERROR:CODE_INDENT: code indent should use tabs where possible #299: FILE: drivers/net/r8169/r8169_hw.c:26: +^I (base_address & 0x000FFF);$